Commit Graph
1273 Commits
Author SHA1 Message Date
Axel Dörfler 967302c5b7 Fixed a stupid copy&paste bug.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18605 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-24 12:33:15 +00:00
Stefano Ceccherini 6545a394e7 More cleanups
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18602 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-24 10:09:11 +00:00
Axel Dörfler fa407130aa Now this should nail down bug #762 pretty well: BView::GetMouse() no calls the
private BWindow::_StealMouseMessage() which makes sure only messages for the
preferred handler are stolen, and also, that nothing gets lost that shouldn't
get lost.
Also updates the fLastMouseMoved view in case the message is actually removed
due to GetMouse().


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18601 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-24 09:52:12 +00:00
Stefano Ceccherini c944ee6c2d First try at cleaning up StyleBuffer.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18600 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-24 09:41:22 +00:00
Stefano Ceccherini 37f49a44b4 If show() fails, deselect the parent menu item.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18598 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-24 08:57:05 +00:00
Axel Dörfler 5ce268a62d You shouldn't eat mouse moved messages outside of the mouse down/up cycle.
At least there is a pending bug in BView::GetMouse() that causes this restriction.
This fixes bug #762 for now (will do the part in GetMouse() next).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18597 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-24 08:53:28 +00:00
Stefano Ceccherini a8945c367b added +1 to the textrect width in AutoResize(). Maybe it needs still more space. Fixes bug 764.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18584 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-23 10:11:44 +00:00
Stefano Ceccherini f60d8e0b59 Replaced Unlock() with UnlockFully() in BWindow's destructor, fixes bug
406


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18579 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-23 06:42:09 +00:00
Stefano Ceccherini f9d284011a invalidate the null style in BTextView::MakeEditable(). Fixes bug 362
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18568 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-22 15:25:24 +00:00
Stefano Ceccherini 0adbde4a9e Don't invoke the highlighted item if menu was closed using the ESC key
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18560 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-22 09:04:21 +00:00
Stefano Ceccherini 136869d8c0 Don't start tracking if user clicked and released mouse button on a zone without any item.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18559 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-22 08:55:52 +00:00
Stefano Ceccherini e8db36f1d2 Don't scroll to the selection when calling BTextView::Insert(). This fixes bug 506
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18547 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-21 12:42:01 +00:00
Stefano Ceccherini 27f1bc8217 Don't activate the window, because it will steal the focus from the current active window, and clicking elsewhere won't close the menu
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18537 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-18 10:26:29 +00:00
Stefano Ceccherini 6636dcac56 BTextView::DrawLines() was drawing some text over some already existing one. Fixes bug 738 (and also the weird text redrawing in Terminal and StyledEdit)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18518 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-17 08:00:27 +00:00
Stefano Ceccherini 4e338ac6df Started implementing menu keyboard navigation. Does only work for menubars because menu windows never get keyboard focus. Any idea how to solve this, since menu windows are B_AVOID_FOCUS both in beos and haiku?
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18517 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-17 06:12:48 +00:00
Stefano Ceccherini bfb0aa18d3 some adjustments at the menu width calculation. Menus are generally a bit less 'compacted' now. Might need review
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18501 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-13 06:06:00 +00:00
Stefano Ceccherini 509c95da0e Added s small workaround in BMenu::OkToProceed() to fix deskbar not opening the be menu under heavy load (or, always, under qemu) if the mouse button was released too soon. Beos seems to do something similar, although it's a hack
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18500 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-13 05:39:00 +00:00
Axel Dörfler 95e5d8a86c * Turns out GCC 4 didn't like my latest changes in Shelf.cpp.
* Further cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18493 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-11 20:28:33 +00:00
Axel Dörfler 78aa8eea3d * Added get_uint32_color() again, the previous "hack" doesn't compile
on GCC 4.
* Fixed buggy scripting error responses: "error" is only included on
  error, and B_ERROR (-1) can hardly be a candidate for the
  BMessage::what field (uint32).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18490 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-11 20:01:26 +00:00
Axel Dörfler 6e0e4ca6b2 * Fixed bug that let the dragger not hide in the Deskbar (was in ListManage(), now
in _AddToList()).
* Cleaned up BDragger and BShelf a bit, moved private classes into the BPrivate
  namespace, renamed private methods to have the '_' prefix.
* Rewrote Dragger.h.
* Is that static dragger list needed at all? And if so, for what?`


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18487 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-11 19:26:37 +00:00
Axel Dörfler 943da1a9b7 Arrow-up/down will now select the first item in the list if there is no selected
item yet.
This fixes bug #728.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18480 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-11 09:38:18 +00:00
Stefano Ceccherini 8ba08d23c4 fClickOffset wasn't maintained when Select() was called. Should improve problem described in bug 494 a bit
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18462 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-08 15:39:31 +00:00
Stefano Ceccherini b6bf3346f3 When calculating the menu frame, take the resizeToFit parameter into account. This fixes bug 574, although the implementation isn't probably completed yet. Needs more investigation.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18459 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-08 14:07:09 +00:00
Axel Dörfler 9319c7b88f We don't add the Alt-w shortcut to modal windows anymore
by default, thanks to Darkwyrm for pointing to this.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18450 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-07 21:34:07 +00:00
Stefano Ceccherini ea4eba9f14 Simplified a bit a part of FindLineBreak. Removed a now useless comment
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18361 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-03 13:12:54 +00:00
Axel Dörfler f1d0add2ca _AddReplicant() now calls CanAcceptReplicantView(), too, which fixes the incorrect
replicant positioning upon add, a.k.a. bug #639: Deskbar relied on that method
being called to add positioning information to the replicant.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18354 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-02 20:47:27 +00:00
Axel Dörfler 4fec945a03 Stefano's investigations did the trick: added MenusBeginning()/MenusEnded() in
the shortcut evaluation.
This fixes bug #531.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18338 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-02 10:16:10 +00:00
Stefano Ceccherini 0354c3c2d5 Added missing return statement
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18326 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-08-01 09:30:17 +00:00
Stefano Ceccherini 7212229343 The BWindow destructor is called with the window locked, but we need to unlock to acquire the menu semaphore. Updated BBitmap to lock he window on quit too. This fixes last problem mentioned in bug 406
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18156 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-07-15 13:12:01 +00:00
Stefano Ceccherini cf2ef43abd fixed a small problem with StealFocus and RestoreFocus
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18148 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-07-14 12:09:49 +00:00
Jérôme Duval 17408188c5 SetValue now avoids itself switching off
also added an ASSERT to check the current radio button is still on after the switching off process
this fixes the weird behavior in the password window of the ScreenSaver prefapp


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18107 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-07-12 11:27:04 +00:00
Jérôme Duval 11235ae729 "class" is added by BArchivable::Archive(), no need to duplicate
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18086 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-07-10 17:38:12 +00:00
Ithamar R. Adema f9d5f90ecc Added missing ColumnTypes.cpp/.h to sourcetree, and added it to the build.
This should make our BColumnListView completely usable.
(ColumnTypes files were taken from imkit SVN)



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18081 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-07-09 17:09:25 +00:00
Jérôme Duval 3a543720c4 archives with BControl
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18074 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-07-08 13:26:55 +00:00
Jérôme Duval 9fcdf0e92c MenuItem::Archive uses BArchivable::Archive
inverted the enable state when initing the BMenu


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18071 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-07-08 12:56:18 +00:00
Jérôme Duval 9b224ec82e add item frames to BMenu archive
add class names to BMenuItem archives


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18069 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-07-08 00:38:31 +00:00
Stefano Ceccherini 8cc767ee45 call BView::Archive() first, pass deep when needed
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18068 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-07-07 20:23:00 +00:00
Stefano Ceccherini 056abb9e93 partially reverted to an old version, should fix strange problems with menufields
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18067 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-07-07 19:45:23 +00:00
Stefano Ceccherini 931aebe962 Deleting replicants now works
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18066 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-07-07 19:16:50 +00:00
Jérôme Duval bbcfef1f6c archive deep when needed, restore menu items
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18054 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-07-07 16:01:37 +00:00
Jérôme Duval f1cc26391b archives menu items in menu archive
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18053 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-07-07 15:51:40 +00:00
Stefano Ceccherini b92418a82c Check for NULL text, otherwise strlen() can crash. Might even fix bug 677
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18044 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-07-05 19:50:08 +00:00
Stefano Ceccherini 9d9c1564b8 One of the BMenu::AddItem() variations crashed if the passed item was NULL. Fixes bug 465
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18026 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-07-04 12:37:59 +00:00
Jérôme Duval 955bc004af little cleanup
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18025 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-07-04 09:44:40 +00:00
Jérôme Duval b8fc177d9c * default source BRect is now offset to B_ORIGIN because Bitmap bounds lefttop could be something else than (0,0). This caused some bugs in Haiku SoundRecorder app
i* thus the NOTE in Painter isn't valid anymore
* in Painter::_DrawBimap() moved scale computation after potential changes to BRects
* fix typo : right => bottom. This caused a bug in Haiku Mouse preferences app


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18017 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-07-03 19:49:51 +00:00
Jérôme Duval eddeb67808 the data type is now consistent with the one used in input_server
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@18007 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-07-02 18:39:45 +00:00
Jérôme Duval deca617c6b position is relative : add to the top left point of the original rect
fixes bug #700


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17987 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-06-30 19:24:06 +00:00
Jérôme Duval 58ad2aba29 added BColumnListView to libbe.so
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17927 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-06-26 15:53:41 +00:00
Axel Dörfler 8ebbfab333 When the B_COMMAND key is pressed, the event will not be forwarded to the target
handler anymore, no matter if a shortcut existed or not.
This fixes bug #498.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17883 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-06-20 15:20:18 +00:00
Stefano Ceccherini 3e9e6a58c8 DrawLines() didn't respect the passed offset, thus redrawing over the old text. This exposed some other bugs in the refreshing mechanism. Hopefully fixed them all, although there might be some problems still with the inline input method
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@17863 a95241bf-73f2-0310-859d-f6bbb57e9c96
2006-06-17 12:14:02 +00:00