num_endpoints will be changed by the ioctl; we need to use the old
one when deleting the array.
fDescriptor is just zeroed if we fail to fetch, so just perform
the deletions up-front.
The uart virtual address changes as soon as we apply the kernel memory
map. gUART is used only after that, from serial_init() onwards. So it
should use the virtual address, and not the physical address it was
previously created with while parsing the FDT.
Change-Id: I8c8a024fe564b49d6555f8e48f5ab31652d30708
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10068
Reviewed-by: Fredrik Holmqvist <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
this is the abort way of closing a connection.
tested with golang's http test TestTransportGzip. All TestTransport* pass.
Change-Id: Ib79516eb8a16480d7a4425675748ff76554e9c6c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10054
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
- Fix tracing when TRACE_MOVEMENT_MAKER is defined.
This seems to be a leftover from the migration of
movement_maker.cpp from kernel to user space at
hrev56293.
- Improve tracing by adding a call per method
When tracing is enabled, the class name and the function
method is provided to trace every method call by using
new CALLER helper macro.
- Add destructor as well to improve tracing.
Change-Id: I60b49b1d83a8abeb3ba6835d0e303f1b28dde90a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/9909
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
These aren't in POSIX but glibc and FreeBSD support them,
and our ICUTimeData class expects that strftime will handle them.
Fixes#18471 and some of the problems described in #14356.
Clean unix address buffer before use : more robust to bad user addresses missing trailing '\0',
and prevents leaking data
Change-Id: I769b895327f97870886309a7054facd3c169fb7f
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10052
Reviewed-by: Adrien Destugues <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
* It was not supposed to use panel color as background; it now uses
document color instead.
* Improved color computation with less calls to ui_color(), and only
two place to change in the future, if ever needed.
* Still does not look good in dark mode, though (no changes there).
Change-Id: I2aa355728de4b7da1939417adf6922dde77aac44
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10053
Reviewed-by: nephele nephele <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Prepare for replacement of modified version used in input_server addons.
Adapt existing callers.
The "this" argument is required, and the CALLED macro can only set it to
one single value for an entire file currently. So, in any case where at
least one standalone function or static method uses CALLED, the macro
has to use a NULL pointer for all calls.
Change-Id: I42fdcbeaf6dd039d4c4369818220ad85e0b8087e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10041
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
In BeOS, the tab label was synchronized with the view name. This means
BTab::SetLabel would change the view name. This behavior is unexpected,
and also annoying, for example it prevents using localized tab labels
but fixed view names for scripting.
* Document this divergence from BeOS in the Haiku book
* Detect if we're running in a BeOS app to preserve the old behavior
then
Change-Id: I5b758a035fe8752cee2ea7789a30ea47a01467b9
Reviewed-on: https://review.haiku-os.org/c/haiku/+/122
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Jérôme Duval <[email protected]>
Terminal masks SIGUSR1 in TermApp for its own use, but doesn't unmask it for the processes it creates. The bug must have been exposed by 91acc30 (kernel/team: use child-forked thread signal_mask)
Change-Id: I4eed723b50bd92d23a3e7e43bfdd2c11162ce9d4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10047
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
The "Location" field in the File info window will be clickable if it
refers to a local file. This will open the containing folder in the Tracker.
Fixes#8842
Change-Id: I0b17587607275da12aac89a1716ec85652a31e29
Reviewed-on: https://review.haiku-os.org/c/haiku/+/9796
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
Reviewed-by: nephele nephele <[email protected]>
If we only checked one, then of course we can't set LC_ALL,
as that will override ones we didn't verify were the same.
Seems this code has been wrong since it was first imported in 2010.
Fixes#19446.
SetScreenMode() and other methods around here also acquire it
in this way.
Adjust one place in ServerApp that would cause a lock-order-inversion
otherwise.
Should fix#19837.
Add and fix description of the current values for fingerWith
field and related constants along with future expectations
for the same. The latest explainted as TODO item.
Change-Id: I876a9cf03a935309159401a6c88d9047bf225f90
Reviewed-on: https://review.haiku-os.org/c/haiku/+/9863
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Previously we ran DHCP negotiation on the looper thread. This meant
that we just blocked it for long periods of time, which stopped
configuration settings changes from working properly, and causing
the Network preferences panel to hang when net_server failed to
respond to its messages.
Now, we spawn a separate thread to do the real work on, and unlock
the looper around the recvfrom() with long timeouts. There's now a
kMsgAutoConfigureFailed that is sent when auto-configuration fails,
so that the AutoconfigLooper can fallback as before. Additionally,
the main NetServer class quits loopers for devices on any configuration
change, rather than deferring it unecessarily (and possibly wrongly, in
some cases.)
Fixes#18037. Probably fixes#17300 and may help with others.
The old code works because in icon-mode you have just one row
but this is not the intended way to determine the pose location
in icon mode (and mini-icon mode).
Refactor CommitActivePose() and kEditName in PoseView.
Use CurrentPoseList() to use filtered or regular pose list
(but don't update both).
In practical terms this should do nothing.
Change-Id: Iedafb147a6963bdb1411491be25641141325c1bf
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10025
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
This was preventing open() from getting the volume icon
once a FAT volume was mounted. This is now handled in the VFS.
Fixes#19303.
Change-Id: I5837bcdd4496b5eda13610e9ded661f1529364ea
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10023
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
Previously this actually succeeded, which could obviously cause
disk corruption and other such problems.
While at it, clean up some code style.
Fixes#16734. Related to #19303.
This way, if the Desktop has locked its window list, RemoveWindow
will wait until the lock is released, at which time we're guaranteed
that the Desktop object will no longer be using this window.
May fix#19750 and related tickets.
Augustin Cavalier