Augustin Cavalier
cbfbbf6d4d
Since BObjectList is a template class, this only breaks ABI where BObjectList was exposed in public methods, and even then it's only a name mangling break and we should be able to add compatibility methods if necessary. (The old "bool owning" member variable is left intact for ABI compatibility, for the moment, though it's otherwise unused now.) Tracker's PoseList is the only remaining type that has a "bool owning" switch in the constructor rather than template parameters. This should significantly improve the output of static code analysis tools that previously detected list operations as causing use-after-frees and double-frees, as well as make code maintenance easier by making it easier to determine what list owns (or does not own) an object. It should also be a minor performance optimization, since the branches for calls to delete/free should now be optimized out altogether. Still boots to desktop and Tracker, Deskbar, Debugger all tested and verified as working. Change-Id: If2a24a6f0d22e7a506ef554fcfdd328907279ed4 Reviewed-on: https://review.haiku-os.org/c/haiku/+/8915 Reviewed-by: waddlesplash <[email protected]>
73 lines
1.8 KiB
C++
73 lines
1.8 KiB
C++
/*
|
|
* Copyright 2009, Ingo Weinhold, [email protected].
|
|
* Distributed under the terms of the MIT License.
|
|
*/
|
|
#ifndef DISASSEMBLED_CODE_H
|
|
#define DISASSEMBLED_CODE_H
|
|
|
|
|
|
#include <ObjectList.h>
|
|
|
|
#include "SourceCode.h"
|
|
|
|
|
|
class BString;
|
|
class ContiguousStatement;
|
|
|
|
|
|
class DisassembledCode : public SourceCode {
|
|
public:
|
|
DisassembledCode(SourceLanguage* language);
|
|
~DisassembledCode();
|
|
|
|
virtual bool Lock();
|
|
virtual void Unlock();
|
|
|
|
virtual SourceLanguage* GetSourceLanguage() const;
|
|
|
|
virtual bool GetStatementLocationRange(
|
|
const SourceLocation& location,
|
|
SourceLocation& _start,
|
|
SourceLocation& _end) const;
|
|
|
|
virtual LocatableFile* GetSourceFile() const;
|
|
|
|
Statement* StatementAtAddress(target_addr_t address) const;
|
|
Statement* StatementAtLocation(
|
|
const SourceLocation& location) const;
|
|
TargetAddressRange StatementAddressRange() const;
|
|
|
|
// LineDataSource
|
|
virtual int32 CountLines() const;
|
|
virtual const char* LineAt(int32 index) const;
|
|
virtual int32 LineLengthAt(int32 index) const;
|
|
|
|
public:
|
|
bool AddCommentLine(const BString& line);
|
|
bool AddInstructionLine(const BString& line,
|
|
target_addr_t address, target_size_t size);
|
|
// instructions must be added in
|
|
// ascending address order
|
|
|
|
private:
|
|
struct Line;
|
|
|
|
typedef BObjectList<Line, true> LineList;
|
|
typedef BObjectList<ContiguousStatement> StatementList;
|
|
|
|
private:
|
|
bool _AddLine(const BString& line,
|
|
ContiguousStatement* statement);
|
|
static int _CompareAddressStatement(
|
|
const target_addr_t* address,
|
|
const ContiguousStatement* statement);
|
|
|
|
private:
|
|
SourceLanguage* fLanguage;
|
|
LineList fLines;
|
|
StatementList fStatements;
|
|
};
|
|
|
|
|
|
#endif // DISASSEMBLED_CODE_H
|