Augustin Cavalier
cbfbbf6d4d
Since BObjectList is a template class, this only breaks ABI where BObjectList was exposed in public methods, and even then it's only a name mangling break and we should be able to add compatibility methods if necessary. (The old "bool owning" member variable is left intact for ABI compatibility, for the moment, though it's otherwise unused now.) Tracker's PoseList is the only remaining type that has a "bool owning" switch in the constructor rather than template parameters. This should significantly improve the output of static code analysis tools that previously detected list operations as causing use-after-frees and double-frees, as well as make code maintenance easier by making it easier to determine what list owns (or does not own) an object. It should also be a minor performance optimization, since the branches for calls to delete/free should now be optimized out altogether. Still boots to desktop and Tracker, Deskbar, Debugger all tested and verified as working. Change-Id: If2a24a6f0d22e7a506ef554fcfdd328907279ed4 Reviewed-on: https://review.haiku-os.org/c/haiku/+/8915 Reviewed-by: waddlesplash <[email protected]>
52 lines
974 B
C++
52 lines
974 B
C++
/*
|
|
* Copyright 2013, Ingo Weinhold, [email protected].
|
|
* Distributed under the terms of the MIT License.
|
|
*/
|
|
#ifndef TEXT_TABLE_H
|
|
#define TEXT_TABLE_H
|
|
|
|
|
|
#include <InterfaceDefs.h>
|
|
#include <ObjectList.h>
|
|
#include <StringList.h>
|
|
|
|
|
|
namespace BPrivate {
|
|
|
|
|
|
class TextTable {
|
|
public:
|
|
TextTable();
|
|
~TextTable();
|
|
|
|
int32 CountColumns() const;
|
|
void AddColumn(const BString& title,
|
|
enum alignment align = B_ALIGN_LEFT,
|
|
bool canTruncate = false);
|
|
|
|
int32 CountRows() const;
|
|
BString TextAt(int32 rowIndex, int32 columnIndex) const;
|
|
void SetTextAt(int32 rowIndex, int32 columnIndex,
|
|
const BString& text);
|
|
|
|
void Print(int32 maxWidth);
|
|
|
|
private:
|
|
struct Column;
|
|
typedef BObjectList<Column, true> ColumnList;
|
|
typedef BObjectList<BStringList, true> RowList;
|
|
|
|
private:
|
|
ColumnList fColumns;
|
|
RowList fRows;
|
|
};
|
|
|
|
|
|
} // namespace BPrivate
|
|
|
|
|
|
using ::BPrivate::TextTable;
|
|
|
|
|
|
#endif // TEXT_TABLE_H
|