i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CharacterSetRoster: Fix PVS 528-530

Browse Source 
Remove unneed if conditions, since unsigned type value is never < 0.

Change-Id: I76621f79883752cd3560c6e02f18384b1ddd9cf3
Reviewed-on: https://review.haiku-os.org/797
Reviewed-by: Barrett17 <[email protected]>
This commit is contained in:
Murai Takashi
2018-12-25 17:49:36 +00:00
committed by Barrett17
parent 12dba4e70f
commit 09a5380d0c
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/kits/textencoding/CharacterSetRoster.cpp
+3 -3
View File
@@ -56,7 +56,7 @@ BCharacterSetRoster::StopWatching(BMessenger target)
const BCharacterSet * const BCharacterSet *
BCharacterSetRoster::GetCharacterSetByFontID(uint32 id) BCharacterSetRoster::GetCharacterSetByFontID(uint32 id)
{ {
if ((id < 0) || (id >= character_sets_by_id_count)) { if (id >= character_sets_by_id_count) {
return NULL; return NULL;
} }
return character_sets_by_id[id]; return character_sets_by_id[id];
@@ -65,7 +65,7 @@ BCharacterSetRoster::GetCharacterSetByFontID(uint32 id)
const BCharacterSet * const BCharacterSet *
BCharacterSetRoster::GetCharacterSetByConversionID(uint32 id) BCharacterSetRoster::GetCharacterSetByConversionID(uint32 id)
{ {
if ((id+1 < 0) || (id+1 >= character_sets_by_id_count)) { if (id + 1 >= character_sets_by_id_count) {
return NULL; return NULL;
} }
return character_sets_by_id[id+1]; return character_sets_by_id[id+1];
@@ -74,7 +74,7 @@ BCharacterSetRoster::GetCharacterSetByConversionID(uint32 id)
const BCharacterSet * const BCharacterSet *
BCharacterSetRoster::GetCharacterSetByMIBenum(uint32 MIBenum) BCharacterSetRoster::GetCharacterSetByMIBenum(uint32 MIBenum)
{ {
if ((MIBenum < 0) || (MIBenum > maximum_valid_MIBenum)) { if (MIBenum > maximum_valid_MIBenum) {
return NULL; return NULL;
} }
return character_sets_by_MIBenum[MIBenum]; return character_sets_by_MIBenum[MIBenum];