i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bindfs_create(): Return vnode reference, don't leak source ref

Browse Source 
Fixes #10244.
This commit is contained in:
Ingo Weinhold
2013-11-26 01:59:39 +01:00
parent 8e7ee8f0d9
commit 0bb1b3e269
1 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/kernel/file_systems/bindfs/kernel_interface.cpp
+19 -1
View File
@@ -587,8 +587,26 @@ bindfs_create(fs_volume* fsVolume, fs_vnode* fsNode, const char* name,
FETCH_SOURCE_VOLUME_AND_NODE(volume, node->ID());
return sourceNode->ops->create(sourceVolume, sourceNode, name, openMode,
error = sourceNode->ops->create(sourceVolume, sourceNode, name, openMode,
perms, _cookie, _newVnodeID);
if (error != B_OK)
return error;
error = get_vnode(fsVolume, *_newVnodeID, NULL);
// on error remove the newly created source entry
if (error != B_OK)
sourceNode->ops->unlink(sourceVolume, sourceNode, name);
// create() on the source gave us a reference we don't need any longer
vnode* newSourceVnode;
if (vfs_lookup_vnode(sourceVolume->id, *_newVnodeID, &newSourceVnode)
== B_OK) {
vfs_put_vnode(newSourceVnode);
}
return error;
}