String.cpp: Fix PVS 625

Fix 'newBuffer' is assigned values twice successively.

Change-Id: Id6ec9d40ba279a68e17922931098a6a908eb7156
Reviewed-on: https://review.haiku-os.org/728
Reviewed-by: Jérôme Duval <[email protected]>

src/kits/support/String.cpp

@@ -102,8 +102,8 @@ public:
 			if (fBuffer != NULL)
 				fBufferSize *= 2;
 
-			int32* newBuffer = NULL;
-			newBuffer = (int32*)realloc(fBuffer, fBufferSize * sizeof(int32));
+			int32* newBuffer =
+				(int32*)realloc(fBuffer, fBufferSize * sizeof(int32));
 			if (newBuffer == NULL)
 				return false;