i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Discard column info in Debugger

Browse Source 
* With them Debugger doesn't allow setting breakpoints inside functions.
* Workaround for #15159. Further explanation by anevilyak is also there.

Change-Id: I661b7dcb28a4c02f671b85cb5c26fa0bd5a53078
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1892
Reviewed-by: Rene Gollent <[email protected]>
This commit is contained in:
Kacper Kasper
2019-09-28 01:27:42 +00:00
committed by Rene Gollent
parent 07838f4cd3
commit 14c3e38739
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/kits/debugger/debug_info/DwarfImageDebugInfo.cpp
+9 -3
View File
@@ -837,7 +837,9 @@ DwarfImageDebugInfo::GetStatement(FunctionDebugInfo* _function,
if (state.isStatement) {
statementAddress = state.address;
statementLine = state.line - 1;
statementColumn = std::max(state.column - 1, (int32)0);
// discard column info until proper support is implemented
// statementColumn = std::max(state.column - 1, (int32)0);
statementColumn = 0;
}
}
@@ -931,7 +933,9 @@ DwarfImageDebugInfo::GetStatementAtSourceLocation(FunctionDebugInfo* _function,
if (state.isStatement) {
statementAddress = state.address;
statementLine = state.line - 1;
statementColumn = std::max(state.column - 1, (int32)0);
// discard column info until proper support is implemented
// statementColumn = std::max(state.column - 1, (int32)0);
statementColumn = 0;
}
}
@@ -1053,7 +1057,9 @@ DwarfImageDebugInfo::_AddSourceCodeInfo(CompilationUnit* unit,
if (state.isStatement) {
statementAddress = state.address;
statementLine = state.line - 1;
statementColumn = std::max(state.column - 1, (int32)0);
// discard column info until proper support is implemented
// statementColumn = std::max(state.column - 1, (int32)0);
statementColumn = 0;
}
}