media_kit: General maintainance

* Move !missing_symbols.cpp in the legacy directory.
* Move useless methods in a Deprecated.cpp file.
* SetRealtimeFlags / GetRealtimeFlags are useless, they
don't make sense nowadays.
* The symbols are anyway preserved.
This commit is contained in:
Dario Casalinuovo
2015-12-05 18:59:38 +01:00
parent 5fb16fc743
commit 226be01113
4 changed files with 12 additions and 65 deletions
+11 -8
View File
@@ -320,9 +320,7 @@ public:
// _inOutCount defaults to 1 // _inOutCount defaults to 1
// if unspecified (NULL). // if unspecified (NULL).
// General MediaKit configuration: // Returns the preferred audio buffer size
status_t SetRealtimeFlags(uint32 enabledFlags);
status_t GetRealtimeFlags(uint32* _enabledFlags);
ssize_t AudioBufferSizeFor(int32 channelCount, ssize_t AudioBufferSizeFor(int32 channelCount,
uint32 sampleFormat, float frameRate, uint32 sampleFormat, float frameRate,
bus_type busType = B_UNKNOWN_BUS); bus_type busType = B_UNKNOWN_BUS);
@@ -345,10 +343,6 @@ public:
virtual ~BMediaRoster(); virtual ~BMediaRoster();
private: private:
// This method is deprecated:
status_t SetOutputBuffersFor(const media_source& output,
BBufferGroup* group,
bool willReclaim = false);
// Reserving virtual function slots. // Reserving virtual function slots.
virtual status_t _Reserved_MediaRoster_0(void*); virtual status_t _Reserved_MediaRoster_0(void*);
@@ -367,13 +361,22 @@ private:
// Roster() or CurrentRoster(). // Roster() or CurrentRoster().
BMediaRoster(); BMediaRoster();
// TODO: Looks like these can be safely removed: // Those methods are deprecated or considered useless
// NOTE: planned to be removed once we break the API.
status_t SetOutputBuffersFor(const media_source& output,
BBufferGroup* group,
bool willReclaim = false);
status_t SetRealtimeFlags(uint32 enabledFlags);
status_t GetRealtimeFlags(uint32* _enabledFlags);
static status_t ParseCommand(BMessage& reply); static status_t ParseCommand(BMessage& reply);
status_t GetDefaultInfo(media_node_id forDefault, status_t GetDefaultInfo(media_node_id forDefault,
BMessage& _config); BMessage& _config);
status_t SetRunningDefault(media_node_id forDefault, status_t SetRunningDefault(media_node_id forDefault,
const media_node& node); const media_node& node);
// End of deprecated methods
private: private:
uint32 _reserved_media_roster_[67]; uint32 _reserved_media_roster_[67];
+1
View File
@@ -22,6 +22,7 @@ for architectureObject in [ MultiArchSubDirSetup ] {
SharedLibrary [ MultiArchDefaultGristFiles libmedia.so ] : SharedLibrary [ MultiArchDefaultGristFiles libmedia.so ] :
# Private Media Kit # Private Media Kit
!missing_symbols.cpp !missing_symbols.cpp
Deprecated.cpp
MediaRecorder.cpp MediaRecorder.cpp
# Public Media Kit # Public Media Kit
-57
View File
@@ -3344,22 +3344,6 @@ BMediaRoster::IsRunning()
} }
status_t
BMediaRoster::SetRealtimeFlags(uint32 enabled)
{
UNIMPLEMENTED();
return B_ERROR;
}
status_t
BMediaRoster::GetRealtimeFlags(uint32* _enabled)
{
UNIMPLEMENTED();
return B_ERROR;
}
ssize_t ssize_t
BMediaRoster::AudioBufferSizeFor(int32 channelCount, uint32 sampleFormat, BMediaRoster::AudioBufferSizeFor(int32 channelCount, uint32 sampleFormat,
float frameRate, bus_type busKind) float frameRate, bus_type busKind)
@@ -3585,21 +3569,8 @@ BMediaRoster::~BMediaRoster()
sDefaultInstance = NULL; sDefaultInstance = NULL;
} }
// #pragma mark - private BMediaRoster // #pragma mark - private BMediaRoster
//! Deprecated call.
status_t
BMediaRoster::SetOutputBuffersFor(const media_source& output,
BBufferGroup* group, bool willReclaim)
{
UNIMPLEMENTED();
debugger("BMediaRoster::SetOutputBuffersFor missing\n");
return B_ERROR;
}
// FBC reserved virtuals // FBC reserved virtuals
status_t BMediaRoster::_Reserved_MediaRoster_0(void*) { return B_ERROR; } status_t BMediaRoster::_Reserved_MediaRoster_0(void*) { return B_ERROR; }
status_t BMediaRoster::_Reserved_MediaRoster_1(void*) { return B_ERROR; } status_t BMediaRoster::_Reserved_MediaRoster_1(void*) { return B_ERROR; }
@@ -3622,34 +3593,6 @@ BMediaRoster::BMediaRoster()
Run(); Run();
} }
// TODO: Looks like these can be safely removed:
/*static*/ status_t
BMediaRoster::ParseCommand(BMessage& reply)
{
UNIMPLEMENTED();
return B_ERROR;
}
status_t
BMediaRoster::GetDefaultInfo(media_node_id forDefault, BMessage& config)
{
UNIMPLEMENTED();
return B_ERROR;
}
status_t
BMediaRoster::SetRunningDefault(media_node_id forDefault,
const media_node& node)
{
UNIMPLEMENTED();
return B_ERROR;
}
// #pragma mark - static variables // #pragma mark - static variables
BMediaRoster* BMediaRoster::sDefaultInstance = NULL; BMediaRoster* BMediaRoster::sDefaultInstance = NULL;