* Do not delete the private data of the BMessage! This fixes a crash when
dragging and dropping icons from one FileTypes window to another (in case the dragged icon was a vector icon). * Checked the other similar places, but all seems fine. Added a comment in one place why no data is leaked, although it may seem to at first sight. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28159 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
@@ -80,7 +80,7 @@ icon_for_type(const BMimeType& type, uint8** _data, size_t* _size,
|
|||||||
if (source != kNoIcon) {
|
if (source != kNoIcon) {
|
||||||
*_data = data;
|
*_data = data;
|
||||||
*_size = size;
|
*_size = size;
|
||||||
}
|
} // NOTE: else there is no data, so nothing is leaked.
|
||||||
if (_source)
|
if (_source)
|
||||||
*_source = source;
|
*_source = source;
|
||||||
|
|
||||||
@@ -599,7 +599,6 @@ IconView::MessageReceived(BMessage* message)
|
|||||||
|
|
||||||
delete large;
|
delete large;
|
||||||
delete mini;
|
delete mini;
|
||||||
delete data;
|
|
||||||
|
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user