i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nfsv4: Don't trigger wire errors for non-ok protocol responses

Browse Source 
* NFSv4 specs say all compound replies must be handled (even errors)
* Don't set fDecodeError unless something is physically wrong within
  the wire response.
* "Server said no" != "The compound reply is Garbage"

Change-Id: I8523ff04553dd3415c656d82615aa608be34f88c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11247
Haiku-Format: Haiku-format Bot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
Reviewed-by: Jim906 Jim906 <[email protected]>
Tested-by: Commit checker robot <[email protected]>
This commit is contained in:
Alexander von Gluck IV
2026-07-08 19:52:40 +00:00
committed by Alexander von Gluck
parent b5fd959d60
commit 342cb985e3
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/kernel/file_systems/nfs4/ReplyInterpreter.cpp
+1 -2
View File
@@ -902,11 +902,10 @@ ReplyInterpreter::_OperationError(Opcode op)
#if DEBUG
ERROR("NFS Error: %s\n", strerror(result));
#else
// Lookup failures are routine. Reporting them could obscure more important error messages.
// Lookup failures are routine. Reporting could obscure important error messages.
if (op != OpLookUp || result != B_ENTRY_NOT_FOUND)
ERROR("NFS Error: %s\n", strerror(result));
#endif
fDecodeError = true;
}
return result;
}