i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Attribute directories must have the S_IFDIR flag set, attribute files

Browse Source 
the S_IFREG flag. The missing flags caused the original BFS to crash
on our files.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@12796 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Axel Dörfler
2005-05-24 10:38:59 +00:00
parent a5b8374506
commit 36cb9bac61
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/kernel/file_systems/bfs/Inode.cpp
+4 -2
View File
@@ -990,7 +990,8 @@ Inode::CreateAttribute(Transaction &transaction, const char *name, uint32 type,
{
// do we need to create the attribute directory first?
if (Attributes().IsZero()) {
status_t status = Inode::Create(transaction, this, NULL, S_ATTR_DIR | 0666, 0, 0, NULL);
status_t status = Inode::Create(transaction, this, NULL,
S_ATTR_DIR | S_DIRECTORY | 0666, 0, 0, NULL);
if (status < B_OK)
RETURN_ERROR(status);
}
@@ -1000,7 +1001,8 @@ Inode::CreateAttribute(Transaction &transaction, const char *name, uint32 type,
return B_ERROR;
// Inode::Create() locks the inode for us
return Inode::Create(transaction, attributes, name, S_ATTR | 0666, 0, type, NULL, attribute);
return Inode::Create(transaction, attributes, name,
S_ATTR | S_REGULAR | 0666, 0, type, NULL, attribute);
}
src/tests/add-ons/kernel/file_systems/bfs/r5/Inode.cpp
+4 -2
View File
@@ -953,7 +953,8 @@ Inode::CreateAttribute(Transaction *transaction, const char *name, uint32 type,
{
// do we need to create the attribute directory first?
if (Attributes().IsZero()) {
status_t status = Inode::Create(transaction, this, NULL, S_ATTR_DIR | 0666, 0, 0, NULL);
status_t status = Inode::Create(transaction, this, NULL,
S_ATTR_DIR | S_DIRECTORY | 0666, 0, 0, NULL);
if (status < B_OK)
RETURN_ERROR(status);
}
@@ -963,7 +964,8 @@ Inode::CreateAttribute(Transaction *transaction, const char *name, uint32 type,
return B_ERROR;
// Inode::Create() locks the inode for us
return Inode::Create(transaction, attributes, name, S_ATTR | 0666, 0, type, NULL, attribute);
return Inode::Create(transaction, attributes, name,
S_ATTR | S_REGULAR | 0666, 0, type, NULL, attribute);
}