Fixed design flaw in the UHCI fragment implementation and a memory leak both introduced in the last commit.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@20418 a95241bf-73f2-0310-859d-f6bbb57e9c96
2007-03-25 11:43:09 +00:00
parent 2852a6db8f
commit 3ad50dab2e
2 changed files with 65 additions and 40 deletions
@@ -41,7 +41,7 @@ uhci_std_ops(int32 op, ...)

 host_controller_info uhci_module = {
 	{
-		"busses/usb/uhci/v1",
+		"busses/usb/uhci",
 		0,
 		uhci_std_ops
 	},
@@ -506,37 +506,15 @@ UHCI::SubmitTransfer(Transfer *transfer)
 	if (transfer->TransferPipe()->Type() & USB_OBJECT_CONTROL_PIPE)
 		return SubmitRequest(transfer);

-	return SubmitTransfer(transfer, false);
-}
-
-
-status_t
-UHCI::SubmitTransfer(Transfer *transfer, bool resubmit)
-{
-	Pipe *pipe = transfer->TransferPipe();
-	bool directionIn = (pipe->Direction() == Pipe::In);
-
 	uhci_td *firstDescriptor = NULL;
-	uhci_td *lastDescriptor = NULL;
-	status_t result = CreateDescriptorChain(pipe, &firstDescriptor,
-		&lastDescriptor, directionIn ? TD_TOKEN_IN : TD_TOKEN_OUT,
-		transfer->VectorLength());
-
+	uhci_qh *transferQueue = NULL;
+	status_t result = CreateFilledTransfer(transfer, &firstDescriptor,
+		&transferQueue);
 	if (result < B_OK)
 		return result;
-	if (!firstDescriptor || !lastDescriptor)
-		return B_NO_MEMORY;
-
-	lastDescriptor->status |= TD_CONTROL_IOC;
-	lastDescriptor->link_phy = TD_TERMINATE;
-	lastDescriptor->link_log = 0;
-
-	if (!directionIn) {
-		WriteDescriptorChain(firstDescriptor, transfer->Vector(),
-			transfer->VectorCount());
-	}

 	Queue *queue = NULL;
+	Pipe *pipe = transfer->TransferPipe();
 	if (pipe->Type() & USB_OBJECT_INTERRUPT_PIPE) {
 		// use interrupt queue
 		queue = fQueues[0];
@@ -545,13 +523,7 @@ UHCI::SubmitTransfer(Transfer *transfer, bool resubmit)
 		queue = fQueues[3];
 	}

-	uhci_qh *transferQueue = CreateTransferQueue(firstDescriptor);
-	if (resubmit) {
-		// the transfer is already pending, we just submit another fragment
-		queue->AppendTransfer(transferQueue);
-		return B_OK;
-	}
-
+	bool directionIn = (pipe->Direction() == Pipe::In);
 	result = AddPendingTransfer(transfer, queue, transferQueue,
 		firstDescriptor, firstDescriptor, directionIn);
 	if (result < B_OK) {
@@ -561,6 +533,7 @@ UHCI::SubmitTransfer(Transfer *transfer, bool resubmit)
 		return result;
 	}

+	queue->AppendTransfer(transferQueue);
 	return B_OK;
 }

@@ -639,6 +612,7 @@ UHCI::SubmitRequest(Transfer *transfer)
 		return result;
 	}

+	queue->AppendTransfer(transferQueue);
 	return B_OK;
 }

@@ -719,8 +693,6 @@ UHCI::AddPendingTransfer(Transfer *transfer, Queue *queue,

 	fLastTransfer = data;
 	Unlock();
-
-	queue->AppendTransfer(data->transfer_queue);
 	return B_OK;
 }

@@ -865,13 +837,26 @@ UHCI::FinishTransfers()
 					}

 					transfer->transfer->TransferPipe()->SetDataToggle(lastDataToggle == 0);
+					FreeDescriptorChain(transfer->first_descriptor);
+					FreeTransferQueue(transfer->transfer_queue);
 					if (transfer->transfer->IsFragmented()) {
 						// this transfer may still have data left
+						TRACE(("usb_uhci: advancing fragmented transfer\n"));
 						transfer->transfer->AdvanceByFragment(actualLength);
 						if (transfer->transfer->VectorLength() > 0) {
+							TRACE(("usb_uhci: still %ld bytes left on transfer\n", transfer->transfer->VectorLength()));
 							// resubmit the advanced transfer so the rest
 							// of the buffers are transmitted over the bus
-							SubmitTransfer(transfer->transfer, true);
+							status_t result = CreateFilledTransfer(transfer->transfer,
+								&transfer->first_descriptor,
+								&transfer->transfer_queue);
+							if (result < B_OK) {
+								transfer->transfer->Finished(result, 0);
+								transferDone = true;
+							};
+
+							transfer->data_descriptor = transfer->first_descriptor;
+							transfer->queue->AppendTransfer(transfer->transfer_queue);
 							break;
 						}

@@ -880,8 +865,6 @@ UHCI::FinishTransfers()
 						actualLength = 0;
 					}

-					FreeDescriptorChain(transfer->first_descriptor);
-					FreeTransferQueue(transfer->transfer_queue);
 					transfer->transfer->Finished(B_OK, actualLength);
 					transferDone = true;
 					break;
@@ -1227,6 +1210,45 @@ UHCI::AddTo(Stack *stack)
 }


+status_t
+UHCI::CreateFilledTransfer(Transfer *transfer, uhci_td **_firstDescriptor,
+	uhci_qh **_transferQueue)
+{
+	Pipe *pipe = transfer->TransferPipe();
+	bool directionIn = (pipe->Direction() == Pipe::In);
+
+	uhci_td *firstDescriptor = NULL;
+	uhci_td *lastDescriptor = NULL;
+	status_t result = CreateDescriptorChain(pipe, &firstDescriptor,
+		&lastDescriptor, directionIn ? TD_TOKEN_IN : TD_TOKEN_OUT,
+		transfer->VectorLength());
+
+	if (result < B_OK)
+		return result;
+	if (!firstDescriptor || !lastDescriptor)
+		return B_NO_MEMORY;
+
+	lastDescriptor->status |= TD_CONTROL_IOC;
+	lastDescriptor->link_phy = TD_TERMINATE;
+	lastDescriptor->link_log = 0;
+
+	if (!directionIn) {
+		WriteDescriptorChain(firstDescriptor, transfer->Vector(),
+			transfer->VectorCount());
+	}
+
+	uhci_qh *transferQueue = CreateTransferQueue(firstDescriptor);
+	if (!transferQueue) {
+		FreeDescriptorChain(firstDescriptor);
+		return B_NO_MEMORY;
+	}
+
+	*_firstDescriptor = firstDescriptor;
+	*_transferQueue = transferQueue;
+	return B_OK;
+}
+
+
 uhci_qh *
 UHCI::CreateTransferQueue(uhci_td *descriptor)
 {
@@ -68,7 +68,6 @@ public:

 		status_t					Start();
 virtual	status_t					SubmitTransfer(Transfer *transfer);
-		status_t					SubmitTransfer(Transfer *transfer, bool resubmit);
 		status_t					SubmitRequest(Transfer *transfer);

 static	status_t					AddTo(Stack *stack);
@@ -99,6 +98,10 @@ static	int32						InterruptHandler(void *data);
 static	int32						FinishThread(void *data);
 		void						FinishTransfers();

+		status_t					CreateFilledTransfer(Transfer *transfer,
+										uhci_td **_firstDescriptor,
+										uhci_qh **_transferQueue);
+
 		// Transfer queue functions
 		uhci_qh						*CreateTransferQueue(uhci_td *descriptor);
 		void						FreeTransferQueue(uhci_qh *queueHead);