i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

vesa & radeon_hd: Remove unneeded and incorrect free().

Browse Source 
In 47404f12f2, a MemoryDeleter was added
to manage this memory instead of doing it manually; most of the free()s
were removed in that commit, but these were somehow missed.
This commit is contained in:
Augustin Cavalier
2021-10-20 13:53:12 -04:00
parent 9b6c4b320f
commit 3c181db6bf
2 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/accelerants/radeon_hd/accelerant.cpp
-1
View File
@@ -113,7 +113,6 @@ init_common(int device, bool isClone)
if (ioctl(device, RADEON_GET_PRIVATE_DATA, &data, if (ioctl(device, RADEON_GET_PRIVATE_DATA, &data,
sizeof(radeon_get_private_data)) != 0) { sizeof(radeon_get_private_data)) != 0) {
free(gInfo);
return B_ERROR; return B_ERROR;
} }
src/add-ons/accelerants/vesa/accelerant.cpp
+1 -4
View File
@@ -53,11 +53,8 @@ init_common(int device, bool isClone)
// get basic info from driver // get basic info from driver
area_id sharedArea; area_id sharedArea;
if (ioctl(device, VESA_GET_PRIVATE_DATA, &sharedArea, sizeof(area_id)) if (ioctl(device, VESA_GET_PRIVATE_DATA, &sharedArea, sizeof(area_id)) != 0)
!= 0) {
free(gInfo);
return B_ERROR; return B_ERROR;
}
AreaDeleter sharedDeleter(clone_area("vesa shared info", AreaDeleter sharedDeleter(clone_area("vesa shared info",
(void **)&gInfo->shared_info, B_ANY_ADDRESS, (void **)&gInfo->shared_info, B_ANY_ADDRESS,