BGradient: preserve order of stops with same offset.

* Use merge sort, which is a stable sort, instead of the qsort used in
BList::SortItems
* This allows setting two stops with the same offset to create a sharp
color change in a gradient. This trick is used to create stripe patterns
with css gradients in some web pages.

Fixes #10733.
This commit is contained in:
Adrien Destugues
2014-05-02 11:46:37 +02:00
parent 590b95e96e
commit 3dfdd43723
+9 -1
View File
@@ -11,6 +11,7 @@
#include <math.h>
#include <stdio.h>
#include <stdlib.h>
#include <Message.h>
@@ -80,6 +81,7 @@ sort_color_stops_by_offset(const void* _left, const void* _right)
return 1;
else if ((*left)->offset < (*right)->offset)
return -1;
return 0;
}
@@ -432,7 +434,13 @@ BGradient::ColorStops() const
void
BGradient::SortColorStopsByOffset()
{
fColorStops.SortItems(sort_color_stops_by_offset);
// Use merge-sort because it's a stable algorithm: stops with the same
// offset will retain their original order. This can be used to have sharp
// color changes in the gradient.
// BList.SortItems uses a qsort, which isn't stable, and sometimes swaps
// such stops.
mergesort(fColorStops.Items(), fColorStops.CountItems(), sizeof(void*),
sort_color_stops_by_offset);
}