kernel: Use "final" more in the VM and x86 paging classes.

Since we always compile the kernel with modern GCC, we might as well
take advantage of modern C++ features. In addition to providing
a sanity check, "final" is also an optimization, since it allows
the compiler to devirtualize calls made directly to a "final" class.

Change-Id: Iedb0ee8834637771f5b6113c17342dbf67e99042
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7826
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>

src/system/kernel/arch/x86/paging/32bit/X86PagingMethod32Bit.cpp

@@ -47,7 +47,7 @@ using X86LargePhysicalPageMapper::PhysicalPageSlot;
 // #pragma mark - X86PagingMethod32Bit::PhysicalPageSlotPool
 
 
-struct X86PagingMethod32Bit::PhysicalPageSlotPool
+struct X86PagingMethod32Bit::PhysicalPageSlotPool final
 	: X86LargePhysicalPageMapper::PhysicalPageSlotPool {
 public:
 	virtual						~PhysicalPageSlotPool();

src/system/kernel/arch/x86/paging/32bit/X86PagingMethod32Bit.h

@@ -15,7 +15,7 @@ class TranslationMapPhysicalPageMapper;
 class X86PhysicalPageMapper;
 
 
-class X86PagingMethod32Bit : public X86PagingMethod {
+class X86PagingMethod32Bit final : public X86PagingMethod {
 public:
 								X86PagingMethod32Bit();
 	virtual						~X86PagingMethod32Bit();

src/system/kernel/arch/x86/paging/32bit/X86PagingStructures32Bit.h

@@ -10,7 +10,7 @@
 #include "paging/X86PagingStructures.h"
 
 
-struct X86PagingStructures32Bit : X86PagingStructures {
+struct X86PagingStructures32Bit final : X86PagingStructures {
 	page_directory_entry*		pgdir_virt;
 
 								X86PagingStructures32Bit();

src/system/kernel/arch/x86/paging/32bit/X86VMTranslationMap32Bit.h

@@ -12,7 +12,7 @@
 struct X86PagingStructures32Bit;
 
 
-struct X86VMTranslationMap32Bit : X86VMTranslationMap {
+struct X86VMTranslationMap32Bit final : X86VMTranslationMap {
 								X86VMTranslationMap32Bit();
 	virtual						~X86VMTranslationMap32Bit();
 

src/system/kernel/arch/x86/paging/X86VMTranslationMap.h

@@ -9,11 +9,6 @@
 #include <vm/VMTranslationMap.h>
 
 
-#if __GNUC__ < 4
-#define final
-#endif
-
-
 #define PAGE_INVALIDATE_CACHE_SIZE 64
 
 

src/system/kernel/arch/x86/paging/pae/X86PagingMethodPAE.cpp

@@ -351,7 +351,7 @@ private:
 // #pragma mark - PhysicalPageSlotPool
 
 
-struct X86PagingMethodPAE::PhysicalPageSlotPool
+struct X86PagingMethodPAE::PhysicalPageSlotPool final
 	: X86LargePhysicalPageMapper::PhysicalPageSlotPool {
 public:
 	virtual						~PhysicalPageSlotPool();

src/system/kernel/arch/x86/paging/pae/X86PagingMethodPAE.h

@@ -23,7 +23,7 @@ class TranslationMapPhysicalPageMapper;
 class X86PhysicalPageMapper;
 
 
-class X86PagingMethodPAE : public X86PagingMethod {
+class X86PagingMethodPAE final : public X86PagingMethod {
 public:
 								X86PagingMethodPAE();
 	virtual						~X86PagingMethodPAE();

src/system/kernel/arch/x86/paging/pae/X86VMTranslationMapPAE.h

@@ -15,7 +15,7 @@
 struct X86PagingStructuresPAE;
 
 
-struct X86VMTranslationMapPAE : X86VMTranslationMap {
+struct X86VMTranslationMapPAE final : X86VMTranslationMap {
 								X86VMTranslationMapPAE();
 	virtual						~X86VMTranslationMapPAE();
 

src/system/kernel/arch/x86/paging/x86_physical_page_mapper_large_memory.cpp

@@ -90,7 +90,7 @@ private:
 // #pragma mark -
 
 
-class LargeMemoryTranslationMapPhysicalPageMapper
+class LargeMemoryTranslationMapPhysicalPageMapper final
 	: public TranslationMapPhysicalPageMapper {
 public:
 								LargeMemoryTranslationMapPhysicalPageMapper();
@@ -115,7 +115,7 @@ private:
 };
 
 
-class LargeMemoryPhysicalPageMapper : public X86PhysicalPageMapper {
+class LargeMemoryPhysicalPageMapper final : public X86PhysicalPageMapper {
 public:
 								LargeMemoryPhysicalPageMapper();
 

src/system/kernel/cache/vnode_store.h

@@ -13,7 +13,7 @@
 struct file_cache_ref;
 
 
-class VMVnodeCache : public VMCache {
+class VMVnodeCache final : public VMCache {
 public:
 			status_t			Init(struct vnode* vnode,
 									uint32 allocationFlags);

src/system/kernel/vm/VMAnonymousCache.h

@@ -31,7 +31,7 @@ extern "C" {
 }
 
 
-class VMAnonymousCache : public VMCache {
+class VMAnonymousCache final : public VMCache {
 public:
 	virtual						~VMAnonymousCache();
 

src/system/kernel/vm/VMAnonymousNoSwapCache.h

@@ -13,7 +13,7 @@
 #include <vm/VMCache.h>
 
 
-class VMAnonymousNoSwapCache : public VMCache {
+class VMAnonymousNoSwapCache final : public VMCache {
 public:
 	virtual						~VMAnonymousNoSwapCache();
 

src/system/kernel/vm/VMDeviceCache.h

@@ -13,7 +13,7 @@
 #include <vm/VMCache.h>
 
 
-class VMDeviceCache : public VMCache {
+class VMDeviceCache final : public VMCache {
 public:
 			status_t			Init(addr_t baseAddress,
 									uint32 allocationFlags);

src/system/kernel/vm/VMKernelAddressSpace.h

@@ -14,7 +14,7 @@
 struct ObjectCache;
 
 
-struct VMKernelAddressSpace : VMAddressSpace {
+struct VMKernelAddressSpace final : VMAddressSpace {
 public:
 								VMKernelAddressSpace(team_id id, addr_t base,
 									size_t size);

src/system/kernel/vm/VMNullCache.h

@@ -13,7 +13,7 @@
 #include <vm/VMCache.h>
 
 
-class VMNullCache : public VMCache {
+class VMNullCache final : public VMCache {
 public:
 			status_t			Init(uint32 allocationFlags);
 

src/system/kernel/vm/VMUserAddressSpace.h

@@ -11,7 +11,7 @@
 #include "VMUserArea.h"
 
 
-struct VMUserAddressSpace : VMAddressSpace {
+struct VMUserAddressSpace final : VMAddressSpace {
 public:
 								VMUserAddressSpace(team_id id, addr_t base,
 									size_t size);