Web+: Copy script console items to clipboard

For easier bug reporting.

* Allow multiple selected items
* Copy the selected items to clipboard with ALT+C
* Remove unnecessary horizontal separator
* Adjust spacing around list and button

Change-Id: Ie8fb104b85e95acec92bd6226779d4de7ee11878
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3769
Reviewed-by: Jérôme Duval <[email protected]>
Reviewed-by: Axel Dörfler <[email protected]>

src/apps/webpositive/ConsoleWindow.cpp

@@ -1,13 +1,15 @@
 /*
- * Copyright 2014 Haiku, Inc. All rights reserved.
+ * Copyright 2014-2021 Haiku, Inc. All rights reserved.
  * Distributed under the terms of the MIT License.
  *
  * Authors:
  *		Zhuowei Zhang
+ *		Humdinger
  */
 #include "ConsoleWindow.h"
 
 #include <Catalog.h>
+#include <Clipboard.h>
 #include <Message.h>
 #include <Button.h>
 #include <GroupLayout.h>
@@ -41,19 +43,19 @@ ConsoleWindow::ConsoleWindow(BRect frame)
 {
 	SetLayout(new BGroupLayout(B_VERTICAL, 0.0));
 
-	fMessagesListView = new BListView("Console messages");
+	fMessagesListView = new BListView("Console messages",
+		B_MULTIPLE_SELECTION_LIST);
 	fClearMessagesButton = new BButton(B_TRANSLATE("Clear"),
 		new BMessage(CLEAR_CONSOLE_MESSAGES));
-	
+
 	AddChild(BGroupLayoutBuilder(B_VERTICAL, 0.0)
-		.Add(new BScrollView("Console messages scroll", 
+		.Add(new BScrollView("Console messages scroll",
 			fMessagesListView, 0, true, true))
-		.Add(new BSeparatorView(B_HORIZONTAL, B_PLAIN_BORDER))
 		.Add(BGroupLayoutBuilder(B_HORIZONTAL, B_USE_SMALL_SPACING)
 			.Add(fClearMessagesButton)
-			.SetInsets(0, 5, 0, 5)
-		)
-		.SetInsets(5, 5, 5, 5)
+			.SetInsets(0, B_USE_SMALL_SPACING, 0, 0))
+		.SetInsets(B_USE_SMALL_SPACING, B_USE_SMALL_SPACING,
+			B_USE_SMALL_SPACING, B_USE_SMALL_SPACING)
 	);
 	if (!frame.IsValid())
 		CenterOnScreen();
@@ -84,6 +86,11 @@ ConsoleWindow::MessageReceived(BMessage* message)
 			}
 			break;
 		}
+		case B_COPY:
+		{
+			_CopyToClipboard();
+			break;
+		}
 		default:
 			BWindow::MessageReceived(message);
 			break;
@@ -98,3 +105,30 @@ ConsoleWindow::QuitRequested()
 		Hide();
 	return false;
 }
+
+
+void
+ConsoleWindow::_CopyToClipboard()
+{
+	if (fMessagesListView->CurrentSelection() == -1)
+		return;
+
+	BString text;
+	int32 index;
+	for (int32 i = 0; (index = fMessagesListView->CurrentSelection(i)) >= 0;
+			i++) {
+		BStringItem* item = (BStringItem*)fMessagesListView->ItemAt(index);
+		text << item->Text();
+	}
+
+	ssize_t textLen = text.Length();
+	if (be_clipboard->Lock()) {
+		be_clipboard->Clear();
+		BMessage* clip = be_clipboard->Data();
+		if (clip != NULL) {
+			clip->AddData("text/plain", B_MIME_TYPE, text.String(), textLen);
+			be_clipboard->Commit();
+		}
+		be_clipboard->Unlock();
+	}
+}

src/apps/webpositive/ConsoleWindow.h

@@ -1,9 +1,10 @@
 /*
- * Copyright 2014 Haiku, Inc. All rights reserved.
+ * Copyright 2014-2021 Haiku, Inc. All rights reserved.
  * Distributed under the terms of the MIT License.
  *
  * Authors:
  *		Zhuowei Zhang
+ *		Humdinger
  */
 #ifndef CONSOLE_WINDOW_H
 #define CONSOLE_WINDOW_H
@@ -22,6 +23,10 @@ public:
 								ConsoleWindow(BRect frame);
 	virtual	void				MessageReceived(BMessage* message);
 	virtual	bool				QuitRequested();
+
+private:
+			void				_CopyToClipboard();
+
 private:
 			BListView*			fMessagesListView;
 			BButton* 			fClearMessagesButton;