i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "debuganalyzer: Fix double free. CID 992566"

Browse Source 
This reverts commit ea27e95f48.

* AnEvilYak pointed out that this was a false positive as
  BObjectList can optionally delete on remove.
* I'll add a penny to the bitcoin bad commit jar :)
This commit is contained in:
Alexander von Gluck IV
2013-06-24 16:29:04 -05:00
parent ea27e95f48
commit 4dff02682c
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/apps/debuganalyzer/gui/table/Table.cpp
+3 -1
View File
@@ -640,8 +640,10 @@ Table::TableRowsRemoved(TableModel* model, int32 rowIndex, int32 count)
} }
for (int32 i = rowIndex + count - 1; i >= rowIndex; i--) { for (int32 i = rowIndex + count - 1; i >= rowIndex; i--) {
if (BRow* row = fRows.RemoveItemAt(i)) if (BRow* row = fRows.RemoveItemAt(i)) {
RemoveRow(row); RemoveRow(row);
delete row;
}
} }
// re-index the subsequent rows // re-index the subsequent rows