i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

TCP: Check state in Persist and DelayedAcknowledge timeouts.

Browse Source 
As the comment already notes, it's possible that we wind up
in the timeout routine despite the timer being cancelled, if
the cancellation was done after execution was in progress.

In either case, do not invoke Send if there is nothing to do,
as invoking Send...(force = true) will generate a duplicate ACK.
Duplicate ACKs will be noticed by the remote end as a sign of
congestion, so we don't want that to happen.

Change-Id: Iac30c140c322ccf0b0477e434459e7674bc24e1a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7283
Reviewed-by: waddlesplash <[email protected]>
Reviewed-by: Alex von Gluck IV <[email protected]>
This commit is contained in:
Augustin Cavalier
2023-12-31 03:36:27 +00:00
committed by waddlesplash
parent 265e1e4d6a
commit 5e7d399ef4
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/kernel/network/protocols/tcp/TCPEndpoint.cpp
+4
View File
@@ -2492,6 +2492,8 @@ TCPEndpoint::_PersistTimer(net_timer* timer, void* _endpoint)
// the timer might not have been canceled early enough
if (endpoint->State() == CLOSED)
return;
if (endpoint->fSendQueue.Available(endpoint->fSendNext) == 0)
return;
endpoint->_SendQueued(true);
}
@@ -2510,6 +2512,8 @@ TCPEndpoint::_DelayedAcknowledgeTimer(net_timer* timer, void* _endpoint)
// the timer might not have been canceled early enough
if (endpoint->State() == CLOSED)
return;
if (endpoint->fLastAcknowledgeSent == endpoint->fReceiveNext)
return;
endpoint->SendAcknowledge(true);
}