i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix usage of wrong port change values. The request numbers were compared with

Browse Source 
the bitmap instead of the masks. Spotted by Mika Lindqvist (after 100 reboots),
thanks for tracking down such hard to spot errors!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29029 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Michael Lotz
2009-01-26 00:57:02 +00:00
parent 73161598d7
commit 621e8eeb9e
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/kernel/bus_managers/usb/Hub.cpp
+3 -3
View File
@@ -153,13 +153,13 @@ Hub::ResetPort(uint8 index)
if (result < B_OK)
return result;
if (fPortStatus[index].change & C_PORT_RESET) {
if (fPortStatus[index].change & PORT_STATUS_RESET) {
// reset is done
break;
}
}
if ((fPortStatus[index].change & C_PORT_RESET) == 0) {
if ((fPortStatus[index].change & PORT_STATUS_RESET) == 0) {
TRACE_ERROR("port %d won't reset\n", index);
return B_ERROR;
}
@@ -302,7 +302,7 @@ Hub::Explore(change_item **changeList)
0, NULL, 0, NULL);
}
if (fPortStatus[i].change & PORT_RESET) {
if (fPortStatus[i].change & PORT_STATUS_RESET) {
TRACE_ALWAYS("port %ld was reset\n", i);
DefaultPipe()->SendRequest(USB_REQTYPE_CLASS | USB_REQTYPE_OTHER_OUT,
USB_REQUEST_CLEAR_FEATURE, C_PORT_RESET, i + 1,