i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed get_mount(). It must also acquire the vnode lock before trying to

Browse Source 
increment the root node vnode reference count. Otherwise it could race
with fs_unmount(). Fixes bug #1438.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@22203 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Ingo Weinhold
2007-09-08 17:03:19 +00:00
parent 43ab7500cc
commit 62454aae66
1 changed files with 10 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/system/kernel/fs/vfs.cpp
+10 -17
View File
@@ -474,27 +474,20 @@ get_mount(dev_t id, struct fs_mount **_mount)
struct fs_mount *mount;
status_t status;
mutex_lock(&sMountMutex);
MutexLocker nodeLocker(sVnodeMutex);
MutexLocker mountLocker(sMountMutex);
mount = find_mount(id);
if (mount) {
// ToDo: the volume is locked (against removal) by locking
// its root node - investigate if that's a good idea
if (mount->root_vnode)
inc_vnode_ref_count(mount->root_vnode);
else {
// might have been called during a mount operation in which
// case the root node may still be NULL
mount = NULL;
}
} else
status = B_BAD_VALUE;
mutex_unlock(&sMountMutex);
if (mount == NULL)
return B_BUSY;
return B_BAD_VALUE;
struct vnode* rootNode = mount->root_vnode;
if (rootNode == NULL || rootNode->busy || rootNode->ref_count == 0) {
// might have been called during a mount/unmount operation
return B_BUSY;
}
inc_vnode_ref_count(mount->root_vnode);
*_mount = mount;
return B_OK;
}