i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BStringList::Add(): fix ref counting problem

Browse Source 
Handle the case that the private data of the given string is not
shareable.
This commit is contained in:
Ingo Weinhold
2013-06-27 21:57:40 +02:00
parent 5fa3519dec
commit 62b0b64124
1 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/kits/support/StringList.cpp
+13 -3
View File
@@ -1,5 +1,5 @@
/*
* Copyright 2011, Ingo Weinhold, [email protected]
* Copyright 2011-2013, Ingo Weinhold, [email protected]
* Copyright 2011, Clemens Zeidler <[email protected]>
*
* Distributed under the terms of the MIT License.
@@ -55,8 +55,13 @@ BStringList::~BStringList()
bool
BStringList::Add(const BString& string, int32 index)
BStringList::Add(const BString& _string, int32 index)
{
BString string(_string);
// makes sure the string is shareable
if (string.Length() != _string.Length())
return false;
char* privateData = BString::Private(string).Data();
if (!fStrings.AddItem(privateData, index))
return false;
@@ -67,8 +72,13 @@ BStringList::Add(const BString& string, int32 index)
bool
BStringList::Add(const BString& string)
BStringList::Add(const BString& _string)
{
BString string(_string);
// makes sure the string is shareable
if (string.Length() != _string.Length())
return false;
char* privateData = BString::Private(string).Data();
if (!fStrings.AddItem(privateData))
return false;