i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

kernel/system_profiler: Do not allow non-root users access.

Browse Source 
The single-team profiler can still be used without root access.
Part of #14961.
This commit is contained in:
Augustin Cavalier
2019-07-04 16:41:36 -04:00
parent ebb0db62d1
commit 6f6cba7c16
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/system/kernel/debug/system_profiler.cpp
+12
View File
@@ -1543,6 +1543,9 @@ stop_system_profiler()
status_t
_user_system_profiler_start(struct system_profiler_parameters* userParameters)
{
if (geteuid() != 0)
return B_PERMISSION_DENIED;
// copy params to the kernel
struct system_profiler_parameters parameters;
if (userParameters == NULL || !IS_USER_ADDRESS(userParameters)
@@ -1606,6 +1609,9 @@ _user_system_profiler_start(struct system_profiler_parameters* userParameters)
status_t
_user_system_profiler_next_buffer(size_t bytesRead, uint64* _droppedEvents)
{
if (geteuid() != 0)
return B_PERMISSION_DENIED;
if (_droppedEvents != NULL && !IS_USER_ADDRESS(_droppedEvents))
return B_BAD_ADDRESS;
@@ -1633,6 +1639,9 @@ _user_system_profiler_next_buffer(size_t bytesRead, uint64* _droppedEvents)
status_t
_user_system_profiler_stop()
{
if (geteuid() != 0)
return B_PERMISSION_DENIED;
team_id team = thread_get_current_thread()->team->id;
InterruptsSpinLocker locker(sProfilerLock);
@@ -1652,6 +1661,9 @@ _user_system_profiler_stop()
status_t
_user_system_profiler_recorded(system_profiler_parameters* userParameters)
{
if (geteuid() != 0)
return B_PERMISSION_DENIED;
if (userParameters == NULL || !IS_USER_ADDRESS(userParameters))
return B_BAD_ADDRESS;
if (sRecordedParameters == NULL)