i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media-add-ons/mixer: Fix 'new[]' array freed with 'delete'

Browse Source 
fMixBufferChannelTypes is allocated by new[] in _ApplyOutputFormat(),
but freed by delete.
Pointed out by LGTM.

Change-Id: I07b85801e0103094c5751306ea2c50ca9354ddb9
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1877
Reviewed-by: Axel Dörfler <[email protected]>
This commit is contained in:
Murai Takashi
2019-09-21 16:01:37 +00:00
committed by Axel Dörfler
parent 7fd9865ec6
commit 7abf1b6fba
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/media/media-add-ons/mixer/MixerCore.cpp
+2 -2
View File
@@ -112,7 +112,7 @@ MixerCore::~MixerCore()
delete[] fResampler; delete[] fResampler;
} }
delete fMixBufferChannelTypes; delete[] fMixBufferChannelTypes;
} }
@@ -429,7 +429,7 @@ MixerCore::_ApplyOutputFormat()
if (fMixBuffer != NULL) if (fMixBuffer != NULL)
rtm_free(fMixBuffer); rtm_free(fMixBuffer);
delete fMixBufferChannelTypes; delete[] fMixBufferChannelTypes;
fMixBufferFrameRate = (int32)(0.5 + format.frame_rate); fMixBufferFrameRate = (int32)(0.5 + format.frame_rate);
fMixBufferFrameCount = frames_per_buffer(format); fMixBufferFrameCount = frames_per_buffer(format);