i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MessageBuilder: Fix leaking BMessages.

Browse Source 
The initial message is not deleted, since the current message is not
on the stack.
This commit is contained in:
Stephan Aßmus
2014-08-24 18:10:24 +02:00
parent 2f23e09d9d
commit 8f16f634d7
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/kits/shared/MessageBuilder.cpp
+2
View File
@@ -69,6 +69,8 @@ BMessageBuilder::PopObject()
BMessage* previousMessage = fStack.LastItem(); BMessage* previousMessage = fStack.LastItem();
previousMessage->AddMessage(fNameStack.LastItem()->String(), previousMessage->AddMessage(fNameStack.LastItem()->String(),
fCurrentMessage); fCurrentMessage);
delete fCurrentMessage;
fCurrentMessage = previousMessage; fCurrentMessage = previousMessage;
fStack.RemoveItemAt(fStack.CountItems() - 1); fStack.RemoveItemAt(fStack.CountItems() - 1);