i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

radeon_hd: fix typecast in atombios table header parser

Browse Source 
* The pointer mdt should point to the start of the contents of the
  master data table. As defined in struct ATOM_MASTER_DATA_TABLE,
  the content begins 4 bytes after the beginning of the table
  (which in turn is ctx->data_table bytes from the start of the
  AtomBIOS). The wrong parantheses in the cast moved the pointer
  somewhere else completely.

* That this apparently worked on many cards is because the mdt
  pointer in this function is used just to make sure that the
  following dereference is not a NULL-pointer access.
  The actual dereference is then done using the CU16() and CU8()
  macros which do the casts correctly. However, it only worked when
  the wrong pointer plus index lead to some byte which was, by
  chance, not zero. For many chips, this was the case.

* For the AtomBIOS of a Radeon HD7850M (Heathrow Pro) it didn't work
  out though and the driver couldn't parse tables. With this fix, it
  now works on such chips as well.

* Also, fix the same problem in code for master command table.
This commit is contained in:
Julian Harnath
2014-11-09 23:59:24 +01:00
parent 6ab4ff112a
commit 97fb429c55
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/accelerants/radeon_hd/atombios/atom.cpp
+2 -2
View File
@@ -1348,7 +1348,7 @@ atom_parse_data_header(atom_context *ctx, int index, uint16 *size,
{
int offset = index * 2 + 4;
int idx = CU16(ctx->data_table + offset);
uint16 *mdt = (uint16 *)ctx->bios + ctx->data_table + 4;
uint16 *mdt = (uint16*)(ctx->bios + ctx->data_table + 4);
if (!mdt[index])
return B_ERROR;
@@ -1370,7 +1370,7 @@ atom_parse_cmd_header(atom_context *ctx, int index, uint8 * frev,
{
int offset = index * 2 + 4;
int idx = CU16(ctx->cmd_table + offset);
uint16 *mct = (uint16 *)ctx->bios + ctx->cmd_table + 4;
uint16 *mct = (uint16*)(ctx->bios + ctx->cmd_table + 4);
if (!mct[index])
return B_ERROR;