i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SCSI: Use ConditionVariable::NotifyOne, not NotifyAll.

Browse Source 
This matches the previous behavior (which just used release_sem
or _etc with a count of 1.) The one waiter might delete the object
containing the condition variable on wakeup, so the difference
does matter.
This commit is contained in:
Augustin Cavalier
2025-03-03 15:12:31 -05:00
parent 73e7455250
commit a0c4b9a162
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/kernel/bus_managers/scsi/scsi_io.cpp
+4 -4
View File
@@ -194,7 +194,7 @@ finish_autosense(scsi_device_info *device)
}
// inform peripheral driver
orig_request->completion_cond.NotifyAll();
orig_request->completion_cond.NotifyOne();
}
@@ -325,7 +325,7 @@ scsi_request_finished(scsi_ccb *request, uint num_requests)
else {
// tell peripheral driver about completion
if (!do_autosense)
request->completion_cond.NotifyAll();
request->completion_cond.NotifyOne();
}
}
@@ -483,7 +483,7 @@ err2:
if (request->buffered)
scsi_release_dma_buffer(request);
err:
request->completion_cond.NotifyAll(B_ERROR);
request->completion_cond.NotifyOne(B_ERROR);
return;
}
@@ -571,7 +571,7 @@ scsi_abort(scsi_ccb *req_to_abort)
scsi_release_dma_buffer(req_to_abort);
// tell peripheral driver about
req_to_abort->completion_cond.NotifyAll(B_CANCELED);
req_to_abort->completion_cond.NotifyOne(B_CANCELED);
if (start_retry)
release_sem(bus->start_service);