i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed a possible buffer overflow (thanks Axel). Removed a todo item

Browse Source 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@13236 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Stefano Ceccherini
2005-06-23 13:22:58 +00:00
parent 755e899559
commit ba69a3795b
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/kits/interface/MenuItem.cpp
+1 -3
View File
@@ -366,9 +366,7 @@ BMenuItem::DrawContent()
if (fBounds.Width() > labelWidth) if (fBounds.Width() > labelWidth)
fSuper->DrawString(fLabel); fSuper->DrawString(fLabel);
else { else {
// TODO: Ouch! Allocating the string every time char *truncatedLabel = new char[strlen(fLabel) + 4];
// isn't exactly cheap.
char *truncatedLabel = new char[strlen(fLabel) + 1];
TruncateLabel(fBounds.Width(), truncatedLabel); TruncateLabel(fBounds.Width(), truncatedLabel);
fSuper->DrawString(truncatedLabel); fSuper->DrawString(truncatedLabel);
delete[] truncatedLabel; delete[] truncatedLabel;