i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

StringForSize: Preinitialize the BNumberFormats.

Browse Source 
I noticed when profiling the system with ActivityMonitor running
that most of ActivityMonitor's time was spent initializing these
for the Memory view. So, instead, cache the formatters to avoid
needing to reinitialize them so often.
This commit is contained in:
Augustin Cavalier
2026-04-09 14:26:24 -04:00
parent 816181bc95
commit da1768c354
1 changed files with 21 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/kits/shared/StringForSize.cpp
+21 -3
View File
@@ -21,10 +21,25 @@ using BPrivate::gSystemCatalog;
#undef B_TRANSLATION_CONTEXT
#define B_TRANSLATION_CONTEXT "StringForSize"
static BNumberFormat* sNumberFormat0;
static BNumberFormat* sNumberFormat2;
static pthread_once_t sNumberFormatInit = PTHREAD_ONCE_INIT;
namespace BPrivate {
static void
InitializeNumberFormats()
{
sNumberFormat0 = new BNumberFormat;
sNumberFormat0->SetPrecision(0);
sNumberFormat2 = new BNumberFormat;
sNumberFormat2->SetPrecision(2);
}
const char*
string_for_size(double size, char* string, size_t stringSize)
{
@@ -47,10 +62,13 @@ string_for_size(double size, char* string, size_t stringSize)
gSystemCatalog.GetString(kFormats[index], B_TRANSLATION_CONTEXT, "size unit"));
formatter.Format(format, size);
// Initializing and changing the parameters of BNumberFormats is expensive,
// so we cache the two we need globally.
pthread_once(&sNumberFormatInit, InitializeNumberFormats);
BString printedSize;
BNumberFormat numberFormat;
numberFormat.SetPrecision(index == 0 ? 0 : 2);
numberFormat.Format(printedSize, size);
BNumberFormat* numberFormat = (index == 0) ? sNumberFormat0 : sNumberFormat2;
numberFormat->Format(printedSize, size);
snprintf(string, stringSize, format.String(), printedSize.String());