Terminal: Fix -Werror=class-memaccess

Fix -Werror=class-memaccess pointed out by gcc8.
* Use TerminalLine::Clear() instead of memset()
* Use rgb_color::operator=() instead of memcpy()

Change-Id: I41360e245fd55c526d9c2802a2f247ba22583080
Reviewed-on: https://review.haiku-os.org/483
Reviewed-by: Adrien Destugues <[email protected]>

src/apps/terminal/BasicTerminalBuffer.cpp

@@ -1088,7 +1088,7 @@ BasicTerminalBuffer::_AllocateLines(int32 width, int32 count)
 			_FreeLines(lines, i);
 			return NULL;
 		}
-		memset(lines[i], 0, size);
+		lines[i]->Clear(0, width);
 	}
 
 	return lines;

src/apps/terminal/Colors.cpp

@@ -195,7 +195,7 @@ XColorsTable::LookUpColor(const char* name, rgb_color* color)
 	}
 
 	if (fTable[right].hash == hash) {
-		memcpy(color, &fTable[right].color, sizeof(rgb_color));
+		*color = fTable[right].color;
 		return B_OK;
 	}
 

src/apps/terminal/TerminalBuffer.cpp

@@ -61,8 +61,8 @@ TerminalBuffer::Init(int32 width, int32 height, int32 historySize)
 	if (fColorsPalette == NULL)
 		return B_NO_MEMORY;
 
-	memcpy(fColorsPalette, TermApp::DefaultPalette(),
-			sizeof(rgb_color) * kTermColorCount);
+	for (uint i = 0; i < kTermColorCount; i++)
+		fColorsPalette[i] = TermApp::DefaultPalette()[i];
 
 	return BasicTerminalBuffer::Init(width, height, historySize);
 }