add-ons/media/plugins/ffmpeg: Fix PVS 2355

Fix memory leak when realloc() fails. Change-Id: I12b57fecbd7f9645f15afb9d0f9a6db937a5ec09 Reviewed-on: https://review.haiku-os.org/c/1014 Reviewed-by: Barrett17 <[email protected]>
2019-02-07 11:22:11 +00:00
parent f33f4868fe
commit f9c74ffa6f
1 changed files with 6 additions and 2 deletions
@@ -1456,11 +1456,15 @@ status_t
 AVCodecDecoder::_CopyChunkToChunkBufferAndAddPadding(const void* chunk,
 	size_t chunkSize)
 {
-	fChunkBuffer = static_cast<uint8_t*>(realloc(fChunkBuffer,
+	uint8_t* tmpBuffer = static_cast<uint8_t*>(realloc(fChunkBuffer,
 		chunkSize + AV_INPUT_BUFFER_PADDING_SIZE));
-	if (fChunkBuffer == NULL) {
+	if (tmpBuffer == NULL) {
+		free(fChunkBuffer);
+		fChunkBuffer = NULL;
 		fChunkBufferSize = 0;
 		return B_NO_MEMORY;
+	} else {
+		fChunkBuffer = tmpBuffer;
 	}

 	memcpy(fChunkBuffer, chunk, chunkSize);