i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

add-ons/media/plugins/ffmpeg: Fix PVS 2355

Browse Source 
Fix memory leak when realloc() fails.

Change-Id: I12b57fecbd7f9645f15afb9d0f9a6db937a5ec09
Reviewed-on: https://review.haiku-os.org/c/1014
Reviewed-by: Barrett17 <[email protected]>
This commit is contained in:
Murai Takashi
2019-02-07 11:22:11 +00:00
committed by Barrett17
parent f33f4868fe
commit f9c74ffa6f
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/media/plugins/ffmpeg/AVCodecDecoder.cpp
+6 -2
View File
@@ -1456,11 +1456,15 @@ status_t
AVCodecDecoder::_CopyChunkToChunkBufferAndAddPadding(const void* chunk, AVCodecDecoder::_CopyChunkToChunkBufferAndAddPadding(const void* chunk,
size_t chunkSize) size_t chunkSize)
{ {
fChunkBuffer = static_cast<uint8_t*>(realloc(fChunkBuffer, uint8_t* tmpBuffer = static_cast<uint8_t*>(realloc(fChunkBuffer,
chunkSize + AV_INPUT_BUFFER_PADDING_SIZE)); chunkSize + AV_INPUT_BUFFER_PADDING_SIZE));
if (fChunkBuffer == NULL) { if (tmpBuffer == NULL) {
free(fChunkBuffer);
fChunkBuffer = NULL;
fChunkBufferSize = 0; fChunkBufferSize = 0;
return B_NO_MEMORY; return B_NO_MEMORY;
} else {
fChunkBuffer = tmpBuffer;
} }
memcpy(fChunkBuffer, chunk, chunkSize); memcpy(fChunkBuffer, chunk, chunkSize);