i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BMenu: fix memory leak in scripting

Browse Source 
Change-Id: Ia283594a622f758189cc8280683a4e068ae1f3af
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2978
Reviewed-by: waddlesplash <[email protected]>
This commit is contained in:
X512
2020-07-02 19:26:49 +00:00
committed by waddlesplash
parent b4e10d71e6
commit fb44a1cd72
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/kits/interface/Menu.cpp
+6 -2
View File
@@ -1670,8 +1670,10 @@ void BMenu::_ScriptReceived(BMessage* message)
if (err >= B_OK) { if (err >= B_OK) {
if (item->Submenu() == NULL) if (item->Submenu() == NULL)
err = B_BAD_VALUE; err = B_BAD_VALUE;
else else {
RemoveItem(item); RemoveItem(item);
delete item;
}
} }
} }
break; break;
@@ -1737,8 +1739,10 @@ void BMenu::_ScriptReceived(BMessage* message)
if (message->what == B_DELETE_PROPERTY) { if (message->what == B_DELETE_PROPERTY) {
BMenuItem *item = NULL; BMenuItem *item = NULL;
err = _ResolveItemSpecifier(specifier, what, item); err = _ResolveItemSpecifier(specifier, what, item);
if (err >= B_OK) if (err >= B_OK) {
RemoveItem(item); RemoveItem(item);
delete item;
}
} }
break; break;
case 12: { // MenuItem: EXECUTE case 12: { // MenuItem: EXECUTE