i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

BLooper: removed superfluous locking and code in PostMessage().

Browse Source 
* The code duplicated the code found in the BMessenger constructor that
  it called a few lines below. This should improve PostMessage()
  performance a tiny bit.
This commit is contained in:
Axel Dörfler
2013-10-27 00:16:02 +02:00
parent 7f94398c21
commit fd5c87d53c
1 changed files with 3 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/kits/app/Looper.cpp
+3 -15
View File
@@ -1,5 +1,5 @@
/*
* Copyright 2001-2011, Haiku.
* Copyright 2001-2013, Haiku.
* Distributed under the terms of the MIT License.
*
* Authors:
@@ -817,24 +817,12 @@ BLooper::BLooper(int32 priority, port_id port, const char* name)
status_t
BLooper::_PostMessage(BMessage *msg, BHandler *handler, BHandler *replyTo)
BLooper::_PostMessage(BMessage* msg, BHandler* handler, BHandler* replyTo)
{
AutoLocker<BLooperList> listLocker(gLooperList);
if (!listLocker.IsLocked())
return B_ERROR;
if (!gLooperList.IsLooperValid(this))
return B_BAD_VALUE;
// Does handler belong to this looper?
if (handler && handler->Looper() != this)
return B_MISMATCHED_VALUES;
status_t status;
BMessenger messenger(handler, this, &status);
listLocker.Unlock();
if (status == B_OK)
status = messenger.SendMessage(msg, replyTo, 0);
return messenger.SendMessage(msg, replyTo, 0);
return status;
}