Commit Graph
17 Commits
Author SHA1 Message Date
Oscar Lesta 3af8011358 env vars: move XDG Base Dirs variable exports to SetupEnvironment
This makes sure that apps get access to these variables regardless if
they are started from a shell or from GUI (double-click from Tracker,
desklink, etc).

Fixes #18130.

Change-Id: I82e2884e460fad7d6ec16e7b624c5cd2fcf807df
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5897
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
2022-12-13 01:49:55 +00:00
Oscar Lesta 62b6a4c615 mount_server: BPartition::ContentName() returns a BString now.
Change-Id: I9a236f6a28826d9394265081c3ebf6e96290fa54
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5770
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
2022-11-01 01:05:35 +00:00
Oscar Lesta dfd7e48a6c Partitioner: fixed warnings, and usage of BPartition::ContentName()
Not particularly high priority (this being a test) but... I came across
these while searching for code still needing updates after the changes
on BPartition::ContentName().

Change-Id: I05e8d6c02ba34688cee4f0b55e4e782243b0af4d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5769
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
2022-11-01 01:05:35 +00:00
Oscar Lesta 62ea448683 TextSearch: do not trigger new grep searches unnecessarily.
Opening and closing a file from the results window with Pe, for
example, was triggering unnecessary new grep searches, when only
the attributes or other metadata on the file got changed (and
not its content).

That new search was also changing the focus from the results view
to the search field (making one lose the position on that list,
specially annoying with large number of results).

Avoid that by not monitoring/reacting to B_ATTR_CHANGED, and not
reacting to B_STAT_CHANGED if the only flag is B_STAT_CHANGE_TIME.

Change-Id: I56d34c93da94acf36890abe458da45d26a334593
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5763
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
2022-10-28 16:35:19 +00:00
Oscar Lesta b2a47f1f5a AboutSystem: update hrev from the replicant constructor.
Extracted a _GetOSVersion() function, and used that to get the value
for version text, and to update it at replicant instantiation time.

Should fix #17957.

Change-Id: Ifc964c3646743a503fd756c902d102977e35e73d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5724
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: John Scipione <[email protected]>
Reviewed-by: Jérôme Duval <[email protected]>
2022-10-11 15:39:48 +00:00
Oscar Lesta 7c7357f07c AboutSystem: make static constants out of some member variables.
This avoids using them while uninitialized (as could happen when
using the archive constructor.

Fixes #17955.

Change-Id: If75354216b9731b3273d79aec787cd0140a6175e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5723
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Jérôme Duval <[email protected]>
2022-10-11 15:36:47 +00:00
Oscar Lesta 6eff9ae623 Sounds preflet: don't reuse variable names.
This fixes "issue 2" from #17150, that only manifested on x86-64.

Also: moved the "menu" variable declaration closer to its usege.

Change-Id: If44f84a8d5ee2bd662c312aec26359c857db5a93
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5720
Reviewed-by: Adrien Destugues <[email protected]>
Tested-by: Commit checker robot <[email protected]>
2022-10-06 18:16:49 +00:00
Oscar Lesta 0449ac1e6a BootManager: fix usage of BPartition::ContentName()
This one got changed in hrev56463. Fixes #17969.

Credit for the proper fix: Jérôme Duval.

Change-Id: Ia7ab07573538031f4794efce9e0feba37b7b9bda
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5714
Reviewed-by: Jérôme Duval <[email protected]>
2022-10-05 16:27:30 +00:00
Oscar Lesta eb198a09e9 checkstyle.py: Python 3 compatibility, part two.
Previous patch was tested only with single files arguments, thus
missing the usage of "os.path.walk()" (that was removed on 3.0).

Use "os.walk()" instead, that has been available since Python 2.3.

Change-Id: Ia290bebaa950466ac5f1d978f0a5e710a8e3da88
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5696
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
2022-10-02 09:33:59 +00:00
Oscar Lesta c907db6c62 Tracker: fix build with DEBUG=1
Change-Id: Ieaaf23b0780f50837153634ad3e82eda6e5978f8
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5700
Reviewed-by: waddlesplash <[email protected]>
2022-09-27 19:12:54 +00:00
Oscar Lesta 5d7ed80a63 /bin/pidof: add it to regular images and to the Haiku package.
Change-Id: I07cbc6b715ee5d549ec4fcaf9b28398ee6ffb3dc
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5697
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Jérôme Duval <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
2022-09-26 14:50:02 +00:00
Oscar Lesta dee0cb7098 checkstyle.py: make it compatible with Python 3.x
* Change prints to be compatible with 2.x and 3.x.
* Use html.escape instead of cgi.escape on Python >= 3.8.
* Make integer division explicit.

Change-Id: Ib9b236816e8fa07741c02d0e79629c4aa0ed6676
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5603
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
2022-09-10 11:25:07 +00:00
Oscar Lesta 8fc394c12d pkgman: change default search scope
* Reduce default search scope to: "name", "summary", and "provides".
* Add a new "--search-scope=<scope>" option that allows to either limit
  the search to packages names (-s name), or to replicate the previous
  behavior of searching everywhere in the package info (-s full).

Motivation for the change:

The ever increasing number of packages available for Haiku was impacting
pkgman search usefulness, as it easily returns too many packages (what a
wonderful problem to have :-D).

Limiting the default search scope helps with that, and the old behavior
is kept "just an option away".

Change-Id: I5b456b90137237134eee7ca7ee501bf8e3767440
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5616
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Jérôme Duval <[email protected]>
2022-09-06 20:31:38 +00:00
Oscar Lesta e4d44d82aa Sounds preflet: small UX improvements.
* Disable BMenuField unless a sound event is selected.
* Changes in the MenuItem enable/disable the play button as necessary.
  (previously only changes in the EventList did that).
* Enable the play button when BFilePanel is closed (after selecting valid file).

Fixes the (still reproducible) UI/UX portion of #17150.

Change-Id: I5b5d00cc7fce00a0d0f908bbaff883169f38f855
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5613
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Jérôme Duval <[email protected]>
2022-09-06 17:48:26 +00:00
Oscar Lesta 83a4315c94 /bin/pidof: add a basic "pidof" command.
Change-Id: Ia70d3280d46cf9f5770f8c83a5941ea5b1b8dfe7
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5599
Reviewed-by: Jérôme Duval <[email protected]>
Tested-by: Commit checker robot <[email protected]>
2022-09-06 05:57:07 +00:00
Oscar Lesta 2226d2eef7 tty: Fix TCFLSH and TCSBRK ioctls.
These two recieve integer values from userland (termios).
Cast them accordingly.

Should fix #17861. Tested on 32 and 64 bits.

Change-Id: Ic5eb53d2732354f86a82f59aab4917ad1851cfc5
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5545
Reviewed-by: waddlesplash <[email protected]>
Reviewed-by: Jérôme Duval <[email protected]>
Tested-by: Commit checker robot <[email protected]>
2022-08-13 10:55:48 +00:00
Oscar Lesta c4af8d0676 pc_serial: fix divisor values for baudrates 1200 and 1800
Change-Id: I57981b4c6f1b1ed22bea98d1199e86919f5ff30d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5544
Reviewed-by: Jérôme Duval <[email protected]>
2022-08-12 11:35:28 +00:00