It comes with AVX, so enable it if we've enabled AVX.
This also adjusts altcodepatch_replace to explicitly set NOPs
for the remainder of the patch area.
Change-Id: Ia07549851d86836ff5428635b580c751b4e5b2a3
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10867
Reviewed-by: waddlesplash <[email protected]>
Reviewed-by: Jérôme Duval <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Fixes#20018, #20050.
The sort was causing the scroll position on change directory
(go up/back) in navigation (single-window/browser) mode and
causing issues with pose list when type-ahead filtering.
Change-Id: Id07890462ac3ecd36f3db508671c77c943ee3e2c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10860
Reviewed-by: waddlesplash <[email protected]>
[+] Implemented proper initialization and detection for eMMC card at mmc_bus.cpp
[+] Extended SD_COMMANDS enum at mmc.h to support eMMC CMD3. some common commands
are highlighted removing its specific card type prefix.
[+] Reading eMMC Device CID register attributes for initiating mmc disk node.
[+] added formal register content wrapper classes.
[+] Printing some attrs for debugging and verification.
[+] MMCBus and SDHCIBus are aware of the underlying card type, no problem unless more than one device
on same mmc bus.
i followed the specs on CID stipping, still asking for your validation.
Built and tested with success for QEMU emulated sdHC eMMC device, also tested with emulated
SD card to verify nothing backfires.
my reference is JESD84-B51 document.
*log file looks has this:
mmc_bus: Trying MMC CMD1 initialization...
...
mmc_bus: Detected MMC card after CMD1
...
...
mmc_bus: MMC RCA: 1 Status: 500
mmc_bus: MMC CID: MID=0, name="XQEMU!", PSN=31370686, PRV=201, MDT=14/2028
Change-Id: Ia6e93b154548ff7cf2dfae3bcffe85e6b2aa01fb
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10641
Reviewed-by: Adrien Destugues <[email protected]>
Tested-by: Commit checker robot <[email protected]>
This change will stop the main window from
loading all of a selected package's data
even if it may not be viewed; for example,
people don't always view the changelog. This
saves on calls to the server which are not
necessary.
Where data is loaded by the view, the view
layer no longer directly enqueues background
processes, but requests the main window to do
this for it. This unifies the approach for
the view to perform "actions" into a single
approach rather than different approaches in
different circumstances.
The changes also include better tab-
management for the "view package" detail.
Change-Id: I6a08ce9e37d1968655d14b8cc25519d534eccae1
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10845
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Jérôme Duval <[email protected]>
Enabled by default, but can be disabled via a new settings window
option (which is saved and remembered across runs.)
Change-Id: Ifd49cd734dcf5e4a5e5b3625d23bc2778fa1fa55
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10850
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
Putting all the per-CPU messages in one array means they'll all
be on the same cache lines. The cpu_ent structure is cache-line-aligned,
so this means they'll be on separate cache lines.
... and we're not extending the selection or dragging.
Done on MouseUp() to allow for drag & drop. Fixes#20043.
More fixes included in this commit:
* Refactor BPoseView::MouseUp() code dealing with selection and
popping menu. Don't consider fAllowPoseEditing for selection.
* Command **and Shift** extend selection.
* Create BPoseView::ExtendSelection() convenience method
(also used in mouse down).
* List view/icon view loc "fix". Code worked before because index
is 0 in icon mode but be explicit about pose location in list mode
vs. icon mode anyway.
* Add ASSERT() for Window() and CurrentMessage() to BPoseView::MouseUp().
We were already assuming they weren't NULL and it would have crashed
if they were.
* Replace pose with clickedPose style fix (meaning is clearer).
* Comment update for "last_buttons" message param.
Change-Id: I3ecb035dbca8b343c230f1e6aee3070939a4a3f6
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10814
Haiku-Format: Haiku-format Bot <[email protected]>
Reviewed-by: John Scipione <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Create a _SetWindowLocation() convenience method. This gets called in
the constructor, on Show() and when the Deskbar window state changes.
Do not Invoke() on SetValue(), call Invoke() after except when Deskbar
tells preferences to update its value instead of the other way around.
When focused numpad 4 and left arrow set top left expando mode,
numpad 6 and right arrow set top right expando mode. These are the
"left" and "right" positions of Deskbar. We can safely assume that
bottom left/right expando mode will never be implemented, only top.
Add a small horizontal space between the window location control and
the checkboxes, they are a bit too close to each other.
Fixes#20057.
Change-Id: I43289e4bf0e021ca2665a4f65a135edf6faff29e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10835
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: John Scipione <[email protected]>
... get/set from/to the app settings instead. This synchronises
bar view state and app settings state.
Set state in the app settings when TBarView::ChangeState() is called.
This updates the in-memory settings, they get saved on quit (reboot).
Change order of ChangeState() to be same as settings:
vertical, left, top, state.
Pass kExpandoState or kMiniState instead of a true or false.
kFullState is deprecated and unused.
Change-Id: I907e381396d99bd6d81cac8986dd6769735b6cd6
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10834
Reviewed-by: John Scipione <[email protected]>
Tested-by: Commit checker robot <[email protected]>
... without regression from #19403. Fixes#19769.
Drop version of BPoseView::MoveSelectionTo() signature changed.
Pass in uint32 moveMode to pass on create link or relative link.
This fixes the double create link on:
- Context-click => Create link/relative link => Current folder.
Use synchronous Go() in ShowDropContextMenu() to get the
return value. Asynchronous Go() always returns NULL so didn't
work right. Also don't send message since we're handling this
through the return value. Send MoveTo/CopyTo/LinkTo shortcuts
messages to window instead of the view.
This fixes the double create link on:
- Context-click drag and drop => Create link/relative link here.
Update loop control status better. Set stat size and perms.
Fixup MoveTo/CopyTo/LinkTo pose locations.
Change-Id: Ibff9f16d7c1c921a46a425de2f280318c40f4c69
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10715
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: John Scipione <[email protected]>
... and remove the "copy" suffix from it, that has to be passed in
along its length. Create convenience version to hide this.
Change-Id: Ifb488e73f496da676a413fd9e5d8fdeedcc7a2b4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10783
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: John Scipione <[email protected]>
TCPEndpoint::_NotifyReader() calls notify(READ, _AvailableData()),
which after a close will be negative, so this will set DISCONNECTED
in that case.
Drop the unnecessary duplication from TCPEndpoint::_HandleReset:
the net_socket layer sends READ|WRITE notifications in this case.
Fixes#19969.
Change-Id: I0e10c0280f3c84276b486b0375000153a117246d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10581
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
When the application updates data, the
featured tab remains grayed out because
it is not being invalidated. This will
ensure it is redrawn as the state
changes.
Also the tab will be enabled as soon as
a prominent packaged is seen rather than
wait for the end of the bulk load
process.
Change-Id: I3fbc7d67e19c804b7ac065a8409469773f08f95a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10844
Reviewed-by: waddlesplash <[email protected]>
Haiku-Format: Haiku-format Bot <[email protected]>
* Implement the TODO about needing to place stubs in executable
memory. This fixes basic ltrace operations.
* Place traces behind a TRACE ifdef.
* Get rid of the "patched table" and find the PatchEntry
using fixed offsets, to improve efficiency.
* Add a "bool trace" to PatchEntry. This paves the way for
tracing only specific methods.
Using LD_PRELOAD_ADDONS=...ltrace_stub.so, trace entries are now
printed on x86_64. However, it seems that the trace stub is clobbering
something, as BWindows don't work correctly when traced.
On a 64-bit nightly, it appears we're already using 16 out of the 20
slots for kernel_args ranges. On a 32-bit bootstrap build with symbols
enabled, we exhaust them (due to the network drivers that the bootstrap
build adds to the boot set).
The kernel_args are later freed by the kernel, so this shouldn't "leak"
any memory unnecessarily. With this size, we only need one chunk with
symbol loading disabled.
We never send it to the kernel but always free it. The kernel_args
allocator is very simple and can't handle frees besides the most recent
data, so this avoids "leaking" some kernel_args memory (it should all
be freed by the kernel later, though, so that only matters for
the bootloader itself.)
removed what i think is useles call for reading driver data
probably used for testing previously.
Built and tested with sd mounting.
Change-Id: I078fdd0e0d99f0a719700be14fd12d34ad56ca06
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10588
Tested-by: Commit checker robot <[email protected]>
Haiku-Format: Haiku-format Bot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
Nothing uses it (not even DEBUG_PAGE_QUEUE, it appears),
and it will need to be managed a different way for the
multiple ModifiedPageQueues, if we really do need it.
Use strchrnul instead of strchr, and increment at the end of the loop.
This avoids needing to call _ParseExportVariable in two separate places.
The invocation of line.Append(chunk, bytesRead) was also incorrect,
as bytesRead would be past the end of chunk if chunk had been
incremented. But this wasn't really a problem because BString
does strnlen() on the passed arguments.
Inspired by a change seen in a fork of the Haiku repository on
GitHub.
John Scipione