Due to `-Werror`, the warnings about unused variables, if
TRACE_CODEC is undefined, were breaking the build.
Change-Id: I2521f313b497afcb798b2b6c0ac6c00908fd0aac
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10570
Reviewed-by: waddlesplash <[email protected]>
On such case, the device may still report temperatures just fine, so
have separate "labels" for when we can't even open the device, or when
we just don't get its proper name.
Change-Id: Ia1924030e04de39c935b9f36a25858cbb1da467b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10556
Reviewed-by: waddlesplash <[email protected]>
Gets rid of the annoying:
"cc1: warning: command-line option '-Wno-ctor-dtor-privacy'
is valid for C++/ObjC++ but not for C".
Change-Id: Ic72506277af56365cfe52513e1118584bf338ac9
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10163
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
While fuse.h says that the `f_flag` field of statvfs (from the statfs() op)
is ignored, taking it into account (by setting B_FS_IS_READONLY in
fs_info's flag) allows Tracker to properly "hide" the "space bar", and on
new enough hrevs, to also use the "read-only background" on the windows
for such a read-only fuse-based volume.
To test this, I've modified sqshfs (from sqsh-tools) to add a "missing"
statfs() op, which amongh other things, sets f_flag to ST_RDONLY.
(the lack of statfs() was causing Tracker to not show a volume icon for
"sqshfs Volume"s)
Change-Id: I8e3758c32579218a100fde1ab20c3381649f90ce
Reviewed-on: https://review.haiku-os.org/c/haiku/+/9797
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
On machines with no acpi_thermal sensor, enabling the thermal readings
was showing the value as "-2.077.252.342 °C".
Let's show "No thermal sensor" / "0 °C" instead.
Change-Id: I4ba74e648b8826635cb4f4145540c833d1058220
Reviewed-on: https://review.haiku-os.org/c/haiku/+/9764
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Jérôme Duval <[email protected]>
I was testing a 3rd party fuse exFAT module, and on unmount, I was
getting the same assert failed as in #19734.
This change solves it in a similar way.
Change-Id: I2939d1609d6d96ce131a80ae26cbb92f77a75b34
Reviewed-on: https://review.haiku-os.org/c/haiku/+/9743
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
This allows getting the requires and provides for uninstalled packages,
in a format easy to parse for scripts.
Change-Id: I11a138540f820a0ecca3dad2238085fdfb9d51d2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/9589
Reviewed-by: Adrien Destugues <[email protected]>
- OPT+<key> combinations without a special meaning were generating
a space (' ') char instead of just the normal key.
While that helps to see on the Keymap preflet which OPT+<key>
combinations generate "level-3" chars and which do not...
having the "do not"s generate a space was akward.
For reference, on Windows, the equivalent AltGr+<key> only generates
a char for those key combinations that have a different than plain <key>
result.
- Use "keymap -s" (--load-source) on the shebang.
Change-Id: Iec5f46f2fceb45d31528da3ed5d8c48826ce3bb9
Reviewed-on: https://review.haiku-os.org/c/haiku/+/9065
Reviewed-by: Adrien Destugues <[email protected]>
Tested-by: Commit checker robot <[email protected]>
The menu item starts with: "System resources & caches..." but then it
wrote fCachedMemory before fCommittedMemory.
Swapping them seems more in line with how the rest of the "Memory usage"
menu is presented as well.
Change-Id: I83345f9ae35b405ed854e7a1992b537d31e27d02
Reviewed-on: https://review.haiku-os.org/c/haiku/+/9083
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: humdinger humdinger <[email protected]>
Haiku-Format: Haiku-format Bot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
This is less surprising than having it the other way around.
Adjusted the "MkKeymapHeader1" action on src/servers/input/Jamfile accordingly.
Change-Id: I9fb8f8d7d0cfde493c03755beafbff73222cba93
Reviewed-on: https://review.haiku-os.org/c/haiku/+/9066
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Jérôme Duval <[email protected]>
Before this, having partitions with the same fsName, blocksize, and capacity,
was enough to be considered a match for `initialMountRestore` mode.
That is too prone to false positives.
Now we require those three values, plus either deviceName, or volumeName
(or both) to match, before considering a partition as a valid match for
auto-mounting.
Fixes#19253.
Modifications by waddlesplash: put the score in an enum, and use
bitwise operations in checking the score.
Change-Id: Ifae63cd8e51fe5c8a38130130343a7209bff6d0a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8565
Reviewed-by: waddlesplash <[email protected]>
After settings Backgrounds to None for all worskapces, I was getting a 100%
reproducible segment violation on "fShowingBitmap->fBitmap->Bounds()" with every
resolution change.
Change-Id: I2a3640a3c33e571d772c1b38b21087346215dca8
Reviewed-on: https://review.haiku-os.org/c/haiku/+/8176
Reviewed-by: Adrien Destugues <[email protected]>
Haiku-Format: Haiku-format Bot <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Before this, changing the locale settings via Locale preflet required
a reboot in order for the changes to get picked up by programs running
on Terminal.
Fixes: #18734
Change-Id: I149931c511020f9eb881e71f79d1fd6c647477e2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7792
Reviewed-by: nephele nephele <[email protected]>
Haiku-Format: Haiku-format Bot <[email protected]>
Tested-by: Commit checker robot <[email protected]>
- Enable use of `find_directory()` when searching for "etc/makefile".
- Fixed a missing return statement on `_l::str()`;
- Fix "STATIC" typo on gAppTypes.
- Removed some superfluous spaces on the output makefile, added a couple
of missing ones.
- Avoid adding library paths as include dirs.
- Replace BeOS header paths with Haiku's.
- Some minor code style changes, here and there.
Change-Id: I03f221c39e894fb6ab6ffebd95ffe5e749678540
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7786
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Jérôme Duval <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
Using 4 spaces, instead of two, makes it easier to find
the available commands at a glance.
Change-Id: I2bbfaa323b89ebce490e34a39c4dfd163c23fd06
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7784
Reviewed-by: waddlesplash <[email protected]>
Requires HaikuPorts#7573 to be merged.
Closes#17836.
Smoke-tested on beta4 32 bits:
Gutenprint printer addon loads libgutenprint.so.9.5.0, shows new
printer models from where to choose from at "install new printer"
time, and "prints something" when using the Print-To-File transport.
Change-Id: Ia40dfd3c2163795e83c2cc173fd510d64c4bf6c9
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5969
Haiku-Format: Haiku-format Bot <[email protected]>
Reviewed-by: Alex von Gluck IV <[email protected]>
Do not fail silently if the saved fFilePanelPath doesn't exists, or
otherwise can't be used.
Default to B_USER_DIRECTORY, and print the issue to stdout at least.
Change-Id: If08720fa0d6d91bb7bd4b5a922be7136012aae95
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7536
Reviewed-by: Adrien Destugues <[email protected]>
Tested-by: Commit checker robot <[email protected]>
hrev57608 changes conflict with the use of left-option-as-meta (#18832).
Avoid that by using:
- CMD+left/right for switching tabs, and Shift+CMD+left/right for moving them.
- Ctrl+Shift+up/down for one-line-at-a-time scrolling.
Should fix#18832, but I'm still not happy with those scrolling shortcuts.
Also: removed some `(mod & B_COMMAND_KEY)` checks that don't make much sense
on `BView::KeyDown()`. They were there since hrev26038.
Change-Id: I8d276d18057d309b786f0480c27071cf084b38ef
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7495
Reviewed-by: humdinger humdinger <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
This allows programs running on Terminal to do things like select text using
SHIFT+arrows, and SHIFT+{Home,End} (tested with "mcedit" and "turbo" editors).
Moved Terminal's shortcut for:
- "Switch to nex/previous tab" to: B_OPTION_KEY+{left,right}.
- "Scroll Up/Down" to: B_OPTION_KEY+B_SHIFT_KEY+{Up,Down}
(B_OPTION_KEY+{Up,Down} seems to be captured elsewhere?)
References for the added escape sequences:
https://www.emacswiki.org/emacs/CuaModeTerminalProblems
Change-Id: I1b418f003355348dee454fbc680a09c220e80a3e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7241
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
While these three worked just fine on my old Atom N450 based netbook,
all caused:
"PANIC: SMAP violation user-mapped address [...] touched from kernel [...]"
on a newer netbook with a Celeron N4020 CPU, before this change.
Side note / drivers status:
- acpi_ac works pretty decently on both machines.
- acpi_lid wrongly returns 0 until you close the lid for the first time.
Reports correct values after that, but seems to cause power_daemon's
event loop thread to peg one core to 100%.
- acpi_thermal readings are a mixed bag. Critical temp values Seem OK on
both machines. Current value generally OK on the older machine, very wrong
on the newer (reports 429496728.6 C).
Change-Id: Ia387a0bd5b21bdba1de0f0cd9ded814aa1ecdc26
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7432
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
This avoids things like `cat /dev/power/acpi_{ac,lid}/0`
pegging CPUs to 100%, and the command never finishing.
Followed similar code already present on the acpi_thermal driver.
Change-Id: I5f13137716c36170608ab7e9dcbca628f48a138d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7397
Haiku-Format: Haiku-format Bot <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Jérôme Duval <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
This is similar to changes made in hrev56526 and hrev56815,
but for CPU related info this time.
Extracted some new _Get*() methods for the code that will get
called from both the normal and the replicant constructors
of SysInfoView.
Re-arranged the code a bit so the BStringViews get created /
updated in the order they appear on the GUI.
Change-Id: I2a371ec623e0b4d7497056fae6d5346b98d07ee2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/6396
Reviewed-by: John Scipione <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
Extracted a _GetKernelDateTime() function, and used that to get the value
for the kernel date/time text, and to update it at replicant's instantiation
time.
Fixes#18149.
Also: changed the _Get*() methods to return BString instead of const char*.
Change-Id: I908fe25f39355b3d46f504bd0d8a5fdef1af67f1
Reviewed-on: https://review.haiku-os.org/c/haiku/+/6158
Tested-by: Automation <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
GCC complained of missing prototype for "uninit_hardware()" and,
as -Werror is enabled for these targets, build was broken for them.
While src/system/kernel/device_manager/legacy_drivers.cpp supports
that hook in legacy drivers binaries:
- no header mentions it.
- these two were the only places in-tree that implemented that hook.
- both were basically no-ops.
Change-Id: Ifb08846351b92a2d0fbbe95db2eee0e424ae5997
Reviewed-on: https://review.haiku-os.org/c/haiku/+/6180
Tested-by: Automation <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
* Extracted an "acpi_ac_update_status()" function.
* Use that for both "acpi_ac_init_driver" and "acpi_ac_notify_handler".
This ensures that "acpi_ac_read()" returns the correct (current) status.
Change-Id: I4f8f35037180c10fe507b9abfda3a8a169349c13
Reviewed-on: https://review.haiku-os.org/c/haiku/+/6048
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
To avoid dstcheck appearing on Deskbar's Recent applications menu
right after boot.
Noticed that /bin/fortune was also missing this flag.
Change-Id: I18e166d83d85613a99903b0805565647b7d4d001
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5949
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
Shortcuts was a bit overzealous while filtering out modifiers on
B_KEY_DOWN message handling.
This allows to enter keys regardless of the state of caps, scroll, or
num-lock modifiers.
Change-Id: Ie204f8e7938214ca68f45404026c7959216e0fc7
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5943
Reviewed-by: Jessica Hamilton <[email protected]>
This work-arounds the issue of the VirtualMemory preflet showing
RAM FS volumes as valid storage options for the swap file.
Removing B_FS_IS_PERSISTENT didn't work as I originally expected,
causing problems when attempting to write/delete entries on RAMFS
mounts after that.
Kudos to waddlesplash for the B_FS_IS_REMOVABLE alternative.
Change-Id: Id5ba1fa192b63b944cf59413a7f580ebb608e50d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5911
Reviewed-by: waddlesplash <[email protected]>
This makes sure that apps get access to these variables regardless if
they are started from a shell or from GUI (double-click from Tracker,
desklink, etc).
Fixes#18130.
Change-Id: I82e2884e460fad7d6ec16e7b624c5cd2fcf807df
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5897
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
Not particularly high priority (this being a test) but... I came across
these while searching for code still needing updates after the changes
on BPartition::ContentName().
Change-Id: I05e8d6c02ba34688cee4f0b55e4e782243b0af4d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5769
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
Opening and closing a file from the results window with Pe, for
example, was triggering unnecessary new grep searches, when only
the attributes or other metadata on the file got changed (and
not its content).
That new search was also changing the focus from the results view
to the search field (making one lose the position on that list,
specially annoying with large number of results).
Avoid that by not monitoring/reacting to B_ATTR_CHANGED, and not
reacting to B_STAT_CHANGED if the only flag is B_STAT_CHANGE_TIME.
Change-Id: I56d34c93da94acf36890abe458da45d26a334593
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5763
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
Extracted a _GetOSVersion() function, and used that to get the value
for version text, and to update it at replicant instantiation time.
Should fix#17957.
Change-Id: Ifc964c3646743a503fd756c902d102977e35e73d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5724
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: John Scipione <[email protected]>
Reviewed-by: Jérôme Duval <[email protected]>
This fixes "issue 2" from #17150, that only manifested on x86-64.
Also: moved the "menu" variable declaration closer to its usege.
Change-Id: If44f84a8d5ee2bd662c312aec26359c857db5a93
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5720
Reviewed-by: Adrien Destugues <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Previous patch was tested only with single files arguments, thus
missing the usage of "os.path.walk()" (that was removed on 3.0).
Use "os.walk()" instead, that has been available since Python 2.3.
Change-Id: Ia290bebaa950466ac5f1d978f0a5e710a8e3da88
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5696
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
* Change prints to be compatible with 2.x and 3.x.
* Use html.escape instead of cgi.escape on Python >= 3.8.
* Make integer division explicit.
Change-Id: Ib9b236816e8fa07741c02d0e79629c4aa0ed6676
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5603
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
* Reduce default search scope to: "name", "summary", and "provides".
* Add a new "--search-scope=<scope>" option that allows to either limit
the search to packages names (-s name), or to replicate the previous
behavior of searching everywhere in the package info (-s full).
Motivation for the change:
The ever increasing number of packages available for Haiku was impacting
pkgman search usefulness, as it easily returns too many packages (what a
wonderful problem to have :-D).
Limiting the default search scope helps with that, and the old behavior
is kept "just an option away".
Change-Id: I5b456b90137237134eee7ca7ee501bf8e3767440
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5616
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Jérôme Duval <[email protected]>
* Disable BMenuField unless a sound event is selected.
* Changes in the MenuItem enable/disable the play button as necessary.
(previously only changes in the EventList did that).
* Enable the play button when BFilePanel is closed (after selecting valid file).
Fixes the (still reproducible) UI/UX portion of #17150.
Change-Id: I5b5d00cc7fce00a0d0f908bbaff883169f38f855
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5613
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Jérôme Duval <[email protected]>
Oscar Lesta