Rene Gollent
71279b24dd
Adjust the thread counting to use atomic adds. This should prevent the previous scenario where many more threads than the limit could actually be spawned.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28775 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-12-04 03:28:19 +00:00
Rene Gollent
83868e649d
Defer actually spawning the thread to the call to Run(). The way the thread manager is currently written as a whole won't correctly enforce the thread limit (looking into that, though I think a different approach entirely is merited here anyways), but this at least prevents large numbers of threads from being spawned and sitting in the suspended state in the registrar forever. Fixes ticket #3172 .
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28774 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-12-04 00:28:03 +00:00
Rene Gollent
c3341227ea
If the source volume is read only, only allow a copy op since move makes no sense in this case. Ideally we should probably also modify NavMenu and the drag context menu to only present the options that make sense in a particular situation. Fixes ticket #3195 .
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28769 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-12-03 14:43:23 +00:00
Rene Gollent
f836b0656b
Updated CVS and yasm packages, thanks to Scott McCreary for the updates!
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28768 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-12-03 02:46:59 +00:00
Rene Gollent
4f7d38d331
Correctly indicate "Copying" vs "Moving" state in status window (thanks Adrian Panasiuk for pointing this out).
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28762 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-12-02 23:05:06 +00:00
Rene Gollent
91da321846
Remove unnecessary length check, and add a clarifying comment.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28758 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-12-02 00:41:02 +00:00
Rene Gollent
4ebaf16fab
We need to check if we have an exact match in order to match BeOS's behavior (a directory is considered to contain itself on R5). Nice catch Axel!
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28757 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-12-02 00:19:40 +00:00
Rene Gollent
6020e8a4c3
When comparing paths, we need to ensure that the entry's path does in fact have a path separator at the same position as the original, otherwise we incorrectly indicate containment in some cases. Fixes ticket #3186 .
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28754 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-12-01 14:08:53 +00:00
Rene Gollent
87f41e61ea
Resolve several bugs that are probably as old as Tracker itself:
...
1) Move To now works as advertised in all cases - previously it
silently converted a move into a copy if the destination volume
was different, as its move code was not geared towards handling
that case properly. This also has the side effect that drag and
drop is now always a move as well unless overridden via right click
DnD. This may or may not be reverted back to the original behavior
later depending on the consensus.
2) Copying a folder onto another folder of the same name now merges
the contents instead of destroying the original. This fixes ticket
#1420 . Still to do: interactive prompting to allow fine grained file
replacement and skipping in this and other multi-file cases, but
I'll open a new enhancement ticket for that.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28731 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-11-26 03:40:41 +00:00
Rene Gollent
52a7c90673
Position-based binary searching can only be used if the view has been attached
...
to a window already. If not, we fall back to using the BList-based search.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28696 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-11-19 06:04:53 +00:00
Rene Gollent
4e0a1b40ad
Temporarily revert that last change since it breaks the IM Kit's preflet for reasons I don't yet understand. Investigating.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28695 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-11-19 05:11:37 +00:00
Rene Gollent
128cb2f6f3
Minor optimization: since our list items cache their position information,
...
take advantage of this fact to make use of binary search in
IndexOf(BListItem *), rather than using BList's linear search.
Also use this mechanism to speed up HasItem(BListItem *).
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28694 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-11-19 04:41:51 +00:00
Rene Gollent
633645bca9
Fix a potential race condition in BPopUpMenu: if Go() is called on an async
...
popup menu that hasn't yet been completely dismissed, it's possible to hit a
debugger call because the menu's view tries to add itself to the menu window
before the previous menu instance has removed it. This was quite easy to
hit with things like BColumnListView's column title context menu, since there
is no notification for when the menu was dismissed without invoking an item,
and thus double right clicking quickly enough would hit the debugger. Go()
now checks if the menu's tracking thread is still up, and if it is, waits for
it to go away before trying to start another instance. Fixes ticket #3146 .
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28693 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-11-19 04:01:05 +00:00
Rene Gollent
6826c30a25
When an item is added to the list, we must immediately set its top,
...
otherwise if it tries to make use of any positional information in the
subsequent call to Update() (i.e. calls to ItemFrame(), or Top(), it will
get back bogus coordinates. This should correctly fix the problems seen with
Themes, possibly amongst others.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28692 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-11-19 03:54:59 +00:00
Rene Gollent
6cf3a9ebf7
The previous commit exposed another bug: BWindow::Zoom() incorrectly calculated the max height of the window by only including the border width once. This was previously masked by the fact that the (by default 5) extra pixels were included in its hardcoded default for the height of the tab. Also add the border width to the message returned by GetDecoratorSettings() so Zoom can use the actual value instead of hardcoding it.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28679 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-11-17 04:15:51 +00:00
Rene Gollent
ca9a61313a
Resolved a small todo thanks to r28664:
...
We now ask the app_server for the window tab's height instead of
hardcoding it.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28678 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-11-17 00:47:23 +00:00
Rene Gollent
d27b24661d
Fix a few minor problems that resulted in the sound column not being drawn until clicked. Also changed CLV to use B_PLAIN_BORDER. This fixes the redraw issues in ticket #2980 .
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28658 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-11-15 16:38:54 +00:00
Rene Gollent
e02ed691ca
Patch by Adrian Panasiuk: fix broken TRACE macro definitions (ticket #3133 ). Thanks!
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28656 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-11-15 02:42:56 +00:00
Rene Gollent
dfdca9b67f
Remove.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28593 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-11-10 13:47:58 +00:00
Rene Gollent
eb40d3eb59
Restore accidentally removed comment.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28592 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-11-10 13:45:21 +00:00
Rene Gollent
577fe1f9a1
Implement missing B_CREATE_PROPERTY.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28589 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-11-10 05:52:43 +00:00
Rene Gollent
433cc8bc0f
Resolved some more misunderstandings in how this is supposed to work. Ticket #3087 should finally be fixed now.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28588 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-11-10 04:54:47 +00:00
Rene Gollent
f871c6f737
Reset the drawing state to that of the client view after we finish drawing the workspaces replicant. This fixes artifacts like fonts occasionally appearing tiny when selecting/deselecting items on the Desktop if the Workspaces replicant was also embedded.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28585 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-11-09 22:04:51 +00:00
Rene Gollent
c02466e6ee
Alter the order in which we updated our cached items. This fixes things like mmu_man's Themes app which has somewhat unusual list items that embed BViews.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28580 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-11-09 18:20:01 +00:00
Rene Gollent
00c3e84a23
When previously fixing shelf scripting for BSnow, I accidentally broke nested specifiers (i.e. Get ID of Replicant).
...
This should fix ticket #3087 .
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28571 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-11-08 22:59:22 +00:00
Rene Gollent
a418aa5f4f
Fix function spacing.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28535 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-11-06 13:56:11 +00:00
Rene Gollent
01406f374d
Rework this a bit to handle ctrl+clicking and ctrl+alt+clicking for right and middle mouse button.
...
Fixes ticket #3061 .
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28528 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-11-06 03:07:38 +00:00
Rene Gollent
83b6ce6be6
Incorrectly specified that jam rule, that link should go in beos/bin since that's what /bin actually points to.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28527 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-11-06 00:35:19 +00:00
Rene Gollent
5cefa96801
These dirs should exist by default in the image, various installers will fail since they're expected to be there.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28519 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-11-05 16:17:33 +00:00
Rene Gollent
c068350a89
Temporarily symlink m4 and perl to their new locations until the other dev packages are updated. This unbreaks bison and a few other things.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28510 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-11-05 04:22:56 +00:00
Rene Gollent
9db8c2f7bd
Add BeBook to optional packages for pre-alpha image.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28467 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-11-02 18:19:27 +00:00
Rene Gollent
73ca5aff45
Fixed numerous problems in BWindow::_FindView:
...
1) If a view contained the point, but had children, that view would never be returned as a result, even if none of the children matched.
2) When converting coordinates to the child's coordinate space, it was using the bounds rectangle rather than the frame. This in most cases had the result that the coordinate was unchanged, and thus messed up the search completely.
This fixes ticket #3000 .
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28440 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-11-01 20:14:56 +00:00
Rene Gollent
c15ed4c682
Correct slight error.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28434 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-11-01 16:52:45 +00:00
Rene Gollent
5233e974e2
Update Vision package for some minor fixes:
...
- fixed layout of font preflet
- enabled InfoPopper support
- incorporate recent BCLV changes
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28431 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-11-01 15:21:52 +00:00
Rene Gollent
1d43a131ea
Remove extra pixel constants that were always added to the total item height when calculating the vertical scrollbar proportions. This fixes the empty space that was always added to the end of the CLV (ticket 2980).
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28373 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-10-29 23:46:28 +00:00
Rene Gollent
a4f9a2b8c5
Fix various errors in handling specifiers and/or scripting messages. This
...
makes the Get, Count and Delete Replicant scripting directives work correctly,
and consequently fixes the Remove BSnow button (ticket #1897 ), as well as
commands like: hey Tracker Get Replicant BSnow of Shelf of View PoseView of Window 1
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28361 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-10-28 23:18:59 +00:00
Rene Gollent
3cead3c68e
Make this check a bit more general purpose: in the case where the dragger is a child of the target view (probably the most common use case), we now verify that the dragger's frame is completely within the target, otherwise we reset it to a default position of the lower right corner. I'm not sure how to do similar validy checking in the case of the other relationships (or if that's even feasible) though. Comments welcome as always :)
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28336 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-10-26 15:22:02 +00:00
Rene Gollent
1bbf044eeb
In various apps such as ActivityMonitor, BDraggers are instantiated with
...
invalid rects (in ActivityView's case in particular, (-7, -7, 0, 0)). BDragger
would happily accept these, and preserve them when being archived/unarchived,
which led to its position being completely messed up in the target shelf.
We now compensate for this when determining our relationship with the target
view. This fixes the problems with missing replicant handles in BSnow,
ActivityMonitor and probably others replicants. The solution used here might
not be ideal though, so comments welcome.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28330 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-10-26 04:50:50 +00:00
Rene Gollent
1ad73b3187
Always call Radeon_InitCP ; it explicitly checks if acc_dma is set and skips
...
parts of the init sequence if that's not the case anyways. This correctly
initializes the engine lock and a few other things, fixing the deadlock in
ticket #2893 . This also seems to result in somewhat improved graphics
performance, at least on my X800.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28295 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-10-23 13:59:05 +00:00
Rene Gollent
950eeadd92
Factor out a ValidateDest() function that checks if the destination is valid
...
and throws up a BAlert if not. Reuse this when the user clicks expand to check
for and grab the destination path. This fixes the problem that if the user
manually types in or pastes a destination path and then immediately clicks
Expand, the actual destination path used is never updated. Thanks to Daniel
Teixeira for reporting.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28283 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-10-22 13:54:30 +00:00
Rene Gollent
a325faf93f
Omitted change in 28244, the handle wasn't passed. Thanks thotypous!
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28255 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-10-21 03:06:33 +00:00
Rene Gollent
ca5e024130
Probably forgotten changes in the last commit, though I'm not sure if Axel had any other style cleanups in mind in this file. Fixes build at any rate.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28230 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-10-18 15:45:57 +00:00
Rene Gollent
a6a18aeb66
Add OpenSSH to list of available OptionalPackages.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28225 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-10-17 22:40:17 +00:00
Rene Gollent
4a4355bd7d
app_server was not storing its settings when the workspace count was changed.
...
As a consequence this setting was lost unless another setting was also altered
that affected the workspace configuration in some way.
Fixes #2849 .
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28206 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-10-17 01:56:44 +00:00
Rene Gollent
d8383f234c
Update example description to the current state of affairs. Please revert to old description whenever we enable ACPI by default again.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28202 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-10-17 01:01:11 +00:00
Rene Gollent
8cca2102aa
Fix build (ShowingAwarePopupMenu was not added to libtracker's build, resulting in undefined sym errors).
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28144 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-10-15 15:43:05 +00:00
Rene Gollent
1138737b87
Fix regression introduced in r28116: Due to the change in variable names, the
...
wrong version of ConvertFromScreen() was now used, resulting in the calculation
being computed and thrown away. This broke BMenu, probably amongst other things.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28118 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-10-15 01:59:39 +00:00
Rene Gollent
dfcc059e7b
Fix build of tool version of makebootable on Haiku.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28062 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-10-13 23:27:50 +00:00
Rene Gollent
35cfb6a900
Adjust ata bus manager to compensate for r27979.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28049 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-10-13 20:57:37 +00:00
Rene Gollent
d0da34f00f
Code style cleanup / honored 80 column line length limit. Modified FireWireDVAddOn to use BObjectList.
...
Feel free to chime in if I missed any style violations.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@28000 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-10-12 18:15:54 +00:00
Rene Gollent
b99c736b83
Add the current version of JiSheng Zhang's firewire_dv media add-on to the
...
build. This is mostly complete, excepting BBufferConsumer's virtuals are not
yet implemented, and needs more testing to ensure that the encoded stream is
correctly read from the camera, though based off preliminary tests by Francois,
detection/publishing at least seems to work.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27965 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-10-11 04:52:20 +00:00
Rene Gollent
aa420f85e2
Added TRACE macros to this file and redid its dprintfs to use that instead.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27945 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-10-09 13:41:15 +00:00
Rene Gollent
8b6f1d5ef5
Fixed warnings with tracing enabled and made some very noisy dprintfs trace-only
...
as they were flooding the syslog.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27935 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-10-09 03:53:00 +00:00
Rene Gollent
1ad71ed0a0
Fix a couple of broken FLOW traces.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27683 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-09-22 02:10:14 +00:00
Rene Gollent
90b7764dc3
Move WidthBuffer and TextGapBuffer into BPrivate and use them from there in BPoseView and BTextView. This (correctly) fixes the previous gcc4 build issues.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27675 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-09-21 20:47:16 +00:00
Rene Gollent
40ca6c57ee
Declare BPoseView as a friend of BTextView. This allows it to use the private width buffer classes, and fixes the gcc4 build.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27673 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-09-21 18:03:17 +00:00
Rene Gollent
8d619bc9d2
Build fix, thanks to Frederik Ekdahl for submitting!
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27575 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-09-15 18:48:33 +00:00
Rene Gollent
ea0316d305
Updated RTL8139 driver to 7.0-RELEASE version.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27401 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-09-10 15:17:56 +00:00
Rene Gollent
fc60ab16f5
gcc4 build fixes.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27381 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-09-08 13:49:54 +00:00
Rene Gollent
204737b832
Patch by Dustin Howett: Add i945GME to the supported devices list (caveat: no overlay).
...
Thanks!
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27365 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-09-08 02:45:14 +00:00
Rene Gollent
ddfa870bb5
Set native eol-style (CR/LF issues).
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27340 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-09-05 23:34:16 +00:00
Rene Gollent
0f1d1fbe30
Temporarily disable this check in Invalidate() as requested by Stephan. This fixes the problem with redraws seen in FlattenPictureTest and a few other places.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27337 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-09-05 17:07:36 +00:00
Rene Gollent
9442a1bb44
Just noticed this file was using CR/LF newlines...
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27276 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-09-01 20:12:13 +00:00
Rene Gollent
7fb33cd07d
I hate to add another special case, but with the way the BMenu* classes are designed, I see little in the way of alternatives. If we're a BMenuField's menu bar, then we should invoke the menu item regardless of where in the bar we click. This problem was visible in ticket #1877 , where basically you could click only on the portion with text, because that was the size of the menu item, where the rest of the contained menu bar was considered dead space. Thus we now check if we're an instance of BMenuField's special menubar class, and if so we unconditionally select the item instead of a hit test. Fixes the aforementioned bug. If someone has a better approach, I'm all ears.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27271 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-09-01 19:33:50 +00:00
Rene Gollent
21cc1202f3
Fix this bug in the correct spot by forbidding the controller from trying to toggle the playback state if it hasn't been initialized with a file. Thanks for the tip, Stephan!
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27205 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-08-26 02:32:13 +00:00
Rene Gollent
df5d28d4d9
Style cleanup.
...
When asked to toggle playback, PlaybackManager never checked if it had a previous playback state to copy from. This caused a crash if playback was toggled via the keyboard when no file was loaded. Fixes ticket #2664 .
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27194 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-08-25 00:40:10 +00:00
Rene Gollent
878cc30445
Follow Axel's example in r27000 and use addr_t here.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@27007 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-08-17 16:49:39 +00:00
Rene Gollent
da3c38792b
Slightly more defensive approach to searching for the image. Thanks Axel :)
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26995 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-08-16 22:07:33 +00:00
Rene Gollent
6296f36bc3
Use __HAIKU__ instead of HAIKU_HOST_PLATFORM_HAIKU since apparently the latter doesn't get defined when cross compiling.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26989 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-08-16 05:11:36 +00:00
Rene Gollent
99b25014bb
Do this somewhat differently so as to not break makebootable on non-Haiku hosts. Thanks to luroh for pointing this out.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26988 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-08-16 04:26:27 +00:00
Rene Gollent
adf42886f2
Use get_next_image_info to resolve the path to the executable. This fixes the problem that makebootable will not work unless run with an absolute path.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26987 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-08-16 03:06:02 +00:00
Rene Gollent
fb6d782320
Fix some style issues pointed out by Axel.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26940 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-08-12 12:41:10 +00:00
Rene Gollent
3734bee77d
When the boot loader goes to load its settings files, it will now also prepend the "kernel" settings file to the safe mode settings if it exists. This allows settings from kernel/drivers/kernel to be respected early in the boot process as well, which allows us to do things like disable_smp permanently instead of having to pick from the safe mode menu every single boot. Review welcome.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26937 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-08-11 23:03:36 +00:00
Rene Gollent
eb9c6bd38a
Adopt Axel's solution to the unmount/rmdir problem (only remove from rootfs) in DriveSetup also.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26611 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-07-24 14:15:23 +00:00
Rene Gollent
7a1c09b66a
Only try to rmdir in the case of success.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26595 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-07-23 23:09:08 +00:00
Rene Gollent
5c4fff2ef1
Tracker and DriveSetup now attempt to clean up the mount point after successfully unmounting the volume.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26593 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-07-23 22:55:00 +00:00
Rene Gollent
ef7fb431ed
Remove extraneous put_vnode(). This would result in decrementing the vnode ref count even if an unmount operation failed, which in turn would cause other fun problems. This fixes tickets 1982 and 2538. However, there seems to be another problem remaining with unmounting: the placeholder dir in the rootfs is not removed when the volume is unmounted, or it's not reused correctly. As a consequence, on subsequent remounts of the same volume via Tracker or mountvolume, a new dir is created each time, leaving empty placeholders. (i.e. remounting the volume HaikuData results in the creation of /HaikuData1, 2, 3, 4, etc.).
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26586 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-07-23 21:39:48 +00:00
Rene Gollent
e36b6d3e2c
Update Vision package to version 0.9.7-H-21072008. This fixes incorrect BBitmap colorspace usage which resulted in transparent pixels being painted green on recent versions of Haiku, most notably on the arrows in the network setup window.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26551 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-07-21 22:45:45 +00:00
Rene Gollent
fab7925690
Update vision package again.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26493 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-07-18 23:43:49 +00:00
Rene Gollent
68b028320a
Update Vision package again for a resize-related bugfix.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26490 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-07-18 20:36:48 +00:00
Rene Gollent
7522d08271
Update the package name to force a redownload.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26482 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-07-18 02:04:02 +00:00
Rene Gollent
c95c53f469
Updated Vision package URL to new version with URL parsing fix.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26481 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-07-18 01:53:12 +00:00
Rene Gollent
2cfee16a9e
Build fix.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26438 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-07-15 18:26:40 +00:00
Rene Gollent
78163ba34d
That should've been eol-style :/
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26194 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-07-01 17:31:11 +00:00
Rene Gollent
452d5f989a
Set svn:eol property to native to deal with CR/LF problems.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26193 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-07-01 17:27:24 +00:00
Rene Gollent
781420cc0e
Don't include the easter egg decor menu in Haiku builds since it does nothing anyhow.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26176 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-06-30 02:51:08 +00:00
Rene Gollent
fa366cbe40
Accidentally broke CountItemsUnder() for invalid items with previous commit. This fixes
...
VLC, which for some reason calls CountItemsUnder(NULL) quite a few times on startup.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26167 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-06-29 18:54:28 +00:00
Rene Gollent
84d75fa444
Rewrote SwapItems() so as to not fail in various cases.
...
Fixed logic error in CountItemsUnder() that would sometimes
return the wrong count. This would result in issues such as
Vision's network reordering failing to reorder down due to
retrieving the wrong item based on the count.
This fixes ticket #2447 .
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26149 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-06-28 03:03:56 +00:00
Rene Gollent
4079af86ca
gcc4 build fixes.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26091 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-06-23 00:54:54 +00:00
Rene Gollent
fa83a2a121
These files were in CR/LF newline format for some reason.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26084 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-06-22 19:49:08 +00:00
Rene Gollent
aa2ff66326
The attribute copy operation was nested inside a conditional block which wouldn't be executed if the file being copied was zero bytes in length. Moved outside the block to where permissions and other optional operations are handled. This fixes bug #2259 .
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26013 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-06-18 22:04:15 +00:00
Rene Gollent
fe83a98715
Remove unneeded header.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25947 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-06-12 21:33:13 +00:00
Rene Gollent
0c8bdbafd5
Revamp BList somewhat to further optimize the resizing behavior.
...
We now keep track of a lower bound as to when the list should scale
itself back down. When increasing the list size, we double the current,
with the lower bound set to 1/4 of the current size, not allowing it to
go any smaller than the block size. These combined allow us to do very
cheap tests to see if an operation requires a resize at all, and minimize
how often the list actually needs to be resized, since the difference in upper
and lower bounds prevents bouncing back and forth between a size in the case
of adding/removing an item while close to a boundary. All in all this should
make BList noticably more scalable when doing large numbers of add/remove
operations.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25946 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-06-12 21:30:28 +00:00
Rene Gollent
6559de374d
Build fixes.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25933 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-06-11 22:43:07 +00:00
Rene Gollent
819eb21bbf
Remove (invalid) TODO note. Rename variable more meaningfully. Remove stray whitespace that crept into previous commit.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25927 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-06-11 14:29:59 +00:00
Rene Gollent
34380ac48c
Tracked down issue with previous commit. For some reason, modifying the passed in parameter's value directly results in a segfault in registrar, and I cannot see why. Thoughts?
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25920 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-06-11 00:32:48 +00:00
Rene Gollent
22aef42481
Revert this change until I determine why it now crashes the app_server when it didn't during my tests.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25919 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-06-10 23:25:33 +00:00
Rene Gollent
864ace1845
Rework BList's Resize() functionality: instead of altering the size of the list a block at a time,
...
we now double/halve the current size of the list, starting with the constructor blocksize as a baseline.
This has the net effect that when doing large numbers of inserts/removes, the number of resize operations
needed scales logarithmically to the number of operations, which should yield a decent performance
improvement in such cases.
Review welcome. This does not yet affect ticket #2363 that I'm aware of, as I'm currently in the process
of attempting to find a copy of said app to test with.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25916 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-06-10 22:10:13 +00:00
Rene Gollent
ef83ae3e0b
Remove BOutlineListView's home-brew quicksort implementation in favor of a comparator that hooks into the STL's sort algorithm as suggested by Ingo. Tested and seems to work nicely.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25848 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-06-07 16:14:30 +00:00
Rene Gollent
fed7414a59
A view shouldn't be able to RemoveChild a view that it isn't in fact the parent of.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25835 a95241bf-73f2-0310-859d-f6bbb57e9c96
2008-06-07 07:10:08 +00:00