i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
41,557 Commits 1 Branch 0 Tags
8df5e79d2c734f683be421eb997d72d1d205fc23
Commit Graph
41557 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Philippe Saint-Pierre 8df5e79d2c Tracker: FSMoveToTrash(): needless check and possible crash fix 
In an earlier commit, I removed a memleak, but it was covering more cases
than intended.  Thanks to Alex Wilson's insight, it seems that simply removing
the check is better (since that check is essentially redone in FSMoveToTrash()).
 2012-01-05 17:55:12 -05:00
czeidler b5c5640ec0 Style fixes. Thanks Axel and Ingo. 2012-01-06 09:35:33 +13:00
François Revol 430fc0e90c Fix build for !x86 && !ppc 
At least this should fix other platform builds to the point they worked before.
The ICU_DEVEL zip name assign was moved inside the if block, making it empty for other archs, and ExtractArchive was of course having issues with this.
So I moved the rest inside the if block as well. Should fix at least kernel builds.
 2012-01-05 03:30:10 +01:00
François Revol 577d81a9b6 Add proper error on ExtractArchive with missing filename 
The * case was not generating any message due to empty string expansion I suppose...
 2012-01-05 03:30:10 +01:00
Philippe Saint-Pierre f91a2037a5 intel accelerant: NULL dereferences (overlays) 
Rather than checking if "window" AND "view" are NULL, check if
"window" OR "view" are NULL, since neither could be null and deferenced later
on.

From the Matrox accelerant, it seems that such event occurs when a
"Workspace switch, screen prefs change, or overlay app shutdown occurs"

Might be interesting to revisit tickets related to intel accelerant.

CID 205.
 2012-01-04 20:48:15 -05:00
Philippe Saint-Pierre 97f16764c7 Tracker: Memory leak fix 
The leak occured everytime a folder, or queries where opened while
navigating.

CID 5848.
 2012-01-04 19:51:26 -05:00
François Revol 8e977a874f M68K: Only enumerate ST modes as fallback. 2012-01-05 01:44:38 +01:00
François Revol 595938e710 M68K: Don't trace mmu boot code anymore 2012-01-05 01:44:37 +01:00
czeidler 32951c4e63 Make BReference and BWeakReference behave more like a normal pointer. 
* Casts like BReference<Derived> to BReference<Base> are now possible.
* This cast for BWeakReference is, because of the underlying structure, not automatically type safe. I used a simple hack to make the compiler complain if the cast
is not type safe. Please take a look if that can be done better.
* Smaller style and bug fixes.
 2012-01-05 13:42:45 +13:00
Philippe Saint-Pierre dafbb16406 Tracker (FSUtils): negative passed to unsigned parameter 
BVolume::BlockSize() might return a negative value (error code) and it
was passed as parameter of CalcItemsAndSize() as a size_t (unsigned).

Thus the check for an error code failed.

CID 4171.
 2012-01-04 19:31:17 -05:00
Philippe Saint-Pierre aa11dcae4d Tracker (InfoWindow): small memory leak fix 
In the case of a broken symlink, a Model object was leaked when trying
to get the icon of the target.

CID 5844.
 2012-01-04 19:23:12 -05:00
François Revol 68aea33966 Try another load address for PPC CFE loader. 
This is the address the OpenFirmware is loaded to by CFE on the Amiga X-1000.
Doesn't seem to help much though.
 2012-01-05 01:03:28 +01:00
Philippe Saint-Pierre c56f0ce1c3 FindPanel: Avoid NULL deference; CID 352. 2012-01-04 18:44:21 -05:00
Michael Lotz f13be4928b Pad the transfer buffer to prevent out of bounds access. 
The HIDReportItem reads 32 bit chunks from the report buffer. To avoid
having to check the remaining buffer space on each extraction, we pad
the buffer so it is always valid to read 32 bits at a time. Also add
a comment explaining why we do it that way.

Thanks to Johannes Anderwald for pointing out the potential out of
bound access!
 2012-01-04 23:33:07 +01:00
Jérôme Duval 90b92dab5c added memrchr to string.h, guarded by __USE_GNU. Also guards strchrnul. 
Original patch by Dario Casalinuovo.
BUG: Ticket #8265
 2012-01-05 00:17:41 +01:00
Philippe Saint-Pierre d390c06551 PoseView: Fix assertion in InitDirentIterator 
The dynamic_cast was called twice, and the assert was
done on the first attempt. Now it just cast once, assert on this
and pass it further as before.

CID 3122.
 2012-01-04 18:11:12 -05:00
Philippe Saint-Pierre fcfd687380 Tracker: memory leak fix 
In MoveRefsToTrash(), the srcList wasn't deleted after usage.

CID 5849.
 2012-01-04 00:01:26 -05:00
Philippe Saint-Pierre f30530e387 ffmpeg (gif codec): Init len variable 
It was already fixed upstream. CID 9309.
 2012-01-03 23:35:14 -05:00
Philippe Saint-Pierre 1923ea178d ffmpeg: infinite loop (als decoder) 
CID 3176.  Patch proposed upstream.
 2012-01-03 22:49:01 -05:00
Philippe Saint-Pierre 9d991e3c99 Firewire: uninit buffers returned 
Probably a copy-paste error caused the wrong variables being returned
in fw_xfer_alloc_buf() for the received transfers.

CID 10746.
 2012-01-03 20:24:17 -05:00
Philippe Saint-Pierre f08709bbea No functional change; invert the order of includes. 2012-01-03 18:51:25 -05:00
Philippe Saint-Pierre 82556487af MediaConverter: Move a NULL check 
To avoid a NULL dereference, moving a NULL check earlier.

CID 5955.
 2012-01-02 23:27:59 -05:00
Philippe Saint-Pierre 7cd8f5f9b9 TextView: initialize buttons variable 
CID 10751.
 2012-01-02 22:46:30 -05:00
Philippe Saint-Pierre f54fc2dcfe Terminal: NULL dereference fix 
An inversion in a condition could lead to a NULL dereference.

CID 11039.
 2012-01-02 22:30:28 -05:00
Philippe Saint-Pierre 4040b622f4 VM: Memory leak fix in case of bad driver settings file 
CID 5891.
 2012-01-02 22:12:09 -05:00
Philippe Saint-Pierre 7d0a351c0a Wonderbrush translator: memory leak fix 
A Buffer in archive_bitmap wasn't free'd upon completion. CID 5751.
 2012-01-02 21:29:02 -05:00
Philippe Saint-Pierre c5e599ac1a IconUtils: memory leak fix 
The intermediate step BBitmap in scale2x wasn't deleted. CID 10692.
 2012-01-02 21:07:55 -05:00
Philippe Saint-Pierre 0891b95e63 Installer: Resource leak fix (CID 10693). 2012-01-02 20:54:49 -05:00
Philippe Saint-Pierre fccd8899fc People: memory leak fix. CID 10694. 2012-01-02 19:27:21 -05:00
Philippe Saint-Pierre be6c4d6a5d mail kit: fix memory leak. 
CID 896.
 2012-01-02 19:13:28 -05:00
Philippe Saint-Pierre 728d429e7d spamdbm: use the std::nothrow variant of new operator. 2012-01-02 18:55:19 -05:00
Philippe Saint-Pierre d79ded8a44 Mail: various checks of malloc returns + memory leak fix 
CID 891.
 2012-01-02 18:32:38 -05:00
Urias McCullough de9c457a38 Disabled DEBUG=1 in several of the 3rd party ffmpeg subdirs 
Signed-off-by: Matt Madia <[email protected]>
 2012-01-02 17:15:28 -05:00
Urias McCullough f1b76720ea Disable DEBUG build of 3rd party libgutenprint 
Signed-off-by: Matt Madia <[email protected]>
 2012-01-02 17:15:27 -05:00
Philippe Saint-Pierre 0106325bc4 Time preference: Fix a memory leak 
Accidentally introduced with an earlier commit.
 2012-01-02 16:52:52 -05:00
Philippe Saint-Pierre 93f68d97bf ProcessController: fix a small resource leak 
fSettingsFile wasn't deleted in the destructor.  CID 1414.
 2012-01-02 14:55:55 -05:00
Philippe Saint-Pierre 9e4224613c SoundFile.cpp: do a NULL check before deferencing. 
CID 296.
 2012-01-02 14:26:07 -05:00
Philippe Saint-Pierre e9132cc34c Time preferences: use std::nothrow variant of new operator 
Also make sure to avoid an eventual negative array size. CID 10934.
 2012-01-02 13:54:39 -05:00
Philippe Saint-Pierre 9668d19918 echo driver: replace usage of strncpy by strlcpy 
Usage of strncpy in this context could lead to a non null terminated string.
various coding style fix.

CID 2217.
 2012-01-02 13:19:30 -05:00
Matt Madia d1b515136e Fixed typo in the comment of the default mail charset string. 
Spotted by RQ and mentioned on #8147. Thanks!
 2012-01-02 12:44:29 -05:00
Niels Sascha Reedijk c9d16a1694 Update the userguide from i18n.haiku-os.org 2012-01-02 08:17:34 +01:00
Niels Sascha Reedijk 646c788ab6 Update documentation from i18n.haiku-os.org 2012-01-02 08:16:11 +01:00
Philippe Saint-Pierre e480c1b658 echo driver: replace strncpy by strlcpy 
using strncpy could possibly lead to a non null terminated string.
also some coding style fix.

CID 2216.
 2012-01-01 19:42:16 -05:00
Philippe Saint-Pierre 12892428fc cmedia driver: coding style fix 2011-12-31 17:07:30 -05:00
Philippe Saint-Pierre 848762a7d4 firewire: unchecked return of acquire_sem_etc, coding style 2011-12-31 16:41:01 -05:00
Fredrik Holmqvist 9aec8e8424 Remove strlen from PPC glibc as well. 
This should fix the PPC build. Sorry for that, k thx bye.
 2011-12-31 21:32:57 +01:00
Niels Sascha Reedijk ea32b03e6a Update translations from Pootle. 2011-12-31 10:43:40 +01:00
Humdinger c89d69fa89 Added Modern Greek catkeys. Thanks translators. 2011-12-31 08:01:15 +01:00
Humdinger feaa147442 Added GCI student Harsh Vardhan as French translator. 2011-12-31 08:01:14 +01:00
Philippe Saint-Pierre a527d1d5b8 NFS: various checks added if malloc succeeded. (also coding style fix). 2011-12-31 00:14:47 -05:00