i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
69,279 Commits 1 Branch 0 Tags
aac110fbc06525748cf3ad687395c2204f01b654
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Philippe Saint-Pierre dfcbef64f6 Erratum hrev49359: Compare size with 0 rather that B_OK 
Thanks Ingo!
 2015-07-04 14:11:34 -04:00
Philippe Saint-Pierre 76a1eb689c userlandfs: Fix access mask check 
CID 1255052 and CID 1255053
 2015-07-03 16:14:09 -04:00
Philippe Saint-Pierre 189c10b089 Tracker: check result of FlattenedSize() for error 2015-07-03 14:48:40 -04:00
Philippe Saint-Pierre a495c5e69a NetBuffer: Check result of FlattenedSize() for error 
CID 610923
 2015-07-03 14:31:57 -04:00
Philippe Saint-Pierre 5889eb7c47 PDF Printer: Check FlattenedSize() result for error 
CID 610903
 2015-07-03 14:27:31 -04:00
Philippe Saint-Pierre bd97c88ac3 Deskbar: check dynamic_cast results 
CID 1108236 and CID 1108237
 2015-07-03 14:14:57 -04:00
Philippe Saint-Pierre f6662e3233 mail_daemon DeskbarView: init fLastButtons 
CID 610256
 2015-07-03 13:55:58 -04:00
Philippe Saint-Pierre e04f294fe8 GopherRequest: fixes for null dereference 
CID 1249920
 2015-07-03 13:35:08 -04:00
Philippe Saint-Pierre be61575ce6 Cortex: fix for possible null-dereference 
CID 600442
 2015-07-03 13:14:37 -04:00
Philippe Saint-Pierre 8108282b32 jpeg translator: exif_parser: Missing break statement 
CID 1273786 and CID 1273787
 2015-07-03 11:32:45 -04:00
Philippe Saint-Pierre 03c41782bb agg: avoid writting beyond the array size 
Potentially trying to add two new items to an array without enough room left.

CID 991455
 2015-07-03 11:32:45 -04:00
Philippe Saint-Pierre 217e35d624 FindPanel: Reorder operations to avoid leak 
CID 1234656
 2015-07-03 11:32:44 -04:00
Philippe Saint-Pierre ce3124335f package_daemon::FSTransaction: Init fIsFinished 
CID 1108429.
 2015-07-02 21:41:31 -04:00
Philippe Saint-Pierre e8f7b0e586 HaikuDepot: TextChangingEvent: Init fIsCanceled 
CID 1162815 and 1162816.
 2015-07-02 21:41:30 -04:00
Philippe Saint-Pierre 060bd5ebb9 Tracker::BTitleView, Init fPreviousLeftClickTime 
CID 1273731
 2015-07-02 16:12:34 -04:00
Philippe Saint-Pierre 39ceaa9c28 eject: close file description after usage 
Also reindent the switch statement. CID 702040.
 2015-07-02 16:12:34 -04:00
Philippe Saint-Pierre e2a8ef11f6 CID 702036: catattr: close file descriptor after usage 2015-07-02 16:12:33 -04:00
Philippe Saint-Pierre bb4ab4336d Matrox accelerant: assignation to B_OK -> condition never true. 
Assignation to B_OK in if condition means it will never be true. Replace with ==.

CID 991072, 991155 and 604410.
 2015-07-02 16:12:33 -04:00
Philippe Saint-Pierre 11f43ff1d7 Cortex: fix copy and paste error 
Comparing a format with byte_order and the context indicates a copy and paste error.

CID 991144
 2015-07-02 16:12:33 -04:00
Philippe Saint-Pierre cdec47c927 Workaround timing issues in Chart 
When run on a VM (VBox, vmware), the timing calculations done were giving weird
results (< 1ms), messing with the logic (div by zero introduced).

Should take care of ticket #89.
 2015-07-02 16:12:32 -04:00
Philippe Saint-Pierre 02ab820d0e Backgrounds: FlattenedSize() can be negative (error status) 
CID 610928.
 2015-07-01 22:18:11 -04:00
Philippe Saint-Pierre 24b1f931b3 LongAndDragTrackingFilter: Unitialized member 
CID 611005
 2015-07-01 22:01:57 -04:00
Philippe Saint-Pierre 8d449661ca CID 743867: Memleak in DiskUsage 2015-07-01 21:42:16 -04:00
Philippe Saint-Pierre 494fe5a431 CID 1273484: Use bitwise operator to verify bitmask 2015-07-01 21:26:00 -04:00
Philippe Saint-Pierre f4a699af83 CID 1273539: Use right variable in construction check 2015-07-01 21:19:12 -04:00
Philippe Saint-Pierre ee056a089c match new[] operator with delete[] operator 
The string ends up being deleted with the [] variant later on.

CID 602975.
 2015-07-01 20:34:57 -04:00
Philippe Saint-Pierre 93bd491fb7 Logic error in TaskLoop::RunIfNeeded() 
The ! operator would have priority over < and would transform currentTime before the
comparison. Moreso, the logic was reversed. It is supposed to return false if it's
not time yet to run the task, not the opposite.

CID 1273447.
 2015-07-01 19:32:55 -04:00
Philippe Saint-Pierre 2bdea08d38 Check for malloc result done on wrong variable. 
CID 1255090
 2015-07-01 19:32:55 -04:00
Philippe Saint-Pierre ee1265c58e Memleak in HPDirectJet printer transport 
CID 605747
 2015-07-01 19:32:54 -04:00
Philippe Saint-Pierre 385d90724e Memory leaks in Cortex 
CID 605755, 605756, 605757 and 605758.
 2015-07-01 19:32:54 -04:00
Philippe Saint-Pierre 45888dab83 Crash fix in BMessage::ReplaceData() 
The call to _CopyForWrite() invalidated the pointer previously assigned.
There was also an unrelated null-pointer derefence situation in the copy constructor.

Fixes #3074 and CID 610886 and CID 610887.
 2015-07-01 15:16:31 -04:00
Philippe Saint-Pierre 4cb7d0e75f AboutWindow: Set initial font color in the TextView 2015-07-01 15:16:30 -04:00
Philippe Saint-Pierre e62d9cf8c5 StyledEdit: Rework of the font color system 
1) The default font color is now B_DOCUMENT_TEXT_COLOR
2) The font color menu now shows a palette
3) The font color menu now includes a "default" item, set
to B_DOCUMENT_TEXT_COLOR
4) Added a Todo mentionning it would be ideal to not save the default color
itself, but instead saving the fact the default color was used. Maybe allow the
StyleBuffer to use a Null color or something similar.
 2015-06-30 13:32:45 -04:00
Philippe Saint-Pierre 8083e779cf Use B_CONTROL_HIGHLIGHT_COLOR to draw outline 
In Tracker's TitleView, use an user defined color to draw outline when
moving columns rather than hardcoded color.
 2015-06-30 13:32:44 -04:00
Philippe Saint-Pierre ffc3c6172b Incorrect font applied in Add-on submenu 
When accessing the Tracker Add-on menu from ContainerWindow's top menu, the
font in Add-Ons submenu would change from its parent menu.
 2015-06-29 11:27:50 -04:00
Philippe Saint-Pierre ee87fbc421 Do not hardcode tab height in ResizeToFit() 2015-06-28 19:02:30 -04:00
Philippe Saint-Pierre 2b0dad2c7e Fix segfault in Top utility 
Could occur whenever the terminal exceed 96 columns (write beyond end of string).
 2015-06-25 22:35:06 -04:00
Philippe Saint-Pierre 1443b2798f CID 1249930: Don't scanf uninitialized buffer 
Would happen in case of a missing config file, for instance.
 2015-06-25 19:29:13 -04:00
Philippe Saint-Pierre 6b05e9db3d CID 1273486: change from boolean to bitwise operator 
Typo confirmed by looking at the corresponding source file from elsewhere.
+ some style fixes
 2015-06-25 18:03:41 -04:00
Philippe Saint-Pierre c5666be3b8 CID 605799: Resource Leakage in fortune 2015-06-25 18:03:41 -04:00
Philippe Saint-Pierre 94817d608d Coding style fixes 2015-06-25 18:03:41 -04:00
Philippe Saint-Pierre f0b2d33bcf CID 1273599: null dereference in SATGroup 
And some additional style fixes.
 2015-06-24 18:58:28 -04:00
Philippe Saint-Pierre e3e5e00627 CID 991517: Resource Leak in PackageInfo::Parse() 2015-06-24 16:26:11 -04:00
Philippe Saint-Pierre 478d9536a6 Icon outline setting was ignored if no background image found 
Might have been the cause behind #10019.
 2014-08-01 18:09:30 -04:00
Philippe Saint-Pierre c4f80d1ee8 CID 1108469: Use after free 2014-07-15 16:11:51 -04:00
Philippe Saint-Pierre eda1d21fde CID 991761: potential double close (and white space fix) 2014-07-15 15:34:36 -04:00
Philippe Saint-Pierre 37b6c4337c CID 1162772: Missing break (and typos fixed) 2014-07-15 14:46:27 -04:00
Philippe Saint-Pierre fcd2bfb773 Style fix, no functional changes 
Thanks Axel!
 2014-07-15 14:06:49 -04:00
Philippe Saint-Pierre 384eec8fb3 Ticket #3385: inconsistencies when single window + disks icon 
When using the Show Disks icon option, single window navigaton mode,
and starting navigation by the Disks icon, these bugs would occurs
upon entering child poses :

*) The draggable icon at the top right wouldn't appear
*) The file menu wouldn't update properly (for example, the New folder
menu item won't show)

Based in part on dru_ed's patch.
 2014-07-14 21:16:35 -04:00
Philippe Saint-Pierre 5ef28aaa4f FileTypes: make button placement more consistent 
Place Cancel button on left rather than on right in the add
extensions popup. Also add glue to make it more similar to the other
popup windows of the preflet.
 2014-06-22 14:12:02 -04:00
Philippe Saint-Pierre 98e26ff242 Hey: more style fixes, no functionnal changes intended 2014-03-10 22:15:36 -04:00
Philippe Saint-Pierre 1166849963 Hey: use delete[] instead of free (CID #990947 and CID #990948) 2014-03-08 13:34:44 -05:00
Philippe Saint-Pierre 6fef592d6b Hey: Style fixes, code clean up 
No functional changes intended
 2014-03-08 13:31:29 -05:00
Philippe Saint-Pierre ff5711ee19 LaunchBox: Add missing curly brackets (CID #991345) 2014-03-02 17:00:36 -05:00
Philippe Saint-Pierre c08eb212ef Radeon accelerant: typo in vertical limit check (CID #991138) 2014-02-27 22:01:34 -05:00
Philippe Saint-Pierre 3d5ede23c2 Wrong variable used in null-check (CID #1108197) 2014-02-27 21:40:15 -05:00
Philippe Saint-Pierre 75a80fb341 Use delete[] on array (CID #701816) 2014-02-25 21:31:08 -05:00
Philippe Saint-Pierre 6e536502db Fix missing break statement (CID #1108253) 2014-02-25 21:04:38 -05:00
Philippe Saint-Pierre 96cb5c35a3 fix #9982: make installer quit when alt+w in eula window 2013-10-16 20:43:47 -04:00
Philippe Saint-Pierre abfe23dcf3 It now also uses the shared TranslatorSettings class, and localise its name 
to be used in DataTranslations preflet.
 2013-10-14 21:17:42 -04:00
Philippe Saint-Pierre ba03d61b4f DeskBar: use the prepared transparent icon when necessary 
In the odd case where there is no icon for an app, and the generic
3 boxes icon is also unavailable/removed, Deskbar now properly draws
the transparent icon that was prepared, but not used (and leaked).
 2013-08-02 21:04:57 -04:00
Philippe Saint-Pierre 0e95ac1797 CPUFreq: rewrite interpolation formula - division by zero (#9872) 2013-07-18 22:27:27 -04:00
Philippe Saint-Pierre d087b9ca15 CPUFreq: use transparent background when used as replicant 2013-07-18 20:54:50 -04:00
Philippe Saint-Pierre f74ad62fd4 ICNS translator: use delete [] where new [] was used 2013-07-17 17:08:28 -04:00
Philippe Saint-Pierre a71f2ed86a TrackerReader: style fixes, no functional changes intended 2013-07-17 16:58:41 -04:00
Philippe Saint-Pierre cd15d8c3d0 Style fix, no functional change intended 2013-07-17 13:38:46 -04:00
Philippe Saint-Pierre 68aca9a477 Message screensaver: memory leak fix - CID 601698 2013-07-17 13:25:42 -04:00
Philippe Saint-Pierre fa30ef5640 Message screensaver: close pipe with pclose - CID 990944 2013-07-17 13:06:10 -04:00
Philippe Saint-Pierre f293052d9f Style fix, no functional change intended 2013-07-17 12:44:40 -04:00
Philippe Saint-Pierre be064b5af3 virtio_pci.cpp: check for (un)supported hardware never fit 
CID #1032255
 2013-07-17 12:15:24 -04:00
Philippe Saint-Pierre da1f251a8f DiskUsage: drawing artefact in TabView 2013-07-17 12:01:26 -04:00
Philippe Saint-Pierre 4ba4d40bb2 Addons shortcuts: fix override 
Under some specific circumstances (changing the key and the modifier in a specific way
at the same time), Tracker would get confused and not change the shortcut.

Thanks Diver
 2013-07-13 16:57:40 -04:00
Philippe Saint-Pierre 073218a8ae Mail kit: use KiB unit (and localize) 2013-07-13 14:55:20 -04:00
Philippe Saint-Pierre fffc0e2a7b DiskUsage: reuse string_for_size in libshared.a 2013-07-13 14:19:09 -04:00
Philippe Saint-Pierre 3fe416173c Tracker add-on shortcuts, move resource to BEOS: namespace 2013-07-13 14:19:09 -04:00
Philippe Saint-Pierre 1cac1bebcb ActivityMonitor: use new units KiB/MiB for display (#5378) 2013-07-13 14:19:08 -04:00
Philippe Saint-Pierre 8f9c2223a3 Shortcut catcher: crash fix, better monitoring of setting file 
* Fix bad memory cleaning I introduced in earlier commit, causing crash in add-on
* Upon detecting the deletion of setting file, shortcuts weren't properly removed
* The node monitoring would not filter the right file on every case

Thanks Diver.
 2013-07-12 15:35:59 -04:00
Philippe Saint-Pierre 29cfb63041 Regression fix in Tracker 
A delay on Tracker quit request was wrongly introduced
(via reboot, or hey Tracker quit, for example)
 2013-07-11 15:47:35 -04:00
Philippe Saint-Pierre d058a4aed2 Tracker: store default add-ons shortcuts in resource 
* Default shortcuts for add-ons are now stored within the binary as a resource
(it was previously appended to the file name, as Open Terminal-T, for example)
* Use ~/config/shortcuts_settings to override those default shortcuts
(editable with Shortcuts preflet)
* Tracker avoid rescanning the add-ons directories when unnecessary
* Monitor the shortcuts_settings to apply changes on the fly
* Fallback to default shortcuts whenever appropriate (settings file deleted, etc.)
* Should fix #4446 (with resource rather than attributes)
 2013-07-11 12:38:41 -04:00
Philippe Saint-Pierre 41e6527c1f Tracker addons: strip shortcut from name, instead use resource 2013-07-11 12:38:41 -04:00
Philippe Saint-Pierre 1412a36abc Shortcut add-on: change to accomodate tracker add-ons 
* Ignore shortcuts regardings tracker add-ons. Its settings file is now shared
with Tracker, and those are now handled by Tracker.
* Use a BPathMonitor as specified in a TODO to check the presence and changes on
the settings file. (#6278)
* Use a message to ask Tracker to launch/open folders as specified in TODO
 2013-07-11 12:38:41 -04:00
Philippe Saint-Pierre 56ea7a1e19 Rename Tracker add-ons to remove shortcut suffix 2013-07-11 12:38:40 -04:00
Philippe Saint-Pierre 0ebfc3e032 Tracker: remove superflous separator item in ContextMenu #6997 2013-06-23 16:05:12 -04:00
Philippe Saint-Pierre 89d2bf3aa7 People: allocate BFile on stack 2013-06-23 13:46:42 -04:00
Philippe Saint-Pierre a09c983cc6 People: open files in READ_WRITE mode only when necessary. (#5791) 2013-06-22 19:46:40 -04:00
Philippe Saint-Pierre 3f0a22c88b Chart Demo: Fix for failure to detect already opened popup windows 
Clicking on the FPS, color chart or any other buttons meant to make a popup
window appear was failing to detect and re-focus an already opened popup.
 2013-04-21 20:51:02 -04:00
Philippe Saint-Pierre 2e6221ff11 Tracker: Replace usage of ceil by ceilf 2013-01-27 14:24:52 -05:00
Philippe Saint-Pierre a74c82b977 Tracker: Drawing issues in dragBitmap (#8005) 
Remove rounding issues in height calculation leading to drawing issues when using some font sizes.
 2012-12-25 16:28:18 -05:00
Philippe Saint-Pierre 9abf41a7fe Mail: remove un-intended debugging code committed 2012-12-25 14:43:02 -05:00
Philippe Saint-Pierre 5eea8a566d Mail: coding styles fixes. should have no functional changes 2012-12-25 14:13:02 -05:00
Philippe Saint-Pierre 205cf6950c Tracker: Force Identify - don't require holding shift (#4857) 
Don't require to hold shift when clicking on force identify,
can now be released after popup menu have appeared.
 2012-12-24 16:10:21 -05:00
Philippe Saint-Pierre 3fbf5d6809 Tracker: Drawing artifact (#6513) 
After switching from outline only selection mode to transparent rectangle,
a drawing artifact could occur because the last selection rectangle wasn't
reset properly.  On following update, Tracker thought a selection rectangle
was still to be shown.
 2012-12-23 16:33:49 -05:00
Philippe Saint-Pierre 8a24526e3f LaunchBox: remove redundant Locking. Thanks Stippi! 2012-12-13 19:38:08 -05:00
Philippe Saint-Pierre 4b84a0b5c8 Mail: don't require a subject to save a draft (#9218) 
Also :
 * if the body of message changes, ask to save draft when closing window
 * disable save button when successfully saving draft
 2012-12-12 23:10:02 -05:00
Philippe Saint-Pierre 53b234eb1c Mail: Reworking of the unique filename discovery (drafts) 2012-12-12 21:49:20 -05:00
Philippe Saint-Pierre 55ef15c45a Mail: use B_FILE_NAME_LENGTH as limit when saving drafts 2012-12-12 19:41:57 -05:00
Philippe Saint-Pierre 4d6bb87ea7 LaunchBox: finish saving settings before closing the window (#6347) 2012-12-12 18:05:18 -05:00
Philippe Saint-Pierre b25611eac0 FileTypes: Localize Attribute List Views (types and display) #7321. 2012-11-26 21:45:34 -05:00
Philippe Saint-Pierre aa18b83504 udf kernel add-on: memory leak fix (CID 743820). 2012-11-26 20:59:28 -05:00
Philippe Saint-Pierre 6fc6cc0c57 Canna: incorrect strlen calculation (CID 602178). 2012-11-26 20:03:50 -05:00