Fixes infinite loop when loading empty wifi_networks file, and incorrect
fields format when saving.
Change-Id: I269e6176df8d81fb113795b40763cc3ef7afb1ab
Some systems need embedded controller access during their _INIs,
so we need to use the ECDT to initialize the embedded controller
during ACPI init.
Since we can now initialize the EC during ACPI module init, we can't go through
the ACPI module anymore, and instead call its functions directly
This should fix
"KERN: ACPI Error: Region EmbeddedControl (ID=3) has no handler"
seen in a few ACPI-related tickets, including:
#19602, #19407, #18864
Change-Id: Ia648ee8036b68416ed1ca1c51dd1daea6a6a6964
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11058
Reviewed-by: Fredrik Holmqvist <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
When the application starts, it asks the user if they are
OK to send anonymous stats to count how many times a
package is viewed. This defaults to Yes but this change
will swap that so that it defaults to No.
Change-Id: I15a165f9352ccd5d7901fc8ef874cb3ab1d0b9f4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11048
Haiku-Format: Haiku-format Bot <[email protected]>
Reviewed-by: nephele nephele <[email protected]>
Tested-by: Commit checker robot <[email protected]>
should avoid instruction reorder seen on #20100,
could lead to pinning happening after getting the cpu
_ZL15call_single_cpujPFvPviES_b before:
mov 0x90(%rbx),%rax
addl $0x1,0xa8(%rbx)
_ZL15call_single_cpujPFvPviES_b after:
addl $0x1,0xa8(%rbx)
mov 0x90(%rbx),%rax
Change-Id: I7759c5e086856a190aac21270601ae55c0b39fac
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11050
Haiku-Format: Haiku-format Bot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
This provides more intuitive behavior when writing drivers: a hook that
does nothing and returns an error should be the same as not setting the
hook at all.
Also, it allows the hook to fail only on some cursors (for example if
there are size or colorspace limitations in what the driver/hardware
can handle).
Change-Id: Ia7b8c7f61c1a5af3214653bb05d9568b1bba1147
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11030
Tested-by: Commit checker robot <[email protected]>
Haiku-Format: Haiku-format Bot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
If you've searched for some very long string, the menu item label
in the "History" may get so long, it stretches wider than the
screen width. Happened to me accidentally…
Truncating labels at a fixed width with middle truncation.
Change-Id: I10d457044ad67563efd59960af5093d2c8717b85
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11028
Reviewed-by: Adrien Destugues <[email protected]>
Reviewed-by: humdinger humdinger <[email protected]>
Haiku-Format: Haiku-format Bot <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: nephele nephele <[email protected]>
When you have many fonts installed, the "Font" menu in the menu bar
gets very tall. If you just want to set the style (italic, bold etc…)
or the colour of the selected text, you always have to scroll to the
very top.
Putting all fonts into a "Font" top-menu leaves the the styling actions
always accessible in the renamed "Style" menu.
Also, put the "In/Decrease size" items under "Size", similar to e.g.
Tracker's "Icon view".
Fixes#20098
Change-Id: Idadcf902b1b97fe439a4958e995722e9d76f804f
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10986
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: nephele nephele <[email protected]>
This commit will tidy up the package list views'
tab handling so that the model is always a
correct representation of the chosen list view.
The commit also sorts out a problem where the
BView focus can be stuck on the wrong view when
the tab changes.
Fixes#20109
Change-Id: I1f2769481cf3d89d160002e12092ff50df997077
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11014
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Andrew Lindesay <[email protected]>
Haiku current has a "Save as PDF" printer queue, but that does not make
sense becuase the PDF Writer driver does not ship with Haiku (it's in
haikuports). This causes confusion for the users.
I will update the haikuports PDFWriter package to create the queue on install.
Fixes#20110.
Change-Id: I19edc41e5481f2de6f19fad1b63a2f9e3f0a03de
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11029
Haiku-Format: Haiku-format Bot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
This makes the New Tab and tab buttons hidpi supporting
and fixes the close menu for the search bar
All of these controls now properly support the dark mode
Change-Id: Ibd2b86b9c1c1e1f812ea946627cbff007b32b452
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11023
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: nephele nephele <[email protected]>
Haiku-Format: Haiku-format Bot <[email protected]>
* Drop screen_configuration::is_current. This just caused significant
confusion and problems, because values could get out of sync between
the Stored and Current screen configuration storage.
* Try to match by monitor_info always, not just ID.
* Add the current vs. stored Configurations distinction to VirtualScreen.
This will populate the CurrentScreenConfiguration object during
initial configuration of screens.
Fixes app_server not properly reverting to the original resolution after
apps that change the resolution quitting, which was seen in #20042.
Change-Id: I61c9ee4c5b7e755cbb207170d2eddb1d31fd0ea8
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11024
Reviewed-by: waddlesplash <[email protected]>
It's possible for the EC to disable burst mode (maybe because
we're taking too long and it's impatient) before we check
the status register to see if burst mode is enabled. If that
happens, we consider the burst enable command to have failed,
even though it succeeded and put EC_BURST_ACK in the data register.
So, the next time we read the data register for a subsequent
command, we'll read that EC_BURST_ACK.
This fixes ACPI battery & shutdown on 2015 MacBook Pro
Change-Id: I49711b224fee027e28825674d9c845bf6a6a6964
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11019
Reviewed-by: Fredrik Holmqvist <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
They may contain separators or other syntactic elements that would be
interpreted when unquoted.
Reported by @PolloBlu in the forums as the reason for their not
automatically connecting to an SSID with spaces in its name.
Change-Id: I19e88121a8d6dab9a722807971bcc7872578037d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11026
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
This was already 1) broken in webkit 2) removed in registrar
This will now also cause WebPositive to hand off gopher urls to a more
apropriate app instead of giving it to webkit and getting an error back
because it is unsupported
Change-Id: I5253eaf8f8bfe3c0971895c6df6fa03b9fc4e237
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11021
Reviewed-by: waddlesplash <[email protected]>
On some Intel MacBooks, system firmware configures the framebuffer
as X-tiled and uses the "Graphics Memory Fence Table Register"s to
transparently convert linear framebuffer accesses by the CPU to tiled
accesses. If you change the framebuffer base address or stride, you get
a garbled display since the "fence" configuration no longer matches
the framebuffer.
Might fix#17688
Change-Id: Iaf9ea7641f7809acb9b8fbf14b88ed656a6a6964
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11016
Reviewed-by: Adrien Destugues <[email protected]>
This reverts dbc6b2061e.
Hopefully after the various fixes to APIC timer setup, the
problems that this was causing will be gone. (The users who
reported issues with it did so only on the forums and never
opened tickets, it seems.)
We should just be zeroing any unknown bits, not trying to preserve them.
If the BIOS or other mechanisms left the timer in some other mode
besides "one-shot" like we need, then we might incorrectly preserve
those bits.
This also has the advantage of avoiding config reads in set_hardware_timer.
Even on a single-core software-emulation QEMU VM, we acquire more
than 10k spinlocks per second (sometimes even over 100k.) That makes
sense, as every syscall entry, mutex acquisition (even uncontended,
for KDEBUG kernels), etc. acquires a spinlock. So, reasonably, this
list will always be too small to detect much of anything at this point.
If we need a similar debugging facility, we should store addresses
or thread IDs in the lock structure. That will require a more significant
refactor to locking code, however, and it doesn't seem necessary at this
time, so I haven't implemented that (yet).
* Get rid of the global sUserTimerLock. This was added in 2013
to prepare for the removal of the global scheduler lock, which
is what all these routines previously used. The locking design
was never redesigned since then to accomodate for the changes,
it appears.
* Make CPU timers always locked by time_lock, and the system-time
timers locked by a local lock.
* Make fScheduled load-bearing as to whether the timer is presently
in the team/thread lists or not.
* Don't re-fetch the team/thread every wait cycle. This allows us
to avoid a lock/unlock dance that would otherwise complicate
the scheduling logic significantly.
Tested using the old version of the Open POSIX Testsuite (which
indeed caught some bugs in earlier versions of this patch.) All
12 timer_create tests still pass, including the ones that depend on
timers firing within the right timeframe.
Fixes#20090.
Change-Id: I54dd9a49e72f51711baa0fbf18e5c35a7fafec8f
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11007
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
- Add more secondary CPU startup methods:
PSCI using EL3 secure monitor calls (used on most ARM64 CPUs)
Spin tables (used on Apple CPUs, which lack EL3)
- Secondary startup code was rewritten to pass all needed info
to secondaries using static variables, since we can't
pass any info to secondaries when using spin tables
- Setup MMU state to known good values as early as possible
instead of relying on the values set by the bootloader.
This also requires generating new page tables, since we're
(potentially) changing MAIR as well as the address space sizes
(which determine the number of page table levels we need)
Change-Id: I3b90aab04090fa0c6a8ad82a01df7fee6a6a6964
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10984
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
Máximo Castañeda