* The flag should be set when they are different, not equal
* Memcmp returns 0 when all count bytes are equal
Change-Id: Ie0440b6159410f811e2b57dc48308a2b2d2ee4f4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11246
Reviewed-by: waddlesplash <[email protected]>
This reverts commit 5b81e2470e. It seems to need more work on other parts of the driver.
Reason for revert: #20171, No output/input settings in Media preferences for HD Audio after update to hrev59825
Change-Id: I44495413f63b4b40e51563e03e20d0cf372e2c8a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11244
Reviewed-by: Jérôme Duval <[email protected]>
Tested-by: Commit checker robot <[email protected]>
This reverts a small portion of f5842905e3.
I added these asserts instead of the deletions to hedge against
the Team/Thread reaching this point with timers still active.
But it seems that doesn't happen, while if thread init fails
due to OOM, we have the default timers still present, which need
to be deleted.
Fixes#20154 and #20148.
* Retrieve info from the stored configuration in GetScreenMode &
GetScreenFrame if needed.
* Use the stored configurations in _SetCurrentWorkspaceConfiguration.
The last part seems to fix#20136.
Otherwise we could block forever if the data size is
larger than the buffer size. Partial writes are an
expected behavior of stream sockets, so this should
not cause any other problems.
Fixes#20163.
We were passing our own fs_vnode, not the underlying filesystem's.
I guess this was just never tested, because it would've always crashed?
Fixes#20156.
Fixes regression introduced in c216360337
where the framebuffer info passed to the kernel came from
whatever video mode was highest numbered, rather than what
was actually selected.
Should fix#20161
Change-Id: I06c800bd8e941ed7f6b20998c1ff66cd6a6a6964
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11197
Reviewed-by: waddlesplash <[email protected]>
Vector icons by ZuMi, thanks!
Expand the sniffing size up to 8k, as the zip file content layout can be very variable.
Now it works with all the available samples Microsoft Office 2007+ files I can put my hands on.
Change-Id: I806a66dd3d29bb47693759ef2270b482a8d7cd69
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11182
Reviewed-by: Adrien Destugues <[email protected]>
Tested-by: Commit checker robot <[email protected]>
* The GUI strings in the Devices app were inconsistent case-wise.
Going for all sentence casing. "None" and "Unknown" look better
as lower case, which is normally used elsewhere in Haiku.
* Workspaces usage:
- "movement" is a bit coprolitic IMO. Let's go with "direction"
instead.
- "autoraise" depends on the position near the screen edge of the
mouse pointer, not the window itself. The text could be even
more precise, but we should try to be brief.
- The "+|-" switch fits better to the "workspace" parameter, as it
increases the workspace number, instead of a "movement" or
"direction".
- Fixed direction "top" to "up".
Change-Id: If26d2b1e0596e911fea06609c44fccff2086ca8d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11170
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
* Don't unlock in ContainerWindow's constructor; instead leave
the BWindow locked, as the BWindow constructor itself does.
* Call Run() at the end of TFilePanel's constructor. This way,
the TFilePanel will be in the state existing applications expect
it to be after the constructor runs (i.e. running and not locked),
while also performing all necessary initialization before actually
doing that, to avoid races.
* Drop TFilePanel::Show as it's not needed now.
* Revert changes to BFilePanel::Show as they're now not neede.
I retested #19499 with this change, and couldn't get it to reproduce
(while it reproduced easily with Run() called at the top of TFilePanel()
followed by the Lock/Unlock scheme.)
This should be a much simpler solution that hopefully will cause no
regressions in any of #19499, #20125, #20128, #20131, #20144.
A comment in the header says the cursor handling functions "do their
own Read/Write locking", but they didn't actually lock the framebuffer.
Should fix#20141 and #2539.
This should fix runtime_loader "cannot open file" errors logged into syslog because every
standard locations were attempted without checking for actual existance of a file to
attempt to open.
There messages were misleading users about their criticity.
Change-Id: I621b122a4eee1cc7ad2ff1c03f5146809657e7d4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11175
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
* Ensure memory is locked before doing virtual->physical translation.
* Make sure get_memory_map_etc actually returned an entry.
I didn't see either of these trip in some basic testing though.
This change will cause HaikuDepot to communicate
with the server on start-up to obtain runtime
information.
Included in the information is the server's
current timestamp. This allows the client to then
validate there is not too much drift between the
server and the client.
The primary driver for this change is to pickup
the future transition from the server allowing
nickname+password authentication over to only
supporting SSO. Once the server no longer supports
nickname+password auth then the UI can disable it
and the users of the legacy HaikuDepot versions
can nevertheless continue to use the rest of the
application OK.
Change-Id: I203102c2266f67115f4b0290f1909346701f79e4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11047
Reviewed-by: Andrew Lindesay <[email protected]>
Tested-by: Commit checker robot <[email protected]>
* Properly handle copy-on-write in the case of consumers, same as
set_area_protection. This seems to fix most of the remaining problems
in boehm-gc's mprotect-VDB.
* Do not call set_area_protection if the whole range is covered,
as it tries to acquire address space locks, which can lead to
deadlocks: that was the cause of #20138. Instead, handle changing
the protection of all pages in here.
* Don't unmap pages of lower caches; just don't allow writing to
those pages. This allows us to avoid unlocking the translation map,
and also should mean a lot fewer page faults, hopefully improving
performance.
Fixes#20138.
This would underestimate the number of pages needed to map an address
range resulting in too-small page table page reservations, causing a crash
Change-Id: I34513621b36ecd60de71e128912950b66a6a6964
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11129
Haiku-Format: Haiku-format Bot <[email protected]>
Reviewed-by: waddlesplash <[email protected]>
Tested-by: Commit checker robot <[email protected]>
Alexander von Gluck IV