Commit Graph
8 Commits
Author SHA1 Message Date
Alexander G. M. Smith e9c3e80c58 Clarify .PackageInfo user creation arguments.
Change-Id: I4f0ea6da53d4793a5128324af2b99d460b67b523
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2576
Reviewed-by: waddlesplash <[email protected]>
2020-05-09 20:20:19 +00:00
Alexander G. M. Smith 31d70c106b package kit: Skip over future package attributes.
Ignore unknown fields (also called attributes) which are from a package
file with a different minor version number.  Previously it would halt
with an error when encountering such a field, even though it can safely
be skipped over (if it was unsafe, we would have incremented the major
version number).

The use case is a future package attribute for pre-uninstall scripts.
If they're not run, that just leaves some debris after uninstalling
(like symbolic link desktop icons).

* Use the B_NOT_SUPPORTED error code when reading unknown package
  attributes.  Don't treat it as an error if the package is a
  different minor version, just skip it.
* Print unknown package attribute index numbers rather than stopping,
  since they may be from future package file formats and can be safely
  skipped otherwise.  Mention the relevant enum so you can find it in
  the source code.  It's a pity that the previous abstraction layer
  isn't present, since it tells us what data type the attribute is
  (string, number, etc), so we could have printed its value too.

First step of two for enhancement #13427

See https://review.haiku-os.org/c/haiku/+/1504 to generate packages
with a different minor version number (second step of the enhancement).

Change-Id: I6db1897824a1713b3d5fab6fdfb990ee5923cd52
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1714
Reviewed-by: waddlesplash <[email protected]>
2019-08-14 02:08:35 +00:00
Alexander G. M. Smith 78b0cfc712 Remove debug printf from BListView.
Change-Id: Ic3f3359305e066c27bfb071cc18a455d6f1c179f
Reviewed-on: https://review.haiku-os.org/648
Reviewed-by: waddlesplash <[email protected]>
2018-10-30 22:46:08 +00:00
Alexander G. M. Smith f12d3b3477 Update BListItem::SetHeight() docs with selection box warning.
The cached top coordinate of each BListItem isn't updated when you
change the height of the item, leading to confusing highlighting and
incorrect mouse clicks.  Rather than fixing it, this just documents a
workaround or two to force an update of the cached coordinates.
2018-02-17 00:26:34 +00:00
Alexander G. M. Smith 5e7964b0a9 Remove Spurious B_BEOS_DATA_DIRECTORY
There is no DATA directory in BeOS, and its FindDir() doesn't implement
it.  No need for a confusing backwards compatibility to something that
doesn't exist (had my hopes up, was going to move some non-executable
files from AddOns to Data in a program that works in BeOS and Haiku).

The removed enum label doesn't change the directory_which enum order
or count, as it was aliasing the value of another existing enum label
(B_SYSTEM_DATA_DIRECTORY).

Fixes #13470

Signed-off-by: Axel Dörfler <[email protected]>
2017-05-08 22:17:53 +02:00
Alexander G. M. Smith f765016ffd mail: Detect terminal input, end of file, better argument parsing.
* If the input is a terminal rather than a file or pipe, only then look
  for the single period on a line as end of text.  Also look for end of
  file as an end of the text, so that piped in text works.
* Parse multiple e-mail addresses properly, adding a comma between them
  (a space doesn't work).  Also allow mixing of "to" e-mail addresses
  and command line switches, previously all "to" addresses had to be
  at the end.
* Fewer blank lines in the output, make it look nicer, remove things
  like a redundant display of the body text before text was read.  Also
  no output text when just piping in a message.
* Avoid buffer overrun by using fgets instead of gets.
* Use stderr for text the user likely doesn't want to save, and for
  prompts that would be invisible if stdout was redirected to a file.

Signed-off-by: Augustin Cavalier <[email protected]>
2016-03-02 22:11:15 -05:00
Alexander G. M. Smith 143edb7460 docs: makefile-engine: add missing HTML tags.
Fixes #12063.

Signed-off-by: Augustin Cavalier <[email protected]>
2015-06-01 18:28:17 -04:00
Alexander G. M. Smith 88f9012805 BMessage: fix an off-by-one error in SetCurrentSpecifier.
You could set the index to be past the end of the Specifier array.

Signed-off-by: Augustin Cavalier <[email protected]>
Fixes #12087.
2015-06-01 18:26:47 -04:00