Commit Graph
100 Commits
Author SHA1 Message Date
Philippe Saint-Pierre 00e081a1ec Fix coding style violation 2011-11-28 13:00:43 -05:00
Philippe Saint-Pierre 04847eccdf Fix style coding violation (possibly causing confusion) 2011-11-28 12:58:31 -05:00
Philippe Saint-Pierre f6bd30f2af Partitioning system: avoid leakage of resource
The storage returned from GetSession() was leaked

CID 10827
2011-11-27 23:35:36 -05:00
Philippe Saint-Pierre 342169dfe2 Fix resource leakage
CID 10828
2011-11-27 23:24:18 -05:00
Philippe Saint-Pierre 9f66f05b58 Fix never met condition
(descriptor & 0x10)==1 could never be met, it would return 0x10 or 0x00

CID 2567
2011-11-27 18:42:17 -05:00
Philippe Saint-Pierre 4d5d809045 No functional changes. Improve readability.
Thanks Axel!
2011-11-27 18:13:13 -05:00
Philippe Saint-Pierre ec9e2f9018 No functional change, avoid confusion in Coverity about exceptions
CID 9248, CID 9250, CID 10844, CID 10977, CID 10978, CID 10979, CID 10980,
CID 10981, CID 10982, CID 10983
2011-11-27 17:47:45 -05:00
Philippe Saint-Pierre 8e844f63e9 Fix bogus argument validation
* The comparaison couldn't ever not match. Based on the comment above the
  function, I made it so that flags must contain at least one of B_WATCH_NAME,
  B_WATCH_STAT or B_WATCH_ATTR

CID 2586
2011-11-27 13:24:43 -05:00
Philippe Saint-Pierre b21c95d4f6 Move NULL check before dereference tries
CID 5912
2011-11-27 12:44:05 -05:00
Philippe Saint-Pierre 08eb0b74a9 Move the NULL check before the dereferencing try
CID 5968
2011-11-27 12:36:40 -05:00
Philippe Saint-Pierre b3fe883d9c replace usage of strncpy by strlcpy to insure NULL termination
CID 10631
2011-11-27 12:05:41 -05:00
Philippe Saint-Pierre 81a29f5613 Removing deadcode. Specific Case already taken care of.
CID 2865.
2011-11-27 11:41:29 -05:00
Philippe Saint-Pierre aec33db178 Replace inappropriate usage of strncpy by strlcpy 2011-11-27 11:10:39 -05:00
Philippe Saint-Pierre 3927bd3c0d Prevent string overflow by replacing usage of strcpy by strncpy
CID 8951, CID 10733, CID 10734, CID 10735, CID 10736, CID 10737, CID 10738,
CID 10739
2011-11-27 01:45:21 -05:00
Philippe Saint-Pierre d2780f6f25 Protects against possible NULL return from dynamic_cast
CID 10807
2011-11-27 00:55:13 -05:00
Philippe Saint-Pierre faadd0c5ca Missing call to InitCheck() causing deadcode
CID 2959
2011-11-27 00:42:18 -05:00
Philippe Saint-Pierre d9a215b71f Comparison with an unsigned value (size_t) and < 0
CID 4190 and CID 4191
2011-11-27 00:21:41 -05:00
Philippe Saint-Pierre 20e36f6e64 Missing call to InitCheck() causing deadcode
CID 10803
2011-11-26 23:22:18 -05:00
Philippe Saint-Pierre a633338fbe Memory leak fix
CID 5769
2011-11-26 21:57:05 -05:00
Philippe Saint-Pierre 374d5a4c6d Fix possible resource leakage and NULL dereference
* Use the std::nothrow behaviour of operator new
* Avoid to compare the CurrentDecorator at every iteration
* Avoid possible NULL dereference

Fix CID 10947 and CID 10889
2011-11-26 21:11:51 -05:00
Philippe Saint-Pierre 36e1394ccf Fix possible resource leakage
* Also use the std::nothrow behaviour of operator new
* and remove extra indent

Fix CID 10948
2011-11-26 20:57:22 -05:00
Philippe Saint-Pierre 552d99013a Replace usage of sprintf with snprintf
Fixing CID 10964
2011-11-26 20:17:46 -05:00
Philippe Saint-Pierre 6b41836304 Add missing break statement
Fix CID 3304
2011-11-23 20:57:12 -05:00
Philippe Saint-Pierre e904435328 Missing break statement
Resolves CID 3401
2011-11-23 20:00:25 -05:00
Philippe Saint-Pierre 8458b41ba6 Merge branch 'master' of ssh://git.haiku-os.org/haiku 2011-11-13 22:21:17 -05:00
Philippe Saint-Pierre a9e957e2de DiskUsage: Implement truncation in tabs labels
* To allow more devices to be shown and accessible within
  DiskUsage, truncate the columns names if necessary.

Might help but not quite fix #6800.
2011-11-13 22:20:25 -05:00
Philippe Saint-Pierre e11b156da9 Fix for Defaults button issues in Appearance preflet
* Implement isDefaultable() and SetDefaults() for Antialiasing tab;
* The default color set was out of sync with the actual colors,
  it now gets the actual colors rather than hardcoding them;
* Some hardcoded values for defaults related to antialiasing were
  differents from actual default values stated in AppServer;
* Revert now works for Antialiasing settings also.

Fix #3331
2011-11-12 20:34:12 -05:00
Philippe Saint-Pierre 9cf506a2bf Tracker:
* Add "Arrange By" submenu in Window menu.
 * You can arrange by the same fields you can sort by in list view. Changing your sorting order in list view will change the Arrange By choice when you enter icon view and vice-versa.
 * Support ReverseSort order.
 * Keep the clean-up feature, but it's now under the Arrange By menu.

Fixing ticket #1349.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42448 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-07-19 03:52:42 +00:00
Philippe Saint-Pierre 8ec0a4a37d Cpu Identification :
* Don't return Core 2 Extreme as a fallback result, keep the more generic variant Core 2 for this.
 * Test the presence of "Pentium" in the name and in that case, use that word to identify, despite
   the family id/product name confusion.

Might fix #6136, #4427.  needs testing.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42405 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-07-10 21:03:53 +00:00
Philippe Saint-Pierre cb2f9709c5 The destination directory wasn't stored in the UndoRedo record in the case of a duplication operation, causing issues when trying to redo an undone duplication (couldn't find the volume correctly).
Fixes #2883.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42328 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-06-27 03:11:35 +00:00
Philippe Saint-Pierre 85c3d59821 dstcheck:
* Change button labels to use verbs.  Since the labels are now "Use this time" and "Manually adjust time...", don't ask for a second confirmation in case you chose to adjust time.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40932 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-03-13 19:28:24 +00:00
Philippe Saint-Pierre c45c76e658 DeskCalc
Move the Invalidate() call introduced in r40863. It is now in FrameResized().

This now seems to fix #7010 for good.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40864 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-03-08 01:50:25 +00:00
Philippe Saint-Pierre 13b4be3fb2 DeskCalc:
Invalidate the CalcView after changing the Show Keypad option, to force to redraw the keypad.

Fixes ticket #7010.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40863 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-03-07 23:33:08 +00:00
Philippe Saint-Pierre d8e2b9fea6 dstcheck:
* Make alerts closeable using escape

fixes ticket #6902.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40862 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-03-07 23:01:45 +00:00
Philippe Saint-Pierre 95780b6475 Allow DiskUsage to be used as a Tracker add-on again.
Fixes #7343.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40859 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-03-07 19:13:21 +00:00
Philippe Saint-Pierre d020e3568f Screenshot
* Fix violations to coding guidelines
 * Error checks on the received entry_refs
 * Typo in comment

Thanks Axel!


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40843 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-03-06 14:14:37 +00:00
Philippe Saint-Pierre c6d2f9af2c Screenshot
* Consider the message that the FilePanel returns and add the path to the output destination MenuField.

Ticket #6886


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40826 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-03-05 22:13:12 +00:00
Philippe Saint-Pierre 471b5ec496 DiskUsage :
* Reduce the height of the StatusView. It was way taller than necessary.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40772 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-03-02 00:22:24 +00:00
Philippe Saint-Pierre 85b2f68b69 Fix build on gcc2.
(Note, I honestly have no idea what was initially wrong with the code; everything seamt right to me..)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40676 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-02-25 01:49:26 +00:00
Philippe Saint-Pierre b754759693 Replace occurences of strcpy and strcat by strlcpy and strlcat. At both places, while improbable, it was possible to get string overflows.
CID 9043, 9044


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40650 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-02-24 01:23:21 +00:00
Philippe Saint-Pierre 0e952e21c3 If the template name was long enough, we would have exceeded the string size.
CID 9046


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40649 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-02-24 01:09:24 +00:00
Philippe Saint-Pierre 14afc67b4c DeskCalc:
* Replace usage of strcpy by strlcpy (CID 6790)
 * Check the return value of FindApp before continuing (CID 2366)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40634 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-02-23 02:08:03 +00:00
Philippe Saint-Pierre 8d779aa8df DiskUsage :
* add two missing break; (CID 3301, 3302)
  * replace strcpy, strcat and sprintf by strlcpy, strlcat and snprintf
    (CID 6804, 6805, 6806, 6807, 6808, 8962, 8963)
  * remove a PrintToStream (left by accident for debugging purposes)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40631 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-02-23 01:08:25 +00:00
Philippe Saint-Pierre 2905062e64 In CharacterMap:
Separate the CodeView (info section at the bottom of the window)
in 2 sections, one with the character itself, the other with the
remaining infos (hex code, etc..)

The idea behind this is that if the font in the CharacterView above
is different than the default font used in that CodeView, it might
happen that a glyph doesn't show in the CodeView below but was shown
in the CharacterView above, or vice-versa.


Fixes ticket #4020


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40589 a95241bf-73f2-0310-859d-f6bbb57e9c96
2011-02-21 01:56:00 +00:00
Philippe Saint-Pierre dde4ac4386 DiskUsage enhancement (ticket #3520)
* the volume are now displayed in tabs, mounting and unmounting volume adds and remove tabs accordingly
 * the infos (file size, etc..) are now displayed below the graph
 * node monitoring tells you when your current view is outdated. (the ticket suggested to adjust the view automatically, but I'll wait for comments on this first).
 * Drag&Dropping a file on the graph changes the tabview to the tab representing the volume owning that file.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38958 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-10-12 23:50:09 +00:00
Philippe Saint-Pierre 216cd910b6 Fix small typo in safe mode options menu.
"compatibilty" => "compatibility"


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37268 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-06-27 01:36:47 +00:00
Philippe Saint-Pierre 98d5d91cbf DiskUsage: Usability enhancement
* When clicking in a outer sector, the middle circle now takes the color the outer sector had, helping to keep some consistency.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35779 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-03-07 21:07:24 +00:00
Philippe Saint-Pierre de4212d411 NetServer: Clear the IFF_AUTO_CONFIGURED as needed. It was cleared at reboot, but not when the config file was updated.
Fixing ticket #3912.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35410 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-02-05 02:30:38 +00:00
Philippe Saint-Pierre 767d444609 MediaPlayer Playlist:
* Reset the DropIndex when the drag is exiting the window.
 * Otherwise, the anticipation rect isn't set back on when you enter again the window.

Fixes ticket #3199.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35409 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-02-05 00:55:33 +00:00
Philippe Saint-Pierre 686c893326 desklink: --list fixes
* Don't assume that ids to be contiguous (and to start at 0).
 * Use the executable's name as the replicant view name (to ease its identification and removal)

Fixes ticket #5354.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35402 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-02-04 01:37:21 +00:00
Philippe Saint-Pierre 481a903a81 DeskBar: Adds a new setting (called ...Enabled) to determine if we show a particular Recent Menu.
* the previous behaviour was to consider it enabled if the count was above 0, and disabled otherwise.
 * the new behaviour is to consider it disabled if the count is 0, but also allows to disable it by unchecking the box in the pref window, without setting the count to 0 (losing its value).

Fixes ticket #5007.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35355 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-01-31 02:49:10 +00:00
Philippe Saint-Pierre 005e1e3073 ActivityMonitor: Add a 7px margin (when necessary) to the legend to avoid having the dragger overlaps the labels.
Fixing ticket #3319.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35353 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-01-31 01:03:43 +00:00
Philippe Saint-Pierre d6a142a912 Expander: don't use fLineHeight before its value is calculated. And don't resize the window to a size smaller than the calculated minHeight.
* This fixes a bug where checking "show contents" before a source archive is chosen makes the window go tiny.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35350 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-01-30 20:33:48 +00:00
Philippe Saint-Pierre 41b65b532e Patch by mmadia, updates Firefox's Optional Package
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35233 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-01-22 01:17:31 +00:00
Philippe Saint-Pierre 94a20a5e74 [Expander]: Fix for Zoom
* When the zip file was really large, it was possible the Height passed to SetZoomLimit exceeded the maximum allowed size. Now, we clip at 32767.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35193 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-01-20 03:56:36 +00:00
Philippe Saint-Pierre 03734edfef [Expander] : Window Sizing enhancements
* Now takes the screen size into consideration when enlarging the window (fixing ticket #5280)
 * Enables Zooming capabilities
 * Remembers the last height of the window so that clicking Show contents on and off just returns it to the previous height.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35188 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-01-19 23:31:58 +00:00
Philippe Saint-Pierre 431bbe1cc2 [Pulse] More compact display of the dragger in replicants. (follow-up of #4244)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35138 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-01-17 22:51:24 +00:00
Philippe Saint-Pierre ebb64acec1 [Expander]:
* Use be_fixed_font in the Show Content TextView (fixes ticket #5272).
 * Minor cleanup in ExpanderThread.cpp


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35122 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-01-17 17:00:08 +00:00
Philippe Saint-Pierre 9b178bf778 Make sure the Replicant PopUpMenu says "About Pulse..." rather than "About CPUButton...". (Follow-up of #4244).
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35116 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-01-17 15:29:04 +00:00
Philippe Saint-Pierre 2ee53d23fa Fix gcc4 build error.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35111 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-01-17 08:48:51 +00:00
Philippe Saint-Pierre e20b156868 Pulse : Couldn't close Pulse CPUButton replicants
* It nows leave enough room to display the dragger into the replicant in most
   cases...

 * ...excepts in deskbar.  Then it instead allows you to right click to 
   access a popup menu allowing you to close the replicant.

   The dragger isn't shown due to space constraints.

Fixing ticket #4244.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35110 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-01-17 05:12:09 +00:00
Philippe Saint-Pierre e45d83a9c8 ActivityMonitor: Style violation fixed. Thanks Axel!
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35101 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-01-16 16:38:12 +00:00
Philippe Saint-Pierre 85b9f10561 Apply patch by mmadia to increase the image size to 650MB. Ticket #5255.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35095 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-01-16 01:10:32 +00:00
Philippe Saint-Pierre fbb82a6282 ActivityMonitor :
* Add a 2px bottom padding when used as a replicant, to account for possible 
   outline.  (Thanks stippi!)
 * Fix style violation (Thanks Axel!)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35092 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-01-15 23:23:22 +00:00
Philippe Saint-Pierre bb7cffd0d1 ActivityMonitor (when used as replicant) :
* Use the "Icon Label Outline" setting to improve readability
 * It is using the same algorithm as Tracker to outline and glow the text,
   and determine the color of the text.

Implements enhancement suggestion #5105.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35084 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-01-15 03:08:18 +00:00
Philippe Saint-Pierre 83de0ccdec Launchbox was displaying the description of the application into its tooltips
even if it meant displaying the same label twice.

Fixes bug #5233.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@35002 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-01-11 00:53:22 +00:00
Philippe Saint-Pierre fc7d806ef9 PoorMan Server : fix for several style violations (blanks between operators,
blanks after commas, 80 chars/line)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34712 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-12-19 21:08:25 +00:00
Philippe Saint-Pierre 7dbb668dca Switcher : Use the B_OP_COPY draw mode to clear the icon's background
during the animation, rather than B_OP_ALPHA. This avoids a darker 
background than supposed when you cycle through the icons.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34434 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-12-01 23:49:10 +00:00
Philippe Saint-Pierre 001731449e Don't minimize windows (when hiding applications) if they have
the B_NOT_MINIMIZABLE flag. It should more properly fix #4337.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34351 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-11-29 19:55:02 +00:00
Philippe Saint-Pierre 5f341c3847 Reverting r34335. Wrong location of my "B_NOT_MINIZABLE" check.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34350 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-11-29 19:02:47 +00:00
Philippe Saint-Pierre 2c9bea98b9 Make BWindow honor the B_NOT_MINIMIZABLE flag. Fixes ticket #4337.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34335 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-11-29 02:15:54 +00:00
Philippe Saint-Pierre 37e44362b6 DiskProbe :
* Fix a gcc4 warning in the boolean operation



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34203 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-11-23 22:59:59 +00:00
Philippe Saint-Pierre f75975a907 ShowImage :
* Changing pictures using the arrow keys while being in a picture folder in tracker would quit the 
  fullscreen mode (if you happen to be in that mode) because it tries to resize the window to fit
  the new picture.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34194 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-11-23 02:54:13 +00:00
Philippe Saint-Pierre de2af681ea DiskProbe :
In is_valid_utf8():
 * Also accept CR and TAB as valid chars to be copied in clipboard.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34193 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-11-23 01:04:28 +00:00
Philippe Saint-Pierre 7c47a09644 Diskprobe :
in is_valid_utf8() :
 * Accept EOL/LF as part of a valid UTF8 string.
 * This allow a string containing it to be copied to the clipboard.
 * Fixing ticket #1453.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34192 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-11-23 00:52:49 +00:00
Philippe Saint-Pierre 59d398a1ae DiskProbe:
* The is_valid_utf8(..) is supposed to accept a terminating null byte
but was instead looking for a null byte as the first byte.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34191 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-11-23 00:34:44 +00:00
Philippe Saint-Pierre 40dd3b47ca DiskProbe :
Use the Insert method when pasting text into the find window 
 rather than SetText. 

 This fixes ticket #3344 while making more sense semantically.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34181 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-11-22 03:08:58 +00:00
Philippe Saint-Pierre afdc051482 Network preflet : Wrongly forces to input a gateway and a DNS server
* While adding IPv4 basic validation, I overseen the possibility to leave those fields blank. Now, those fields can be left blank if you wish.

Fixing ticket #4487.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33119 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-09-13 17:29:19 +00:00
Philippe Saint-Pierre 4c58935dca MidiPlayer : CenterOnScreen
* Remove the local version (not really working) of CenterOnScreen and use the shared one.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33084 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-09-12 06:20:51 +00:00
Philippe Saint-Pierre 8e32a27e6f SoundRecorder : Several style "fixup". No functional change.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33077 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-09-12 05:19:52 +00:00
Philippe Saint-Pierre 0da53e3dd0 Installer : truncated string in menu fields
* Delay the display of the alert just a little bit, to let the menu fields enough time to adjust.

Fixes ticket #3893.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33076 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-09-12 03:44:10 +00:00
Philippe Saint-Pierre 8b93f21c22 Expander: Smarter window resize
* Rather than enlarging the window on (potentially) every line, simply keep the largest delta and use it only once at the end of the listing.

Ref: r33073 and ticket #3797.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33075 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-09-12 03:09:52 +00:00
Philippe Saint-Pierre 80c5515366 Expander: Smarter window sizing
* When using the "Show Content" feature, enlarge the window horizontally rather than wrapping.

Ref: enhancement request #3797.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33073 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-09-12 02:59:50 +00:00
Philippe Saint-Pierre 8a0ea31a5a Fonts Preflet : The centering didn't work.
* Make use of CenterOnScreen(); to center the window rather than the dirty trick I tried months ago.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33071 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-09-12 01:39:18 +00:00
Philippe Saint-Pierre 608aa1d9db ScreenSaver : Clean up the sanitize routine to use the isalnum(..) function.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33070 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-09-12 01:16:15 +00:00
Philippe Saint-Pierre f639adf33e ScreenSaver: Didn't accept a one char password
* Sanitize (and pad) the salt passed to the crypt function
* Made the password and confirm password control the same size.

Fixes ticket #4466.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33069 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-09-12 00:57:55 +00:00
Philippe Saint-Pierre 29c4d5a983 ShowImage: Using the up and down arrow to change images from a tracker folder,
and loading an image bigger than the current window size didn't get the window enlarged.

exceptions: the window doesn't get resized by this mean if you check the Shrink to window or Zoom to window settings.

Fixes ticket #4273.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32502 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-08-19 02:20:10 +00:00
Philippe Saint-Pierre bc6272feed Registrar Shutdown window: Make Font Size sensitive
* Removed the WordWrap from the text view, until we computed the TextHeight(), then put it again, once the textview got resized.

I think it might be hiding an other bug in the way we compute TextHeight(), but it seems to be a workaround.

(Fixing?) Ticket #169


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32501 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-08-19 01:30:56 +00:00
Philippe Saint-Pierre b4c89c3b30 Shutdown submenu in BeMenu: Make it font sensitive.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32500 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-08-18 23:22:11 +00:00
Philippe Saint-Pierre d939e03d05 PoorMan: Close the application when you choose Cancel on first launch.
* If you choose cancel on that first dialog, also don't save a config file
* Also fixes the button labelling in the preference panel (several were clipped)
* Allow the user to cancel the selection of the web folder and return to the initial dialog (to choose Default, for example)
* Make the preference panel closable with escape key
* Multiple coding style changes

(Ref: Ticket #4255)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32486 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-08-18 00:32:57 +00:00
Philippe Saint-Pierre 37dd4be139 Code style violation (80 char limit);
No functional changes.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32451 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-08-17 02:19:13 +00:00
Philippe Saint-Pierre 4973feeaa0 When testing a screensaver..
1. Stop the preview
2. Start it again after the test is done

This prevents the case where the screen is filled with a color during the first frame of the screensaver. 
When you return to the preview (after the Test), that first frame is long gone and the preview is then invalid.

Reference : DebugNow screen saver.

Ticket #4252


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32450 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-08-17 02:10:43 +00:00
Philippe Saint-Pierre 16424a2470 Removed unnecessary error messages on first launch :
* When you select Cancel, it did display an alert saying it couldn't start the server, and then displays the main window. That error message was unnecessary since the text box (in the main window) already says so.
* When you click on Select, it displays the same error message, and then display the file panel. That error message didn't exactly made sense in that context.

minor style violation (2 lines spacing between methods)
Fixing ticket #4255


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32449 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-08-16 23:58:39 +00:00
Philippe Saint-Pierre a5dc8f8639 Reverting r30894 as it seems it is what was causing the slowness reported in ticket #4247.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32441 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-08-16 16:44:31 +00:00
Philippe Saint-Pierre da2b227ec7 Preference panel : Reverted some of my "optimizations" since Ingo (correctly) points out that:
* they (the way I did it) can do more worse than good in some case
* they (the way I did it) are generally against our coding-style

Sorry about that. (ticket #4245)


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32439 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-08-16 15:31:09 +00:00
Philippe Saint-Pierre 2c3476d3b7 Further optimization in the construction time of the Preference Panel (ticket #4245).
Indentation fix.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32435 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-08-16 05:31:27 +00:00
Philippe Saint-Pierre 307c87b225 Preference panel: Optimizations to make the window appear faster.
* In most case, the font size will already have been found with the regular check, move the extra check at the end if really it's needed.
* Some variables were declared inside loops (BTW, is that more conform to our coding style? It does feel faster if I declare them outside of the loop)
* The alignment was simplified (without visual difference).

In answer to ticket #4245.



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32434 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-08-16 04:13:26 +00:00
Philippe Saint-Pierre 6478aa2744 Screenshot:
* Add extension to the filename. It gets the extension from the BMimeType related to the chosen translator.
* When you change the output format, the extension change accordingly.
* Some variable name change (variable_name -> variableName)

Ticket #3728


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32433 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-08-16 03:12:33 +00:00
Philippe Saint-Pierre 34e1987b61 Backgrounds Preflet : Fix the build
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32432 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-08-16 01:13:24 +00:00
Philippe Saint-Pierre fcafc3a5bb Screenshot command line arguments :
* make Screenshot exit gracefully if no argument is given in combination of -d parameter
* honor the delay parameter when also used with the --silent parameter



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@32431 a95241bf-73f2-0310-859d-f6bbb57e9c96
2009-08-16 00:51:05 +00:00