We publish devices in the driver register hook, and if we try to unpublish them from the device removed hook, not the driver removed hook, we'll confuse the device_manager and cause it to do use-after-frees on list iteration. The two are called in quick succession of each other, so this shouldn't cause problems. Fixes a KDL reported by OscarL when unplugging a USB card reader (which I reproduced with another USB card reader.) It seems the problem would happen with any USB disk device that published more than one LUN. (cherry picked from commit a688b173e7c1e903845b6cac78baa7bd2ea23c31) Change-Id: Ia9fae3428a45e199cb2c903acfe9c689dfa9bed4 Reviewed-on: https://review.haiku-os.org/c/haiku/+/11305 Reviewed-by: waddlesplash <[email protected]>
Haiku
Homepage | Mailing Lists | IRC Channels | Issue Tracker | API docs
Haiku is an open-source operating system that specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful.
Goals
- Sensible defaults with minimal configuration required.
- Clean, clear, concise code.
- Unified desktop environment.
Trying Haiku
Haiku provides pre-built nightly images and release images. Haiku is compatible with a large variety of hardware, but in case you don't want to "take the plunge" and install Haiku on bare metal, you can install it on a virtual machine (VM) instead. If you've never used a VM before, you can follow one of the "Emulating Haiku" guides.
Compiling Haiku
See ReadMe.Compiling.
Contributing
Haiku is a meritocratic open source project with a large variety of tasks. Even if you can't write code, you can still help! Haiku needs designers, (technical) writers, translators, testers... Get involved and help out!
Contributing code
If you're submitting a patch to us, please make sure you're following the patch submitting guidelines.
If you're having trouble finding something in the source tree, you can use one of our web-based source code browsers:
- https://grok.nikisoft.one/opengrok/ (OpenGrok, provided by Niklas Poslovski)
- https://git.haiku-os.org/ (git, provided by Haiku, Inc.)
Contributing documentation
The main piece of documentation that still needs work are the API docs (found
in the tree at docs/user). Just find an undocumented class, write
documentation for it, and submit a patch.
Contributing translations
See wiki:i18n.
Contributing software ports
See HaikuPorts.
Contributing to our infrastructure
See Infrastructure.