Augustin Cavalier
13491fd259
* Get rid of the multiple entries/condition-variables system. Instead, allocate one structure per variable and do not add/remove it from the hash until all waiters are gone. * Get rid of "locked". All wait wakeups of B_OK mean "locked". All nonzero values mean "not locked." This mirrors what the kernel mutex implementation does (however, that also tracks the owning thread, for assertion's sake.) * Remove "lastWaiter" logic (for now.) As we no longer hold a lock after wakeup, we cannot reliably check and act on it outside the "wait" function. This means that interrupted or timed-out waits will cause a potentially unnecessary syscall on next unblock, but that will be resolved in the next commit. Due to the single global lock, user mutex acquisition is an extremely "noisy" process that can take shorter or longer depending on what is going on elsewhere on the system, so performance is hard to measure. With one benchmark that acquires mutexes as fast as possible with lots of contention, most runs came in as being around the same amount of time both before and after this change (around 4.25s real). Moving Terminal's window around while running the test caused runtime to go up to around 6.7s before this change, and about 7.0s after. GLTeapot seems to go from 350-380 FPS before this change and 320-340 after. It still spends the vast majority of its time waiting for address space and cache locks, however. It is expected that the next commits will build on this change to improve performance beyond even the "before" numbers above. Change-Id: I6581a6f7cb0ca0513ea639f8499a1c0c8596c026 Reviewed-on: https://review.haiku-os.org/c/haiku/+/6490 Reviewed-by: waddlesplash <[email protected]> Reviewed-by: Adrien Destugues <[email protected]> Tested-by: Commit checker robot <[email protected]>
Haiku
Homepage | Mailing Lists | IRC Channels | Issue Tracker | API docs
Haiku is an open-source operating system that specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful.
Goals
- Sensible defaults with minimal configuration required.
- Clean, clear, concise code.
- Unified desktop environment.
Trying Haiku
Haiku provides pre-built nightly images and release images. Haiku is compatible with a large variety of hardware, but in case you don't want to "take the plunge" and install Haiku on bare metal, you can install it on a virtual machine (VM) instead. If you've never used a VM before, you can follow one of the "Emulating Haiku" guides.
Compiling Haiku
See ReadMe.Compiling.
Contributing
Haiku is a meritocratic open source project with a large variety of tasks. Even if you can't write code, you can still help! Haiku needs designers, (technical) writers, translators, testers... Get involved and help out!
Contributing code
If you're submitting a patch to us, please make sure you're following the patch submitting guidelines.
If you're having trouble finding something in the source tree, you can use one of our web-based source code browsers:
- https://xref.landonf.org/ (OpenGrok, provided by Landon Fuller)
- https://git.haiku-os.org/ (git, provided by Haiku, Inc.)
Contributing documentation
The main piece of documentation that still needs work are the API docs (found
in the tree at docs/user). Just find an undocumented class, write
documentation for it, and submit a patch.
Contributing translations
See wiki:i18n.
Contributing software ports
See HaikuPorts.
Contributing to our infrastructure
See Infrastructure.