Adrien Destugues
a8b90daa8a
- Number of retries could overflow. If we retry something more than 255 times and it fails, just stop, instead of flooding the network with bogus requests - The timeout could also overflow. It was stored in microseconds in a time_t, which allows a bit more than an hour. This is fine for the initial timeout (which starts at a few seconds and will go up to 64 seconds), but after that we switch to a slower rate driven by the "state time". In particular, this can be the lease time, which DHCP servers may set to several days, or at least easily more than an hour. - The computaiton of the timeout in the "slow lease" case attempted to do "not less than a minute", but missed a conversion from microseconds to seconds so it ended up doing "not less than 60 microseconds" The combination of all these things means we can end up with a negative timeout, and we will send a burst of requests without ever stopping, flooding the network. Change-Id: I0eb811c90f4a4dd8c9d92bff728bc2bbb52fbd56 Reviewed-on: https://review.haiku-os.org/c/haiku/+/4826 Tested-by: Commit checker robot <[email protected]> Reviewed-by: Fredrik Holmqvist <[email protected]> Reviewed-by: waddlesplash <[email protected]>
Haiku
Homepage | Mailing Lists | IRC Channels | Issue Tracker | API docs
Haiku is an open-source operating system that specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful.
Goals
- Sensible defaults with minimal configuration required.
- Clean, clear, concise code.
- Unified desktop environment.
Trying Haiku
Haiku provides pre-built nightly images and release images. Haiku is compatible with a large variety of hardware, but in case you don't want to "take the plunge" and install Haiku on bare metal, you can install it on a virtual machine (VM) instead. If you've never used a VM before, you can follow one of the "Emulating Haiku" guides.
Compiling Haiku
See ReadMe.Compiling.
Contributing
Haiku is a meritocratic open source project with a large variety of tasks. Even if you can't write code, you can still help! Haiku needs designers, (technical) writers, translators, testers... Get involved and help out!
Contributing code
If you're submitting a patch to us, please make sure you're following the patch submitting guidelines.
If you're having trouble finding something in the source tree, you can use one of our web-based source code browsers:
- https://xref.landonf.org/ (OpenGrok, provided by Landon Fuller)
- https://git.haiku-os.org/ (git, provided by Haiku, Inc.)
Contributing documentation
The main piece of documentation that still needs work are the API docs (found
in the tree at docs/user). Just find an undocumented class, write
documentation for it, and submit a patch.
Contributing translations
See wiki:i18n.
Contributing software ports
See HaikuPorts.
Contributing to our infrastructure
See Infrastructure.