Augustin Cavalier
d7c71d7b49
First, we don't need to generate ACKs for every other segment received, only every second full-size segment or within 500ms, as the comment notes. So check the receive window size before deciding to send an ACK immediately. Second, let the timeout routine handle sending the ACK even in the immediate invocation case. This way, we don't spend time in receive routines waiting for the send path locks, and also multiple packets received in quick succession will have one ACK generated instead of many. Also, following the previous commit, the timeout routine will avoid generating duplicate ACKs now. In the case where a duplicate ACK really needs to be generated, DelayedAcknowledge won't be used anyway. Inspired by ambroff's remarks and patch in comment:14 of #18203. Greatly reduces the number of ACKs generated, and increases throughput due to less duplicate ACKs causing congestion logic to kick in. Change-Id: I37991464b1a802aceb3e2b453df8dc4cb2e14ce5 Reviewed-on: https://review.haiku-os.org/c/haiku/+/7284 Reviewed-by: Alex von Gluck IV <[email protected]> Reviewed-by: waddlesplash <[email protected]>
Haiku
Homepage | Mailing Lists | IRC Channels | Issue Tracker | API docs
Haiku is an open-source operating system that specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful.
Goals
- Sensible defaults with minimal configuration required.
- Clean, clear, concise code.
- Unified desktop environment.
Trying Haiku
Haiku provides pre-built nightly images and release images. Haiku is compatible with a large variety of hardware, but in case you don't want to "take the plunge" and install Haiku on bare metal, you can install it on a virtual machine (VM) instead. If you've never used a VM before, you can follow one of the "Emulating Haiku" guides.
Compiling Haiku
See ReadMe.Compiling.
Contributing
Haiku is a meritocratic open source project with a large variety of tasks. Even if you can't write code, you can still help! Haiku needs designers, (technical) writers, translators, testers... Get involved and help out!
Contributing code
If you're submitting a patch to us, please make sure you're following the patch submitting guidelines.
If you're having trouble finding something in the source tree, you can use one of our web-based source code browsers:
- https://xref.landonf.org/ (OpenGrok, provided by Landon Fuller)
- https://git.haiku-os.org/ (git, provided by Haiku, Inc.)
Contributing documentation
The main piece of documentation that still needs work are the API docs (found
in the tree at docs/user). Just find an undocumented class, write
documentation for it, and submit a patch.
Contributing translations
See wiki:i18n.
Contributing software ports
See HaikuPorts.
Contributing to our infrastructure
See Infrastructure.