Augustin Cavalier
f0a016dcb1
I looked at this code as a reference when writing similar code in another project, and realized then that this was broken to the point where I don't think anyone could have actually used it: 1. Writes larger than the buffer should only return the amount written by this Write() call, not the amount flushed beforehand. 2. fDirty was only set if there were bytes remaining after the first write to the buffer. So, if you wrote small amounts of data, they would be silently discarded most of the time! 3. When filling the buffer, we might as well flush simultaneously. This allows the logic to be consolidated into a loop and remove the duplicate memcpy. In case of failure, just return the bytes-written as the write could be retried later. 4. Flush() should always return an error or 0, not bytes written. While at it, add some basic tests for this class. Change-Id: I2de01d0b31e3fe22863cef21dd7b0b62ed47121b
Haiku
Homepage | Mailing Lists | IRC Channels | Issue Tracker | API docs
Haiku is an open-source operating system that specifically targets personal computing. Inspired by the BeOS, Haiku is fast, simple to use, easy to learn and yet very powerful.
Goals
- Sensible defaults with minimal configuration required.
- Clean, clear, concise code.
- Unified desktop environment.
Trying Haiku
Haiku provides pre-built nightly images and release images. Haiku is compatible with a large variety of hardware, but in case you don't want to "take the plunge" and install Haiku on bare metal, you can install it on a virtual machine (VM) instead. If you've never used a VM before, you can follow one of the "Emulating Haiku" guides.
Compiling Haiku
See ReadMe.Compiling.
Contributing
Haiku is a meritocratic open source project with a large variety of tasks. Even if you can't write code, you can still help! Haiku needs designers, (technical) writers, translators, testers... Get involved and help out!
Contributing code
If you're submitting a patch to us, please make sure you're following the patch submitting guidelines.
If you're having trouble finding something in the source tree, you can use one of our web-based source code browsers:
- https://xref.landonf.org/ (OpenGrok, provided by Landon Fuller)
- https://git.haiku-os.org/ (git, provided by Haiku, Inc.)
Contributing documentation
The main piece of documentation that still needs work are the API docs (found
in the tree at docs/user). Just find an undocumented class, write
documentation for it, and submit a patch.
Contributing translations
See wiki:i18n.
Contributing software ports
See HaikuPorts.
Contributing to our infrastructure
See Infrastructure.