Debugger: don't auto-download packages non-interactively.

- When in non-interactive mode, i.e. saving a crash report, don't
  allow the image debug info loader to automatically grab missing but
  available info packages. Otherwise we potentially download very large
  packages with the user being entirely unaware, i.e. the 200MB debug
  information package now present by default for gcc7's libgcc. This
  should eventually be made a configurable preference though.
This commit is contained in:
Rene Gollent
2018-06-14 16:51:32 -04:00
parent b337e9a8fd
commit 211cb77acf
@@ -99,10 +99,8 @@ DwarfLoadingStateHandler::HandleState(
choice = interface->SynchronouslyAskUser("Debug info missing",
message.String(), "Install", "Locate", "Skip");
}
} else {
choice = requiredPackage.IsEmpty()
? USER_CHOICE_SKIP : USER_CHOICE_INSTALL_PACKAGE;
}
} else
choice = USER_CHOICE_SKIP;
if (choice == USER_CHOICE_INSTALL_PACKAGE) {
// TODO: integrate the package installation functionality directly.